From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from resdmta-c1p-023852.sys.comcast.net (resdmta-c1p-023852.sys.comcast.net [96.102.19.44]) by mx.groups.io with SMTP id smtpd.web09.24733.1664981796478361147 for ; Wed, 05 Oct 2022 07:56:36 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@comcastmailservice.net header.s=20211018a header.b=PD4yqliw; spf=softfail (domain: google.com, ip: 96.102.19.44, mailfrom: robwoo@google.com) Received: from resomta-c1p-022590.sys.comcast.net ([96.102.18.239]) by resdmta-c1p-023852.sys.comcast.net with ESMTP id g4MqoxIM3N0Wxg5p5ourrS; Wed, 05 Oct 2022 14:56:35 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=comcastmailservice.net; s=20211018a; t=1664981795; bh=UGsoC3VILX8af8k6DUVdL6uaI5IeAZ5X/3+/gBLTJM0=; h=Received:Received:From:To:Subject:Date:Message-Id:MIME-Version: Content-Type; b=PD4yqliwcUlZ739rE9IlKdYI6iFAzWq86U3eDf2AHtiEgG5I3vCaFXtcKSiDqsuW3 zkg75xJqp1RPYaFuwLrfGiB3rqcNma9brFpejUfVx9n5Xu2CH46QUVzKumRtuM3APd 2MaPFMrrv8DsEdWtoeZ3CoPiB1hcbblPJji23gl+X0/oRM52ClFwMeTmgmtNqv6h3v EnQrkOCF9lMW2d4JdT5INUj7m9YZlIwR/tdfk8ws0Olxt323akrFSxEXVGeOSywyHP J/drmAUg/dixShascr2FLzU+R8+iyfRKhusrZu3w+JxKy+XZgKp3t9MXgoaQIGZlnQ jKw1TjY9OtvFQ== Received: from robwoo-glaptop.corp.google.com ([IPv6:2620:15c:10f:203:604c:b96:bea4:21ed]) by resomta-c1p-022590.sys.comcast.net with ESMTPA id g5oJo1y9FYuTgg5oook2YR; Wed, 05 Oct 2022 14:56:32 +0000 X-Xfinity-VMeta: sc=-100.00;st=legit From: "Robert Wood" To: devel@edk2.groups.io Cc: Samer El-Haj-Mahmoud , G Edhaya Chandran , Barton Gao , Carolyn Gjertsen Subject: [PATCH v1 1/1] MiscBootServices: Stall_Func: Reduces the stall interval for Stall_Func Date: Wed, 5 Oct 2022 07:55:46 -0700 Message-Id: <20221005145546.176712-2-robwoo@google.com> X-Mailer: git-send-email 2.38.0.rc1.362.ged0d419d3c-goog In-Reply-To: <20221005145546.176712-1-robwoo@google.com> References: <20221005145546.176712-1-robwoo@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable The Stall_Func test on the highest TPL causes issues with the disk IO by blocking interrupts. This blocking can cause disk corruption through IO timeouts. Since this doesn't seem to be the intent of the test this revision reduces the stall interval from 10 seconds to 4 and adjusts the delta=C2=A0tolerance in scale. Signed-off-by: Robert Wood Cc: Samer El-Haj-Mahmoud Cc: G Edhaya Chandran Cc: Barton Gao Cc: Carolyn Gjertsen --- uefi-sct/SctPkg/TestCase/UEFI/EFI/BootServices/MiscBootServices/BlackBoxTe= st/MiscBootServicesBBTestMain.h | 2 +- uefi-sct/SctPkg/TestCase/UEFI/EFI/BootServices/MiscBootServices/BlackBoxTe= st/MiscBootServicesBBTestFunction.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/uefi-sct/SctPkg/TestCase/UEFI/EFI/BootServices/MiscBootService= s/BlackBoxTest/MiscBootServicesBBTestMain.h b/uefi-sct/SctPkg/TestCase/UEFI= /EFI/BootServices/MiscBootServices/BlackBoxTest/MiscBootServicesBBTestMain.h index 9e98ec013c74..4f8eaa4c70ea 100644 --- a/uefi-sct/SctPkg/TestCase/UEFI/EFI/BootServices/MiscBootServices/Black= BoxTest/MiscBootServicesBBTestMain.h +++ b/uefi-sct/SctPkg/TestCase/UEFI/EFI/BootServices/MiscBootServices/Black= BoxTest/MiscBootServicesBBTestMain.h @@ -46,7 +46,7 @@ typedef struct _RESET_DATA { { 0xA6033499, 0xE4AF, 0x44f5, {0x9D, 0x16, 0x30, 0x78, 0xD8, 0x61, 0x32, = 0x28 }}=0D =0D #define TPL_ARRAY_SIZE 3=0D -#define MAX_SECOND_MARGIN 2=0D +#define MAX_SECOND_MARGIN 1=0D =0D //=0D // Change size from TPL_ARRAY_SIZE to TPL_ARRAY_SIZE + 1=0D diff --git a/uefi-sct/SctPkg/TestCase/UEFI/EFI/BootServices/MiscBootService= s/BlackBoxTest/MiscBootServicesBBTestFunction.c b/uefi-sct/SctPkg/TestCase/= UEFI/EFI/BootServices/MiscBootServices/BlackBoxTest/MiscBootServicesBBTestF= unction.c index ad72646bada2..f831ed6fbccc 100644 --- a/uefi-sct/SctPkg/TestCase/UEFI/EFI/BootServices/MiscBootServices/Black= BoxTest/MiscBootServicesBBTestFunction.c +++ b/uefi-sct/SctPkg/TestCase/UEFI/EFI/BootServices/MiscBootServices/Black= BoxTest/MiscBootServicesBBTestFunction.c @@ -827,7 +827,7 @@ BBTestStallInterfaceTest ( StartTime =3D Epoch; OldTpl =3D gtBS->RaiseTPL (TplArray[Index]);=0D Status =3D gtBS->Stall (=0D - 10000000=0D + 4000000=0D );=0D gtBS->RestoreTPL (OldTpl);=0D if (gtRT->GetTime (&EndTime, NULL) !=3D EFI_SUCCESS) --=20 2.38.0.rc1.362.ged0d419d3c-goog