[PATCH EDK2 v1 0/1] MdeModulePkg/TerminalDxe:Adding a switch for Terminal

[PATCH EDK2 v1 0/1] MdeModulePkg/TerminalDxe:Adding a switch for Terminal

[wenyi,xie]

Main Changes :
1.Adding a new PCD to control ternimal.

Wenyi Xie (1):
  MdeModulePkg/TerminalDxe:Adding a switch for Terminal

 MdeModulePkg/MdeModulePkg.dec                              | 4 ++++
 MdeModulePkg/Universal/Console/TerminalDxe/TerminalDxe.inf | 1 +
 MdeModulePkg/Universal/Console/TerminalDxe/Terminal.c      | 4 ++++
 3 files changed, 9 insertions(+)

-- 
2.20.1.windows.1

[PATCH EDK2 v1 1/1] MdeModulePkg/TerminalDxe:Adding a switch for Terminal

[wenyi,xie]

Adding a new PCD as switch to control Trlminal.

Cc: Jian J Wang <jian.j.wang@intel.com>
Cc: Liming Gao <gaoliming@byosoft.com.cn>
Cc: Zhichao Gao <zhichao.gao@intel.com>
Cc: Ray Ni <ray.ni@intel.com>
Signed-off-by: Wenyi Xie <xiewenyi2@huawei.com>
---
 MdeModulePkg/MdeModulePkg.dec                              | 4 ++++
 MdeModulePkg/Universal/Console/TerminalDxe/TerminalDxe.inf | 1 +
 MdeModulePkg/Universal/Console/TerminalDxe/Terminal.c      | 4 ++++
 3 files changed, 9 insertions(+)

diff --git a/MdeModulePkg/MdeModulePkg.dec b/MdeModulePkg/MdeModulePkg.dec
index 58e6ab004882..c4cf7f474a43 100644
--- a/MdeModulePkg/MdeModulePkg.dec
+++ b/MdeModulePkg/MdeModulePkg.dec
@@ -2161,6 +2161,10 @@ [PcdsDynamic, PcdsDynamicEx]
   # @Prompt GHCB Pool Size
   gEfiMdeModulePkgTokenSpaceGuid.PcdGhcbSize|0|UINT64|0x00030008
 
+  ## This dynamic PCD holds the Switch which decide whether to using Terminal or not.
+  # @Prompt Terminal Switch
+  gEfiMdeModulePkgTokenSpaceGuid.PcdTerminalSwitch|TRUE|BOOLEAN|0x01100002
+
 [PcdsDynamicEx]
   ## This dynamic PCD enables the default variable setting.
   #  Its value is the default store ID value. The default value is zero as Standard default.
diff --git a/MdeModulePkg/Universal/Console/TerminalDxe/TerminalDxe.inf b/MdeModulePkg/Universal/Console/TerminalDxe/TerminalDxe.inf
index b2a8aeba8510..36f6875de61b 100644
--- a/MdeModulePkg/Universal/Console/TerminalDxe/TerminalDxe.inf
+++ b/MdeModulePkg/Universal/Console/TerminalDxe/TerminalDxe.inf
@@ -87,6 +87,7 @@ [Protocols]
 [Pcd]
   gEfiMdePkgTokenSpaceGuid.PcdDefaultTerminalType           ## SOMETIMES_CONSUMES
   gEfiMdeModulePkgTokenSpaceGuid.PcdErrorCodeSetVariable    ## CONSUMES
+  gEfiMdeModulePkgTokenSpaceGuid.PcdTerminalSwitch          ## CONSUMES
 
 # [Event]
 # # Relative timer event set by UnicodeToEfiKey(), used to be one 2 seconds input timeout.
diff --git a/MdeModulePkg/Universal/Console/TerminalDxe/Terminal.c b/MdeModulePkg/Universal/Console/TerminalDxe/Terminal.c
index e2d779c78378..c861eb00d6d2 100644
--- a/MdeModulePkg/Universal/Console/TerminalDxe/Terminal.c
+++ b/MdeModulePkg/Universal/Console/TerminalDxe/Terminal.c
@@ -1344,6 +1344,10 @@ InitializeTerminal (
 {
   EFI_STATUS  Status;
 
+  if (!PcdGetBool(PcdTerminalSwitch)) {
+    return EFI_UNSUPPORTED;
+  }
+
   //
   // Install driver model protocol(s).
   //
-- 
2.20.1.windows.1

Re: [edk2-devel] [PATCH EDK2 v1 0/1] MdeModulePkg/TerminalDxe:Adding a switch for Terminal

[Michael D Kinney]

Hi,

Why is this new PCD and new behavior required?

There are standard ways from the UEFI Spec to manage
the set of active console output devices using console
variables.

Thanks,

Mike

> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of wenyi,xie via groups.io
> Sent: Tuesday, October 11, 2022 4:13 AM
> To: devel@edk2.groups.io; Wang, Jian J <jian.j.wang@intel.com>; Gao, Liming <gaoliming@byosoft.com.cn>; Gao, Zhichao
> <zhichao.gao@intel.com>; Ni, Ray <ray.ni@intel.com>
> Cc: songdongkuang@huawei.com; xiewenyi2@huawei.com
> Subject: [edk2-devel] [PATCH EDK2 v1 0/1] MdeModulePkg/TerminalDxe:Adding a switch for Terminal
> 
> Main Changes :
> 1.Adding a new PCD to control ternimal.
> 
> Wenyi Xie (1):
>   MdeModulePkg/TerminalDxe:Adding a switch for Terminal
> 
>  MdeModulePkg/MdeModulePkg.dec                              | 4 ++++
>  MdeModulePkg/Universal/Console/TerminalDxe/TerminalDxe.inf | 1 +
>  MdeModulePkg/Universal/Console/TerminalDxe/Terminal.c      | 4 ++++
>  3 files changed, 9 insertions(+)
> 
> --
> 2.20.1.windows.1
> 
> 
> 
> 
> 

Re: [edk2-devel] [PATCH EDK2 v1 0/1] MdeModulePkg/TerminalDxe:Adding a switch for Terminal

[wenyi,xie]

Hi, Mike

Thank you for your reply. We add a PCD because we want to dynamic disable the terminal through setupbrowser.
But as you said, the standard way is using console variables to manage it. We did not think about it before, we will have a try.

Thanks
Wenyi


On 2022/10/11 21:58, Kinney, Michael D wrote:
> Hi,
> 
> Why is this new PCD and new behavior required?
> 
> There are standard ways from the UEFI Spec to manage
> the set of active console output devices using console
> variables.
> 
> Thanks,
> 
> Mike
> 
>> -----Original Message-----
>> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of wenyi,xie via groups.io
>> Sent: Tuesday, October 11, 2022 4:13 AM
>> To: devel@edk2.groups.io; Wang, Jian J <jian.j.wang@intel.com>; Gao, Liming <gaoliming@byosoft.com.cn>; Gao, Zhichao
>> <zhichao.gao@intel.com>; Ni, Ray <ray.ni@intel.com>
>> Cc: songdongkuang@huawei.com; xiewenyi2@huawei.com
>> Subject: [edk2-devel] [PATCH EDK2 v1 0/1] MdeModulePkg/TerminalDxe:Adding a switch for Terminal
>>
>> Main Changes :
>> 1.Adding a new PCD to control ternimal.
>>
>> Wenyi Xie (1):
>>   MdeModulePkg/TerminalDxe:Adding a switch for Terminal
>>
>>  MdeModulePkg/MdeModulePkg.dec                              | 4 ++++
>>  MdeModulePkg/Universal/Console/TerminalDxe/TerminalDxe.inf | 1 +
>>  MdeModulePkg/Universal/Console/TerminalDxe/Terminal.c      | 4 ++++
>>  3 files changed, 9 insertions(+)
>>
>> --
>> 2.20.1.windows.1
>>
>>
>>
>> 
>>
>