From: "Gerd Hoffmann" <kraxel@redhat.com>
To: Oliver Steffen <osteffen@redhat.com>
Cc: devel@edk2.groups.io, Anthony Perard <anthony.perard@citrix.com>,
Ard Biesheuvel <ardb+tianocore@kernel.org>,
Jian J Wang <jian.j.wang@intel.com>,
Jiewen Yao <jiewen.yao@intel.com>,
Jordan Justen <jordan.l.justen@intel.com>,
Julien Grall <julien@xen.org>,
Leif Lindholm <quic_llindhol@quicinc.com>,
Liming Gao <gaoliming@byosoft.com.cn>, Ray Ni <ray.ni@intel.com>,
Sami Mujawar <sami.mujawar@arm.com>,
Zhichao Gao <zhichao.gao@intel.com>,
Pawel Polawski <ppolawsk@redhat.com>
Subject: Re: [PATCH 2/2] ArmVirtPkg: allow setting Firmware Version from build command line
Date: Wed, 12 Oct 2022 12:39:30 +0200 [thread overview]
Message-ID: <20221012103930.imhnaniw2ug2fkey@sirius.home.kraxel.org> (raw)
In-Reply-To: <CA+bRGFq3H3keE7yuq814xG9hmRx_iH7MEOPe-eq3Td_wf1vp=w@mail.gmail.com>
On Wed, Oct 12, 2022 at 07:35:23AM +0000, Oliver Steffen wrote:
> Initialize
> gEfiMdeModulePkgTokenSpaceGuid.PcdFirmwareVersionString
> with with the value of the variable "FIRMWARE_VER"
> in all flavors of ArmVirtPkg.
>
> This behavior is already implemented in ArmVirtXen.dsc.
> It allows specifying the firmware version string on the
> build command line with -D FIRMARE_VER=...
I think we need to decide which approach we want support for
setting PcdFirmwareVersionString (and write it down in armvirt/ovmf
readme).
The options we have are:
(1) -D "FIRMARE_VER=${version}" (needs this patch), or
(2) --pcd "PcdFirmwareVersionString=L'${version}\\0'"
Advantage of (1) is that the build command line is a bit simpler.
Disadvantage of (1) is that it overrides PcdFirmwareVersionString
even in case FIRMARE_VER is not set on the command line. Which doesn't
make much of a difference today because the default value defined in
MdeModulePkg is just the empty string. In case we set the default
to something more useful (https://edk2.groups.io/g/devel/message/94985)
overriding it is not so nice though ...
take care,
Gerd
next prev parent reply other threads:[~2022-10-12 10:39 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20221012073504.511854-1-osteffen@redhat.com>
2022-10-12 7:35 ` [PATCH 1/2] OvmfPkg: allow setting Firmware Version from build command line Oliver Steffen
2022-10-12 7:35 ` [PATCH 2/2] ArmVirtPkg: " Oliver Steffen
2022-10-12 10:01 ` Sami Mujawar
2022-10-12 10:39 ` Gerd Hoffmann [this message]
2022-10-12 11:06 ` Sami Mujawar
2022-10-12 11:18 ` Gerd Hoffmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221012103930.imhnaniw2ug2fkey@sirius.home.kraxel.org \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox