From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124])
 by mx.groups.io with SMTP id smtpd.web10.18950.1665573500623751909
 for <devel@edk2.groups.io>;
 Wed, 12 Oct 2022 04:18:21 -0700
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=F8UHLm5U;
 spf=pass (domain: redhat.com, ip: 170.10.133.124, mailfrom: kraxel@redhat.com)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
	s=mimecast20190719; t=1665573499;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=zYdKMCodaecw+0onAw9YJr2PTaMiiHh1KtOyNUg/qbA=;
	b=F8UHLm5UhfPpUnx0jsvHk4Mpu+CCBNbNa60jMD2zAMPSe5nucQ2414+kV0hReLndEHndkk
	5xgkq7KT+h+an11ncvkHDdPd7z6VofIyf7Y91MYhWJgC8ImI685x1kBjw95WA6oPL/pJ/V
	9eJQD9aPqLcNwgEfBhAjNp14Z2XuE+w=
Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com
 [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS
 (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 us-mta-22-MUin1Lt6N921TOREeIYw9g-1; Wed, 12 Oct 2022 07:18:09 -0400
X-MC-Unique: MUin1Lt6N921TOREeIYw9g-1
Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4])
	(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 7CFF5101A56C;
	Wed, 12 Oct 2022 11:18:08 +0000 (UTC)
Received: from sirius.home.kraxel.org (unknown [10.39.195.183])
	by smtp.corp.redhat.com (Postfix) with ESMTPS id C46072083A17;
	Wed, 12 Oct 2022 11:18:06 +0000 (UTC)
Received: by sirius.home.kraxel.org (Postfix, from userid 1000)
	id 7135E18003A8; Wed, 12 Oct 2022 13:18:05 +0200 (CEST)
Date: Wed, 12 Oct 2022 13:18:05 +0200
From: "Gerd Hoffmann" <kraxel@redhat.com>
To: Sami Mujawar <sami.mujawar@arm.com>
Cc: Oliver Steffen <osteffen@redhat.com>, devel@edk2.groups.io,
	Anthony Perard <anthony.perard@citrix.com>,
	Ard Biesheuvel <ardb+tianocore@kernel.org>,
	Jian J Wang <jian.j.wang@intel.com>,
	Jiewen Yao <jiewen.yao@intel.com>,
	Jordan Justen <jordan.l.justen@intel.com>,
	Julien Grall <julien@xen.org>,
	Leif Lindholm <quic_llindhol@quicinc.com>,
	Liming Gao <gaoliming@byosoft.com.cn>, Ray Ni <ray.ni@intel.com>,
	Zhichao Gao <zhichao.gao@intel.com>,
	Pawel Polawski <ppolawsk@redhat.com>, "nd@arm.com" <nd@arm.com>
Subject: Re: [PATCH 2/2] ArmVirtPkg: allow setting Firmware Version from build command line
Message-ID: <20221012111805.iuc6j4lxfzaek3ei@sirius.home.kraxel.org>
References: <20221012073504.511854-1-osteffen@redhat.com>
 <CA+bRGFq3H3keE7yuq814xG9hmRx_iH7MEOPe-eq3Td_wf1vp=w@mail.gmail.com>
 <20221012103930.imhnaniw2ug2fkey@sirius.home.kraxel.org>
 <5eb550a4-a0de-9dac-d013-f55ca15a5a8f@arm.com>
MIME-Version: 1.0
In-Reply-To: <5eb550a4-a0de-9dac-d013-f55ca15a5a8f@arm.com>
X-Scanned-By: MIMEDefang 3.1 on 10.11.54.4
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Type: text/plain; charset=WINDOWS-1252
Content-Disposition: inline
Content-Transfer-Encoding: 8bit

  Hi,

> I think we could do the following in ArmVirtPkg:
> 
> --- a/ArmVirtPkg/ArmVirt.dsc.inc
> +++ b/ArmVirtPkg/ArmVirt.dsc.inc

>  [PcdsFixedAtBuild.common]
> +!ifdef $(FIRMWARE_VER)
> + gEfiMdeModulePkgTokenSpaceGuid.PcdFirmwareVersionString|L"$(FIRMWARE_VER)"
> +!endif

Yes, that idea looks good to me.

take care,
  Gerd