From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mx.groups.io with SMTP id smtpd.web08.20541.1665584199794430971 for ; Wed, 12 Oct 2022 07:16:39 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="body hash did not verify" header.i=@linux.microsoft.com header.s=default header.b=K7qsxbXX; spf=pass (domain: linux.microsoft.com, ip: 13.77.154.182, mailfrom: mikuback@linux.microsoft.com) Received: from localhost.localdomain (unknown [47.201.8.94]) by linux.microsoft.com (Postfix) with ESMTPSA id D240B20F0F67; Wed, 12 Oct 2022 07:16:38 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com D240B20F0F67 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1665584199; bh=kYC0+buhibFkBOlGwP9wZSymOZkFeOjGLxAB0VnzIW4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=K7qsxbXXQyIehauN7/E868R6afyyIDe9zgopn9UygTZfImStyEkfaUDtxp2nu4SZQ 19TKWkQZOceZ8z622lgfGuVDaUx9ZgGt5Kl84MphD/1+Mi7GO/XqsaOlD68XeKNN0r oFtcqeUBRV4E59rt+QdBTDMBQHdO6neRqrgllPpI= From: "Michael Kubacki" To: devel@edk2.groups.io Cc: Sai Chaganty , Nate DeSimone , Heng Luo Subject: [edk2-platforms][PATCH v2 3/3] TigerlakeSiliconPkg: Fix invalid debug macros Date: Wed, 12 Oct 2022 10:16:10 -0400 Message-Id: <20221012141610.668-4-mikuback@linux.microsoft.com> X-Mailer: git-send-email 2.28.0.windows.1 In-Reply-To: <20221012141610.668-1-mikuback@linux.microsoft.com> References: <20221012141610.668-1-mikuback@linux.microsoft.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable From: Michael Kubacki REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3D4095 Updates several debug macros in TigerlakeSiliconPkg to correctly match print specifiers to actual arguments. Cc: Sai Chaganty Cc: Nate DeSimone Cc: Heng Luo Signed-off-by: Michael Kubacki --- Silicon/Intel/TigerlakeSiliconPkg/IpBlock/Gbe/LibraryPrivate/PeiDxeSmmGb= eMdiLib/GbeMdiLib.c | 2 +- Silicon/Intel/TigerlakeSiliconPkg/IpBlock/PcieRp/LibraryPrivate/PciExpre= ssHelpersLibrary/PciExpressHelpersLibrary.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/Silicon/Intel/TigerlakeSiliconPkg/IpBlock/Gbe/LibraryPrivate= /PeiDxeSmmGbeMdiLib/GbeMdiLib.c b/Silicon/Intel/TigerlakeSiliconPkg/IpBlo= ck/Gbe/LibraryPrivate/PeiDxeSmmGbeMdiLib/GbeMdiLib.c index 791747440662..71361a88272f 100644 --- a/Silicon/Intel/TigerlakeSiliconPkg/IpBlock/Gbe/LibraryPrivate/PeiDxe= SmmGbeMdiLib/GbeMdiLib.c +++ b/Silicon/Intel/TigerlakeSiliconPkg/IpBlock/Gbe/LibraryPrivate/PeiDxe= SmmGbeMdiLib/GbeMdiLib.c @@ -323,7 +323,7 @@ GbeMdiGetLanPhyRevision ( Status =3D EFI_DEVICE_ERROR; goto phy_exit; } - DEBUG ((DEBUG_INFO, "GbeMdiGetLanPhyRevision failed to read Revision= . Overriding LANPHYPC\n", Status)); + DEBUG ((DEBUG_INFO, "GbeMdiGetLanPhyRevision failed to read Revision= . Overriding LANPHYPC. Status: %r\n", Status)); // // Taking over LANPHYPC // 1. SW signal override - 1st cycle. diff --git a/Silicon/Intel/TigerlakeSiliconPkg/IpBlock/PcieRp/LibraryPriv= ate/PciExpressHelpersLibrary/PciExpressHelpersLibrary.c b/Silicon/Intel/T= igerlakeSiliconPkg/IpBlock/PcieRp/LibraryPrivate/PciExpressHelpersLibrary= /PciExpressHelpersLibrary.c index 401a9fbe7b8a..0dfe019d70f9 100644 --- a/Silicon/Intel/TigerlakeSiliconPkg/IpBlock/PcieRp/LibraryPrivate/Pci= ExpressHelpersLibrary/PciExpressHelpersLibrary.c +++ b/Silicon/Intel/TigerlakeSiliconPkg/IpBlock/PcieRp/LibraryPrivate/Pci= ExpressHelpersLibrary/PciExpressHelpersLibrary.c @@ -1227,7 +1227,7 @@ RecursiveIoApicCheck ( IoApicPresent =3D FALSE; =20 if (IsIoApicDevice (SbdfToBase (Sbdf))) { - DEBUG ((DEBUG_INFO, "IoApicFound @%x:%x:%x:%x\n", Sbdf.Bus, Sbdf.Dev= , Sbdf.Func)); + DEBUG ((DEBUG_INFO, "IoApicFound @%x:%x:%x:%x\n", Sbdf.Seg, Sbdf.Bus= , Sbdf.Dev, Sbdf.Func)); return TRUE; } if (HasChildBus (Sbdf, &ChildSbdf)) { --=20 2.28.0.windows.1