From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by mx.groups.io with SMTP id smtpd.web09.26973.1665891679867154648 for ; Sat, 15 Oct 2022 20:41:21 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=T5KE9GBs; spf=pass (domain: intel.com, ip: 192.55.52.115, mailfrom: bob.c.feng@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1665891679; x=1697427679; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=mHHpP0GWIXsCXvKHgy/V/6g3fRYGB4sMlv7BBKmx1us=; b=T5KE9GBsHmIkzEaLZw3z1wTa57hHJDecPtmBHbmK2/ISFs1a3Qmblx8x L4wjY93KEJ1c0PjuPXGqsBNmCyyiVvAMI7OJIjVV7eS4yIjFFgZFVpIxu ZBWlqgM2rAaIwO8R+jgCLJnrtn3QC6jNC9FGtDW2Xn5WUgZthFtFbOx4i T81ugQTRpCfykm74N1tLkaKeCrz/PKMNYO3pQ0cnVR6/GX+Ve9EYh2nAt 0bep27abhuMVS4cZMckVUCS1ppSAgi0Lx4Ja7V21jG1uuSeFFhctosyWL wxaSc0Sw2+7OchaxevemlgbA3aIDLswr0hwJ4gvko5BBk0t+LEyjg5vbt g==; X-IronPort-AV: E=McAfee;i="6500,9779,10501"; a="305590161" X-IronPort-AV: E=Sophos;i="5.95,188,1661842800"; d="scan'208";a="305590161" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Oct 2022 20:41:19 -0700 X-IronPort-AV: E=McAfee;i="6500,9779,10501"; a="956979637" X-IronPort-AV: E=Sophos;i="5.95,188,1661842800"; d="scan'208";a="956979637" Received: from bfeng1-mobl.ccr.corp.intel.com ([10.249.169.59]) by fmsmga005-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Oct 2022 20:41:16 -0700 From: "Bob Feng" To: devel@edk2.groups.io Cc: Bob Feng , Liming Gao , Yuwei Chen Subject: [PATCH 1/1] BaseTools/Scripts/PatchCheck.py: Allow tab in Makefile Date: Sun, 16 Oct 2022 11:41:05 +0800 Message-Id: <20221016034105.492-1-bob.c.feng@intel.com> X-Mailer: git-send-email 2.37.0.windows.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The syntax for Makefiles requires that indented lines s tart with a tab, but not a space. This change of PatchCheck.py make the patch for Makefile/GNUmakefile pass the PatchCheck.py. Signed-off-by: Bob Feng Cc: Liming Gao Cc: Yuwei Chen --- BaseTools/Scripts/PatchCheck.py | 3 +++ 1 file changed, 3 insertions(+) diff --git a/BaseTools/Scripts/PatchCheck.py b/BaseTools/Scripts/PatchCheck.py index 63e6223f8ebc..475b3a8c27d9 100755 --- a/BaseTools/Scripts/PatchCheck.py +++ b/BaseTools/Scripts/PatchCheck.py @@ -383,6 +383,9 @@ class GitDiffCheck: # self.force_crlf = False self.force_notabs = False + if os.path.basename(self.filename) == 'GNUmakefile' or \ + os.path.basename(self.filename) == 'Makefile': + self.force_notabs = False elif len(line.rstrip()) != 0: self.format_error("didn't find diff command") self.line_num += 1 -- 2.37.0.windows.1