* [PATCH 1/1] BaseTools/Scripts/PatchCheck.py: Allow tab in Makefile
@ 2022-10-16 3:41 Bob Feng
0 siblings, 0 replies; only message in thread
From: Bob Feng @ 2022-10-16 3:41 UTC (permalink / raw)
To: devel; +Cc: Bob Feng, Liming Gao, Yuwei Chen
The syntax for Makefiles requires that indented lines s
tart with a tab, but not a space.
This change of PatchCheck.py make the patch for Makefile/GNUmakefile
pass the PatchCheck.py.
Signed-off-by: Bob Feng <bob.c.feng@intel.com>
Cc: Liming Gao <gaoliming@byosoft.com.cn>
Cc: Yuwei Chen <yuwei.chen@intel.com>
---
BaseTools/Scripts/PatchCheck.py | 3 +++
1 file changed, 3 insertions(+)
diff --git a/BaseTools/Scripts/PatchCheck.py b/BaseTools/Scripts/PatchCheck.py
index 63e6223f8ebc..475b3a8c27d9 100755
--- a/BaseTools/Scripts/PatchCheck.py
+++ b/BaseTools/Scripts/PatchCheck.py
@@ -383,6 +383,9 @@ class GitDiffCheck:
#
self.force_crlf = False
self.force_notabs = False
+ if os.path.basename(self.filename) == 'GNUmakefile' or \
+ os.path.basename(self.filename) == 'Makefile':
+ self.force_notabs = False
elif len(line.rstrip()) != 0:
self.format_error("didn't find diff command")
self.line_num += 1
--
2.37.0.windows.1
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2022-10-16 3:41 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-10-16 3:41 [PATCH 1/1] BaseTools/Scripts/PatchCheck.py: Allow tab in Makefile Bob Feng
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox