From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by mx.groups.io with SMTP id smtpd.web08.4005.1666075397273709613 for ; Mon, 17 Oct 2022 23:43:17 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=TGlT0poF; spf=pass (domain: intel.com, ip: 192.55.52.115, mailfrom: w.sheng@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1666075397; x=1697611397; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=pJfc5gbe0bJrZIXwrsdyPsSMJsZhzYp+/6tfsiuHRc4=; b=TGlT0poFmMTsDKjUAyWWlDxauruFg1f0rPVBT7JqdTbqa4bWn56ITAdu 4FqpVnpXabJAkp3Z0zYIbTyaUk2SJ2vhyfLXQoAWI1xa1OozmBBfcwC6c oUagAGQ+/tt/D5ebQxrpExDubMeiayRwIOSXpQ2E4Kdirq5ISkcDf0GF/ wIB6z8lLXDgCrEU7zD7UyhOuwCiUs/pqUYc1+G+3vEFNGmYBvU98Mr6MW CpNXHMEEeQkURH1HVvgLq1igA4TmTE3/Rv4Lbw9Qfk+qxXlFkeJGdEVHR a9FK3vhuj0CnfUU4rJMSF+lawQVpPYFltqys/PAI2oBeuH4BPmNcXW35R Q==; X-IronPort-AV: E=McAfee;i="6500,9779,10503"; a="305997946" X-IronPort-AV: E=Sophos;i="5.95,193,1661842800"; d="scan'208";a="305997946" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Oct 2022 23:43:16 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10503"; a="579659375" X-IronPort-AV: E=Sophos;i="5.95,193,1661842800"; d="scan'208";a="579659375" Received: from shwdesssddpdwei.ccr.corp.intel.com ([10.239.157.43]) by orsmga003.jf.intel.com with ESMTP; 17 Oct 2022 23:43:14 -0700 From: "Sheng Wei" To: devel@edk2.groups.io Cc: Ray Ni , Rangasai V Chaganty , Jenny Huang , Robert Kowalewski Subject: [PATCH] IntelSiliconPkg/VTd: Refine VTd core driver Date: Tue, 18 Oct 2022 14:43:11 +0800 Message-Id: <20221018064311.186-1-w.sheng@intel.com> X-Mailer: git-send-email 2.26.2.windows.1 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Refine the DRHD table print message. Remove unused variable. Hsd-es-id: 15012152545 Signed-off-by: Sheng Wei Cc: Ray Ni Cc: Rangasai V Chaganty Cc: Jenny Huang Cc: Robert Kowalewski --- .../Feature/VTd/IntelVTdDmarPei/IntelVTdDmar.c | 3 +-- .../Feature/VTd/IntelVTdDxe/DmarAcpiTable.c | 8 ++++---- .../IntelSiliconPkg/Feature/VTd/IntelVTdDxe/VtdReg.c | 3 +-- 3 files changed, 6 insertions(+), 8 deletions(-) diff --git a/Silicon/Intel/IntelSiliconPkg/Feature/VTd/IntelVTdDmarPei/Inte= lVTdDmar.c b/Silicon/Intel/IntelSiliconPkg/Feature/VTd/IntelVTdDmarPei/Inte= lVTdDmar.c index 24beccd26..af85a3d8e 100644 --- a/Silicon/Intel/IntelSiliconPkg/Feature/VTd/IntelVTdDmarPei/IntelVTdDma= r.c +++ b/Silicon/Intel/IntelSiliconPkg/Feature/VTd/IntelVTdDmarPei/IntelVTdDma= r.c @@ -486,7 +486,6 @@ EnableDmar ( IN UINTN RootEntryTable=0D )=0D {=0D - UINT32 Reg32;=0D UINTN VtdUnitBaseAddress;=0D BOOLEAN TEWasEnabled;=0D =0D @@ -529,7 +528,7 @@ EnableDmar ( //=0D // Init DMAr Fault Event and Data registers=0D //=0D - Reg32 =3D MmioRead32 (VtdUnitBaseAddress + R_FEDATA_REG);=0D + MmioRead32 (VtdUnitBaseAddress + R_FEDATA_REG);=0D =0D //=0D // Write Buffer Flush before invalidation=0D diff --git a/Silicon/Intel/IntelSiliconPkg/Feature/VTd/IntelVTdDxe/DmarAcpi= Table.c b/Silicon/Intel/IntelSiliconPkg/Feature/VTd/IntelVTdDxe/DmarAcpiTab= le.c index 42e1b1449..a485f4d9a 100644 --- a/Silicon/Intel/IntelSiliconPkg/Feature/VTd/IntelVTdDxe/DmarAcpiTable.c +++ b/Silicon/Intel/IntelSiliconPkg/Feature/VTd/IntelVTdDxe/DmarAcpiTable.c @@ -536,14 +536,14 @@ DumpDmarDrhd ( " Flags ................................................ 0x%02x\n",= =0D Drhd->Flags=0D ));=0D - DEBUG ((DEBUG_INFO,=0D - " Size ................................................. 0x%02x\n",= =0D - Drhd->Size=0D - ));=0D DEBUG ((DEBUG_INFO,=0D " INCLUDE_PCI_ALL .................................... 0x%02x\n",= =0D Drhd->Flags & EFI_ACPI_DMAR_DRHD_FLAGS_INCLUDE_PCI_ALL=0D ));=0D + DEBUG ((DEBUG_INFO,=0D + " Size ................................................. 0x%02x\n",= =0D + Drhd->Size=0D + ));=0D DEBUG ((DEBUG_INFO,=0D " Segment Number ....................................... 0x%04x\n",= =0D Drhd->SegmentNumber=0D diff --git a/Silicon/Intel/IntelSiliconPkg/Feature/VTd/IntelVTdDxe/VtdReg.c= b/Silicon/Intel/IntelSiliconPkg/Feature/VTd/IntelVTdDxe/VtdReg.c index 1b354e850..8e834f4c4 100644 --- a/Silicon/Intel/IntelSiliconPkg/Feature/VTd/IntelVTdDxe/VtdReg.c +++ b/Silicon/Intel/IntelSiliconPkg/Feature/VTd/IntelVTdDxe/VtdReg.c @@ -573,7 +573,6 @@ EnableDmar ( )=0D {=0D UINTN Index;=0D - UINT32 Reg32;=0D UINTN VtdUnitBaseAddress;=0D BOOLEAN TEWasEnabled;=0D =0D @@ -615,7 +614,7 @@ EnableDmar ( //=0D // Init DMAr Fault Event and Data registers=0D //=0D - Reg32 =3D MmioRead32 (mVtdUnitInformation[Index].VtdUnitBaseAddress + = R_FEDATA_REG);=0D + MmioRead32 (mVtdUnitInformation[Index].VtdUnitBaseAddress + R_FEDATA_R= EG);=0D =0D //=0D // Write Buffer Flush before invalidation=0D --=20 2.26.2.windows.1