From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by mx.groups.io with SMTP id smtpd.web09.8932.1666108486572317732 for ; Tue, 18 Oct 2022 08:54:47 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=DgEISXSI; spf=pass (domain: intel.com, ip: 192.55.52.43, mailfrom: mateusz.albecki@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1666108486; x=1697644486; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=zWEVBQQOHtveq/OVosFspTD9wZUhzaBlJEzb7xLtI1s=; b=DgEISXSISYf/Ru0DYPyNNL9U0YrAFN/8WFel714+gpndFkxzX9QH+lUN 0jOwu4x1JTnj6PXDVQ3VriKfjU52fYq8nZTNd9espDnwiz6E4Bgk6CWWI ZKKWkbxFYm/D4b6MIEPvdkIGQTJxqDnger55OJJMRJIW/Z9i15sdGHR/H be2QuI081bBMQmJnuys5RDAi2W+HwsqnKIByYPqO1FkANqdGtyK8qx+qB /W3yRvuCZBA2LCAZJRFu147fbNmd5VAlbHK0ZkQD2S33fj9o2P3imiqOc 9qiI2LOFIdb2ftNR35sUNkc61jl7g8YxJYWqTI/Sb5vCSn5tOD9pUw53s g==; X-IronPort-AV: E=McAfee;i="6500,9779,10504"; a="392454006" X-IronPort-AV: E=Sophos;i="5.95,193,1661842800"; d="scan'208";a="392454006" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Oct 2022 08:54:45 -0700 X-IronPort-AV: E=McAfee;i="6500,9779,10504"; a="606607004" X-IronPort-AV: E=Sophos;i="5.95,193,1661842800"; d="scan'208";a="606607004" Received: from malbecki-mobl.ger.corp.intel.com ([10.252.43.77]) by orsmga006-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Oct 2022 08:54:44 -0700 From: "Albecki, Mateusz" To: devel@edk2.groups.io Cc: Mateusz Albecki , Hao A Wu , Ray Ni Subject: [PATCH 0/1] MdeModulePkg/Ata: Fix command status reporting Date: Tue, 18 Oct 2022 17:54:18 +0200 Message-Id: <20221018155419.2808-1-mateusz.albecki@intel.com> X-Mailer: git-send-email 2.28.0.windows.1 MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Fix for a bug introduced during SATA recovery implementation Failing SCT: https://bugzilla.tianocore.org/show_bug.cgi?id=3D4016 Failing password input: https://bugzilla.tianocore.org/show_bug.cgi?id=3D40= 11 The bug was due to recovery status aliasing with command status. This patch= should resolve both issues and should remove the need for reconfigurable retries. I have only t= ested SCT test case though. Github pull: https://github.com/tianocore/edk2/pull/3495 Tests: - tested on qemu with ovmf - SCT test now passes (custom qemu needed from: = https://github.com/matalbec/qemu/tree/sata_abort_completion) - it should be noted that qemu doesn't really support trust protocol on SAT= A drive but for the purposes of the test it should be enough. Cc: Hao A Wu Cc: Ray Ni Signed-off-by: Mateusz Albecki Mateusz Albecki (1): MdeModulePkg/Ata: Fix command status reporting .../Bus/Ata/AtaAtapiPassThru/AhciMode.c | 19 +++++++++++-------- 1 file changed, 11 insertions(+), 8 deletions(-) -- = 2.28.0.windows.1 --------------------------------------------------------------------- Intel Technology Poland sp. z o.o. ul. Slowackiego 173 | 80-298 Gdansk | Sad Rejonowy Gdansk Polnoc | VII Wydz= ial Gospodarczy Krajowego Rejestru Sadowego - KRS 101882 | NIP 957-07-52-31= 6 | Kapital zakladowy 200.000 PLN. Spolka oswiadcza, ze posiada status duzego przedsiebiorcy w rozumieniu usta= wy z dnia 8 marca 2013 r. o przeciwdzialaniu nadmiernym opoznieniom w trans= akcjach handlowych. Ta wiadomosc wraz z zalacznikami jest przeznaczona dla okreslonego adresata= i moze zawierac informacje poufne. W razie przypadkowego otrzymania tej wi= adomosci, prosimy o powiadomienie nadawcy oraz trwale jej usuniecie; jakiek= olwiek przegladanie lub rozpowszechnianie jest zabronione. This e-mail and any attachments may contain confidential material for the s= ole use of the intended recipient(s). If you are not the intended recipient= , please contact the sender and delete all copies; any review or distributi= on by others is strictly prohibited.