From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by mx.groups.io with SMTP id smtpd.web09.5842.1666171348009091003 for ; Wed, 19 Oct 2022 02:22:28 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=d24dqDuZ; spf=pass (domain: kernel.org, ip: 139.178.84.217, mailfrom: ardb@kernel.org) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 5F8F4617B0; Wed, 19 Oct 2022 09:22:27 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 72BDDC43470; Wed, 19 Oct 2022 09:22:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1666171346; bh=62Et7gfQo0zn0JrK1sQEUAc7J1xFF/XEmVHdfRDyVvM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=d24dqDuZGyOoeecOspQHodiQHqbzpFH9Hi99MLtlySPY1zRaYnVNUndGpnaN2yl4H K5jSWXkWbSWpZYJA6BepTBfeXQW8KfpmApUQNRXZuKgyWCmVqbBrvKcZHh2rz2r0LU FpQDWW2cZ5arHsLslNsm+6NuM0FBPX5wmB8sfbbRtdP+WjpMtcKjTip5aVXbAdDmca dMJ0JsnTakXS15AflOegOh26Skvb46apEhNVR95+6lAhmWtGLqzE4MXPS2/NFRuVDf EU5r6G76wJKE83zW18j7+hLsFaP0unKRlEgz+AtLGrfOonRXUCtPFPTGycaWvMqUHj b/ExAuNbbi70A== From: "Ard Biesheuvel" To: devel@edk2.groups.io Cc: Ard Biesheuvel , Leif Lindholm , Alexander Graf , Gerd Hoffmann , Sami Mujawar Subject: [PATCH v3 resend 02/11] ArmVirtPkg: do not enable iSCSI driver by default Date: Wed, 19 Oct 2022 11:22:02 +0200 Message-Id: <20221019092211.465699-3-ardb@kernel.org> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20221019092211.465699-1-ardb@kernel.org> References: <20221019092211.465699-1-ardb@kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable The iSCSI driver slows down the boot on a pristine variable store flash image, as it creates a couple of large EFI non-volatile variables to preserve state between boots. Since iSCSI boot for VMs is kind of niche anyway, let's default to disabled. If someone needs it in their build, they can use the -D build command option to re-enable it on the fly. Signed-off-by: Ard Biesheuvel --- ArmVirtPkg/ArmVirtQemu.dsc | 1 - ArmVirtPkg/ArmVirtQemuKernel.dsc | 1 - 2 files changed, 2 deletions(-) diff --git a/ArmVirtPkg/ArmVirtQemu.dsc b/ArmVirtPkg/ArmVirtQemu.dsc index 9369a88858fd..45c4a8fc84e0 100644 --- a/ArmVirtPkg/ArmVirtQemu.dsc +++ b/ArmVirtPkg/ArmVirtQemu.dsc @@ -40,7 +40,6 @@ [Defines] DEFINE NETWORK_SNP_ENABLE =3D FALSE=0D DEFINE NETWORK_TLS_ENABLE =3D FALSE=0D DEFINE NETWORK_ALLOW_HTTP_CONNECTIONS =3D TRUE=0D - DEFINE NETWORK_ISCSI_ENABLE =3D TRUE=0D =0D !if $(NETWORK_SNP_ENABLE) =3D=3D TRUE=0D !error "NETWORK_SNP_ENABLE is IA32/X64/EBC only"=0D diff --git a/ArmVirtPkg/ArmVirtQemuKernel.dsc b/ArmVirtPkg/ArmVirtQemuKerne= l.dsc index 7f7d15d6eee3..66039f07f41b 100644 --- a/ArmVirtPkg/ArmVirtQemuKernel.dsc +++ b/ArmVirtPkg/ArmVirtQemuKernel.dsc @@ -38,7 +38,6 @@ [Defines] DEFINE NETWORK_SNP_ENABLE =3D FALSE=0D DEFINE NETWORK_TLS_ENABLE =3D FALSE=0D DEFINE NETWORK_ALLOW_HTTP_CONNECTIONS =3D TRUE=0D - DEFINE NETWORK_ISCSI_ENABLE =3D TRUE=0D =0D !if $(NETWORK_SNP_ENABLE) =3D=3D TRUE=0D !error "NETWORK_SNP_ENABLE is IA32/X64/EBC only"=0D --=20 2.35.1