From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by mx.groups.io with SMTP id smtpd.web12.1058.1666290930610733653 for ; Thu, 20 Oct 2022 11:35:31 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=oC/Rcq/8; spf=pass (domain: intel.com, ip: 192.55.52.136, mailfrom: michael.d.kinney@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1666290931; x=1697826931; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=Ndyg7RqNop87MgaBZFBMrVkwbALDgVwmEmuPhqhWviU=; b=oC/Rcq/8RTnJMKxff6wU3wiWuMMoMBgDIqyrzcq1IUQviM5c70BLpA2m yLV8a+KMQROe2cxtOhaj+NxMD1uwXEjIarpFeBJO5W/T0Vq7X1tiZUuLs 6I7k8U9MsWLyYkd1XesI7x2jRZ4NVXlVuqxXmZsOjt2n4rdbeCzMtYi2Q N/tXoXNHsWKagkBmk72Ky9XWeWVRvEblwE41HqaWD3YwJlIBp9f1X6FDb 0LNge2vfD+iVlYXCJXi94c/bHVg6ySgj6eHnxzWpFd4BV0tN/wGinYRK7 RFs+UOjoEKc+9V7Cn23cYEnwxiqsDXzTkTyDmEjpABzbbxmsrMQleI0DC Q==; X-IronPort-AV: E=McAfee;i="6500,9779,10506"; a="286523527" X-IronPort-AV: E=Sophos;i="5.95,199,1661842800"; d="scan'208";a="286523527" Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Oct 2022 11:35:31 -0700 X-IronPort-AV: E=McAfee;i="6500,9779,10506"; a="632427758" X-IronPort-AV: E=Sophos;i="5.95,199,1661842800"; d="scan'208";a="632427758" Received: from mdkinney-mobl2.amr.corp.intel.com ([10.212.188.143]) by fmsmga007-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Oct 2022 11:35:30 -0700 From: "Michael D Kinney" To: devel@edk2.groups.io Cc: Jiewen Yao , Jian J Wang , Xiaoyu Lu , Guomin Jiang , Christopher Zurcher Subject: [Patch v2 02/16] CryptoPkg/Library/BaseCryptLib: Add missing UNI file and fix format Date: Thu, 20 Oct 2022 11:34:56 -0700 Message-Id: <20221020183510.1799-3-michael.d.kinney@intel.com> X-Mailer: git-send-email 2.37.1.windows.1 In-Reply-To: <20221020183510.1799-1-michael.d.kinney@intel.com> References: <20221020183510.1799-1-michael.d.kinney@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Cc: Jiewen Yao Cc: Jian J Wang Cc: Xiaoyu Lu Cc: Guomin Jiang Cc: Christopher Zurcher Signed-off-by: Michael D Kinney --- CryptoPkg/Library/BaseCryptLib/BaseCryptLib.uni | 2 -- CryptoPkg/Library/BaseCryptLib/PeiCryptLib.uni | 2 -- CryptoPkg/Library/BaseCryptLib/RuntimeCryptLib.uni | 2 -- CryptoPkg/Library/BaseCryptLib/SecCryptLib.inf | 1 + .../BaseCryptLib/{SmmCryptLib.uni => SecCryptLib.uni} | 11 ++--------- CryptoPkg/Library/BaseCryptLib/SmmCryptLib.uni | 2 -- 6 files changed, 3 insertions(+), 17 deletions(-) copy CryptoPkg/Library/BaseCryptLib/{SmmCryptLib.uni => SecCryptLib.uni} (74%) diff --git a/CryptoPkg/Library/BaseCryptLib/BaseCryptLib.uni b/CryptoPkg/Library/BaseCryptLib/BaseCryptLib.uni index ed1852efbe04..d9d53d099c4e 100644 --- a/CryptoPkg/Library/BaseCryptLib/BaseCryptLib.uni +++ b/CryptoPkg/Library/BaseCryptLib/BaseCryptLib.uni @@ -12,8 +12,6 @@ // // **/ - #string STR_MODULE_ABSTRACT #language en-US "Cryptographic Library Instance for DXE_DRIVER" #string STR_MODULE_DESCRIPTION #language en-US "Caution: This module requires additional review when modified. This library will have external input - signature. This external input must be validated carefully to avoid security issues such as buffer overflow or integer overflow." - diff --git a/CryptoPkg/Library/BaseCryptLib/PeiCryptLib.uni b/CryptoPkg/Library/BaseCryptLib/PeiCryptLib.uni index 20ae64e8bf1a..8cffc00daf5d 100644 --- a/CryptoPkg/Library/BaseCryptLib/PeiCryptLib.uni +++ b/CryptoPkg/Library/BaseCryptLib/PeiCryptLib.uni @@ -18,8 +18,6 @@ // // **/ - #string STR_MODULE_ABSTRACT #language en-US "Cryptographic Library Instance for PEIM" #string STR_MODULE_DESCRIPTION #language en-US "Caution: This module requires additional review when modified. This library will have external input - signature. This external input must be validated carefully to avoid security issues such as buffer overflow or integer overflow. Note: AES functions, RSA external functions, PKCS#7 SignedData sign functions, Diffie-Hellman functions, X.509 certificate handler functions, authenticode signature verification functions, PEM handler functions, and pseudorandom number generator functions are not supported in this instance." - diff --git a/CryptoPkg/Library/BaseCryptLib/RuntimeCryptLib.uni b/CryptoPkg/Library/BaseCryptLib/RuntimeCryptLib.uni index 0cf378c5ab84..786738a99d73 100644 --- a/CryptoPkg/Library/BaseCryptLib/RuntimeCryptLib.uni +++ b/CryptoPkg/Library/BaseCryptLib/RuntimeCryptLib.uni @@ -17,8 +17,6 @@ // // **/ - #string STR_MODULE_ABSTRACT #language en-US "Cryptographic Library Instance for DXE_RUNTIME_DRIVER" #string STR_MODULE_DESCRIPTION #language en-US "Caution: This module requires additional review when modified. This library will have external input - signature. This external input must be validated carefully to avoid security issues such as buffer overflow or integer overflow. Note: AES functions, RSA external functions, PKCS#7 SignedData sign functions, Diffie-Hellman functions, and authenticode signature verification functions are not supported in this instance." - diff --git a/CryptoPkg/Library/BaseCryptLib/SecCryptLib.inf b/CryptoPkg/Library/BaseCryptLib/SecCryptLib.inf index 0b1dd31c411c..4f652be46a82 100644 --- a/CryptoPkg/Library/BaseCryptLib/SecCryptLib.inf +++ b/CryptoPkg/Library/BaseCryptLib/SecCryptLib.inf @@ -14,6 +14,7 @@ [Defines] INF_VERSION = 0x00010005 BASE_NAME = SecCryptLib + MODULE_UNI_FILE = SecCryptLib.uni FILE_GUID = 3689D343-0D32-4284-8053-BF10537990E8 MODULE_TYPE = BASE VERSION_STRING = 1.0 diff --git a/CryptoPkg/Library/BaseCryptLib/SmmCryptLib.uni b/CryptoPkg/Library/BaseCryptLib/SecCryptLib.uni similarity index 74% copy from CryptoPkg/Library/BaseCryptLib/SmmCryptLib.uni copy to CryptoPkg/Library/BaseCryptLib/SecCryptLib.uni index f0c33abbcf22..c0dd1eb0f351 100644 --- a/CryptoPkg/Library/BaseCryptLib/SmmCryptLib.uni +++ b/CryptoPkg/Library/BaseCryptLib/SecCryptLib.uni @@ -1,24 +1,17 @@ // /** @file -// Cryptographic Library Instance for SMM driver. +// Cryptographic Library Instance for SEC driver. // // Caution: This module requires additional review when modified. // This library will have external input - signature. // This external input must be validated carefully to avoid security issues such as // buffer overflow or integer overflow. // -// Note: AES -// functions, RSA external functions, PKCS#7 SignedData sign functions, -// Diffie-Hellman functions, and authenticode signature verification functions are -// not supported in this instance. -// // Copyright (c) 2010 - 2020, Intel Corporation. All rights reserved.
// // SPDX-License-Identifier: BSD-2-Clause-Patent // // **/ - -#string STR_MODULE_ABSTRACT #language en-US "Cryptographic Library Instance for SMM driver" +#string STR_MODULE_ABSTRACT #language en-US "Cryptographic Library Instance for SEC driver" #string STR_MODULE_DESCRIPTION #language en-US "Caution: This module requires additional review when modified. This library will have external input - signature. This external input must be validated carefully to avoid security issues such as buffer overflow or integer overflow. Note: AES functions, RSA external functions, PKCS#7 SignedData sign functions, Diffie-Hellman functions, and authenticode signature verification functions are not supported in this instance." - diff --git a/CryptoPkg/Library/BaseCryptLib/SmmCryptLib.uni b/CryptoPkg/Library/BaseCryptLib/SmmCryptLib.uni index f0c33abbcf22..7e0f55f792e1 100644 --- a/CryptoPkg/Library/BaseCryptLib/SmmCryptLib.uni +++ b/CryptoPkg/Library/BaseCryptLib/SmmCryptLib.uni @@ -17,8 +17,6 @@ // // **/ - #string STR_MODULE_ABSTRACT #language en-US "Cryptographic Library Instance for SMM driver" #string STR_MODULE_DESCRIPTION #language en-US "Caution: This module requires additional review when modified. This library will have external input - signature. This external input must be validated carefully to avoid security issues such as buffer overflow or integer overflow. Note: AES functions, RSA external functions, PKCS#7 SignedData sign functions, Diffie-Hellman functions, and authenticode signature verification functions are not supported in this instance." - -- 2.37.1.windows.1