From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (NAM10-BN7-obe.outbound.protection.outlook.com [40.107.92.48]) by mx.groups.io with SMTP id smtpd.web09.174.1666456509394955788 for ; Sat, 22 Oct 2022 09:35:09 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="body hash did not verify" header.i=@amd.com header.s=selector1 header.b=vKazJ0uQ; spf=permerror, err=parse error for token &{10 18 %{i}._ip.%{h}._ehlo.%{d}._spf.vali.email}: invalid domain name (domain: amd.com, ip: 40.107.92.48, mailfrom: paul.grimes@amd.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=UvNqQ54o5nez82kVro2scCn5VWHdXHKSEJPbG1Hj07YSRop/S95C++bXagfigVftIrIEG/ntPwxkkzKwZYriN0QXFMGAXuYrPbPXw9aU+QG5ngUtBOicquVN1ZiBhkQ2SSv5bZVjV0r5xwKntai2fTH3TXcpzBq0BZH8fpMgQ79e+HRkc4Tb/qiTlC/4r88zDSgcOVCBLlxAa5Qjue6/2YOj1rTrrshh/SMKckplCE+7oTsZaAXVB3fljkjCJjXMxYpbsU75FEczAjGx5xXnA/Ke8cEfyV5EvG1O0azfrIeU6MDXregnK/+mrP3R865FMoO/+mKOW/EsEfok7Opx9g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=7uuJF6OcJVX9jsB9VkHgUB//IxFzlmKbZEJv5rRzj14=; b=R97UvI9txkyCy6FoLeHuKRYGHhq0NePCiabzHhftL9VsjTaz5NvFbUFzVOhOuUoTXeKdSjBIN0iyRZ2jNtDB31hf2lcMWlsDF5+bRgvTg+jPmc7SX8++ZtxUXBKA+cA1+bjtpN1OQw96ARPpKWqlL/IDYGd0sBY4FzY6FR4IYFzetS6H5u/l67+RfqOF2Htamxay60fgGj+qshArw0okliwOmHD2kVYvOfK9bF2hQrH8YJVKSW6N/Giuzsgpw7p1fcQYwKIkJpVfVl5wSC1gju35l9/R1fmxw5GyFWuEM0UDXrqM5BFCELxLyxfhAYZbcjm0edpLYbpfAAgjoQ/DvA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=edk2.groups.io smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=7uuJF6OcJVX9jsB9VkHgUB//IxFzlmKbZEJv5rRzj14=; b=vKazJ0uQKBNfDLHFumauGw8zNbbdsVs+g9RilsZxYleRRNLw1E70hlR7lAv5jBZpAS37O1GxefgIMftuVDDiGTqB4WOnXZx/Y/T/Lbk/PV1E+Dv6wEALr6NsqVZAj0Ti9ptf7dm6o/7FMgvuf+GMyxKQbDlVR+0fGTVXNQBjCL4= Received: from BN9PR03CA0768.namprd03.prod.outlook.com (2603:10b6:408:13a::23) by CH0PR12MB5313.namprd12.prod.outlook.com (2603:10b6:610:d4::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.35; Sat, 22 Oct 2022 16:00:50 +0000 Received: from BN8NAM11FT066.eop-nam11.prod.protection.outlook.com (2603:10b6:408:13a:cafe::4) by BN9PR03CA0768.outlook.office365.com (2603:10b6:408:13a::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5746.23 via Frontend Transport; Sat, 22 Oct 2022 16:00:49 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by BN8NAM11FT066.mail.protection.outlook.com (10.13.177.138) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5746.16 via Frontend Transport; Sat, 22 Oct 2022 16:00:49 +0000 Received: from AUS-LX-PAGRIMES.amd.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Sat, 22 Oct 2022 11:00:46 -0500 From: "Paul" To: CC: Zhiguang Liu , Ray Ni , Gua Guo Subject: [PATCH v1 1/2] MdeModulePkg: BdsDxe: Uninitialized local variable. Date: Sat, 22 Oct 2022 09:00:09 -0700 Message-ID: <20221022160010.632-2-paul.grimes@amd.com> X-Mailer: git-send-email 2.24.0.windows.2 In-Reply-To: <20221022160010.632-1-paul.grimes@amd.com> References: <20221022160010.632-1-paul.grimes@amd.com> MIME-Version: 1.0 Return-Path: Paul.Grimes@amd.com X-Originating-IP: [10.180.168.240] X-ClientProxiedBy: SATLEXMB04.amd.com (10.181.40.145) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN8NAM11FT066:EE_|CH0PR12MB5313:EE_ X-MS-Office365-Filtering-Correlation-Id: ce18a3e3-cc8a-40a8-cd96-08dab44696e2 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: zFksw3WTFQl5JxuaTT55fQt2xty5GPYzOpObN6OGw6+ajvNYSxsSVAgULDQredOrJDfMXMHyaLYfXtJkMKArLAsbADNRtZgW8dxJeT9hpQlZ9U2/EuZ9OMmNY9PRE9BzKekgtWM5VjrJCb7AlaMoTorXWn84dF6YrmZ1ZN1b7tDz5y2rF6oiaTiFtP04aph2Cm9BSZE46ZPZIExBMGLsnJVDRNeuEiHiMHhkuatpGX1Yk7tlzx8GSS9AeUgC2+Tcle/XOYvVABVlpMvtRY2SEWKtOApOLXjZxnbLVaPo47LYH6Kis6R3PIOH33sxygoWHj45F7N1+jjkgCaiL+Y+R/Jb1So9YLaP3ETPE+i6xffy3MPnfYhE6bTovzE9w0pkf6McJmzsCnB6rL2xll1jcHG7pfSYd8DEtryem8h87KOCPM5VEyFv4phHRwfMacElo+zGpYJikv+KwtUAU/jXD01BIDuU6marhtybyKIYmqJZcZ0ey9qTMhytex0qovslbm0HCqW9A7GPZhyvCHp1grNXIm5Ax8KbS+IgVoOwH1Fd6Tfjp3nIydvbGKNObHDFbSMuKp3xIWSMrtYQLzD3+0sVeNeoFQTH/F1n1LgPBxz+IIVCXVnNtrLXXeCg89vUhrIJrF1IhkP+pZ2qMUo4huGoaNfpnrDhLvCl+nMpXUFa1X7MeVcyhJPshQl5vUuVBMu6AuOLkPe/UojYI+Wn62H0QzXDBT0dCK0RVr4jYm54HZ+TEmrcKqNaPhWUi5jt9wK2L5Wi23SyU1o+CA9UFhPhj4Kfo08RkWMBeWFijAde//zMVm2DgPV01a3rMBBB X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230022)(4636009)(346002)(376002)(136003)(396003)(39860400002)(451199015)(46966006)(36840700001)(40470700004)(336012)(70586007)(70206006)(8676002)(4326008)(186003)(16526019)(316002)(19627235002)(41300700001)(2616005)(2906002)(40460700003)(82740400003)(4744005)(8936002)(5660300002)(36756003)(6916009)(1076003)(86362001)(47076005)(478600001)(54906003)(426003)(40480700001)(26005)(6666004)(356005)(2876002)(36860700001)(7696005)(81166007)(82310400005)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Oct 2022 16:00:49.8034 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: ce18a3e3-cc8a-40a8-cd96-08dab44696e2 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT066.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR12MB5313 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain From: Paul Grimes In function BdsFormalizeConsoleVariable(), VariableSize is used prior to being initialized. This change initializes the variable. Cc: Zhiguang Liu Cc: Ray Ni Cc: Gua Guo Signed-off-by: Paul Grimes --- MdeModulePkg/Universal/BdsDxe/BdsEntry.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/MdeModulePkg/Universal/BdsDxe/BdsEntry.c b/MdeModulePkg/Univer= sal/BdsDxe/BdsEntry.c index 766dde3aaeeb..455fc344f0be 100644 --- a/MdeModulePkg/Universal/BdsDxe/BdsEntry.c +++ b/MdeModulePkg/Universal/BdsDxe/BdsEntry.c @@ -518,6 +518,8 @@ BdsFormalizeConsoleVariable ( UINTN VariableSize; EFI_STATUS Status; =20 + VariableSize =3D 0; + GetEfiGlobalVariable2 (VariableName, (VOID **)&DevicePath, &VariableSize= ); if ((DevicePath !=3D NULL) && !IsDevicePathValid (DevicePath, VariableSi= ze)) { Status =3D gRT->SetVariable ( --=20 2.24.0.windows.2