From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f201.google.com (mail-pg1-f201.google.com [209.85.215.201]) by mx.groups.io with SMTP id smtpd.web09.1378.1666644086662848872 for ; Mon, 24 Oct 2022 13:41:26 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@google.com header.s=20210112 header.b=L7wCDE4d; spf=pass (domain: flex--dionnaglaze.bounces.google.com, ip: 209.85.215.201, mailfrom: 3dfhwywskbeihmsrrekpediksskpi.gsqhizipihog.kvsytw.ms@flex--dionnaglaze.bounces.google.com) Received: by mail-pg1-f201.google.com with SMTP id h186-20020a636cc3000000b0045a1966a975so5108264pgc.5 for ; Mon, 24 Oct 2022 13:41:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=cc:to:from:subject:message-id:mime-version:date:from:to:cc:subject :date:message-id:reply-to; bh=qusGbHhZXX/HKRC9uUZBNa8PGTq+Ij9fL0LcR2osQEk=; b=L7wCDE4dwnx0x3qSYtRhdllZsMKN+haqtRIthnx59CvOrF+cl3NDWlVV2GxiqLkZaj 63I6a7TaNVcs7RyzkJ9fM8z52SDlVxf83QlB+Bg8thzTMYjMUzc+H9nyskXRiuAkfxI9 qwadCoHPAS9Y09bkhyDwSKYxiKaFuI/eZxnXUXqqxfLIl5JZar8p9siEtCn8YAtG6tQ2 L7XEZLIO6YDyzLOf8ZWfVxa9goq3wl5GF+HEcpIbTxD1AxKhwn+uVr3p/c6mO+EQ5qaK mZRmpZyCgvPWU6v08ueSOyOPBbzcPV+9Z3Y+MkYAm/kEW04AQNYov0yYlek3WspZCFAv czOQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:from:subject:message-id:mime-version:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=qusGbHhZXX/HKRC9uUZBNa8PGTq+Ij9fL0LcR2osQEk=; b=jnNEnnYJkA3h09GofSDJRJa2Yc16xMK5zNibztPMjxl3OE8WsriZX2/FAhLIZAO3MY /FGKH6MQyx07w3QUJaSikancomGdSIKdX2VRdOgKAi0KxSsArPNPVKn+SW39xoRUQHX+ SZLMUlxJtsG2tMniZUOLYygvscviMMU2YfbBLx6sOv/iLChMnGlk4FSVg8mUkZbtMcGk uffPqKHpDW6AWgXt9RGmE9fwcjLz6KnDYKcUt54ZV9/BlUuwL+xPep0/Ij16oYX7kZjM rjt5x2YZYJ/j5wiNfXx/X8HrVcisXyggonmPCr1f86t6ef41g6JbTVHsorNOTU9HMI7l TYWg== X-Gm-Message-State: ACrzQf0EjVdcJ8PlhVtuo7KA2jk/DIl5UXyh3IVgoqoAAUAqS4ZW8taf /TYQqL7iumeGK5WYxyTnETEo6W9VHdbmLyJgMsvcHydfd+eb8bY6lUGe5yhPIeGaZZr+YjqlzPW 6B+VIWz6ZFdSf6c5kEc85OyQIpKzpJP+I+0rvN14Jl6bQl67lUNG0qCrD4zw0f3rdbl/vrGf9 X-Google-Smtp-Source: AMsMyM4l9hWsoNQwTikVXXTBATIPw4IUboZ+5AyUyipSfQZWRw4mCK4UIsREgibyrar4OYR5RfdlJgIsNwYMZcPiKQ== X-Received: from dionnaglaze.c.googlers.com ([fda3:e722:ac3:cc00:7f:e700:c0a8:2ee6]) (user=dionnaglaze job=sendgmr) by 2002:a05:6a00:1a0d:b0:56b:9be2:4fae with SMTP id g13-20020a056a001a0d00b0056b9be24faemr11623191pfv.35.1666644085788; Mon, 24 Oct 2022 13:41:25 -0700 (PDT) Date: Mon, 24 Oct 2022 20:41:07 +0000 Mime-Version: 1.0 X-Mailer: git-send-email 2.38.0.135.g90850a2211-goog Message-ID: <20221024204114.2772064-1-dionnaglaze@google.com> Subject: [PATCH v8 0/7] Add safe unaccepted memory behavior From: "Dionna Glaze" To: devel@edk2.groups.io Cc: Dionna Glaze , Ard Biescheuvel , "Min M. Xu" , Gerd Hoffmann , James Bottomley , Tom Lendacky , Jiewen Yao , Erdem Aktas , Andrew Fish , "Michael D. Kinney" Content-Type: text/plain; charset="UTF-8" These seven patches build on the lazy-accept patch series "Introduce Lazy-accept for Tdx guest" by adding SEV-SNP support for the MemoryAccept protocol, and importantly making eager memory acceptance the default behavior. We implement a standardized event group from UEFI v2.9, EFI_EVENT_GROUP_BEFORE_EXIT_BOOT_SERVICES, since it provides exactly the right invocation point for eagerly accepting memory if eager acceptance has not been disabled. To make use of this event group, we add a new driver that is meant to carry behavior that is needed for all confidential compute technologies, not just specific platforms, CocoDxe. In CocoDxe we implement the default safe behavior to accept all unaccepted memory and invalidate the MemoryMap on ExitBootServices. To allow the OS loader to prevent the eager acceptance, we add a new protocol, up for standardization, AcceptAllUnacceptedMemoryProtocol. This protocol has one interface, Disable(). The OS loader can inform the UEFI that it supports the unaccepted memory type and accepts the responsibility to accept it. All images that support unaccepted memory must now locate and call this new BZ3987_ACCEPT_ALL_UNACCEPTED_MEMORY_PROTOCOL and call the Disable function. Changes since v7: - Rebased onto lazy accept v4 patch series, so memory accept protocol has the EDKII prefix, and the unaccepted memory type has the BZ3937 prefix. - Removed a bad #include to a header removed in v7. - Renamed the protocol to BZ3987_MEMORY_ACCEPTANCE_PROTOCOL as per the discussion on the buganizer issue. - Uncrustify formatting Changes since v6: - Added implementation of EFI_EVENT_GROUP_BEFORE_EXIT_BOOT_SERVICES. - Changed callback protocol of v5 to instead use the standardized event group for before_exit_boot_services. Changes since v5: - Generic callback protocol moved to MdeModulePkg - Removed use of EFI_WARN_STALE_DATA and added comment that the callback should only return EFI_SUCCESS or EFI_INVALID_PARAMETER. - Removed errant log statement and fixed formatting. Changes since v4: - Commit message wording - Replaced direct change to DxeMain with a more generic callback protocol. - Implemented the direct change as an instance of the callback protocol from a new CocoDxe driver. - Replaced "enable" protocol with a "disable" protocol, since the name was confusing. The AcceptAllUnacceptedMemory protocol directly names the behavior that is disabling. Changes since v3: - "DxeMain accepts all memory" patch split into 3 to make each patch affect only one package at a time. Changes since v2: - Removed the redundant memory accept interface and added the accept behavior to the DXE implementation of MemEncryptSevSnpPreValidateSystemRam. - Fixed missing #include in >=4GB patch. Changes since v1: - Added a patch to classify SEV-SNP memory above 4GB unaccepted. - Fixed style problems in EfiMemoryAcceptProtocol implementation. Cc: Ard Biescheuvel Cc: "Min M. Xu" Cc: Gerd Hoffmann Cc: James Bottomley Cc: Tom Lendacky Cc: Jiewen Yao Cc: Erdem Aktas Cc: Andrew Fish Cc: "Michael D. Kinney" Signed-off-by: Dionna Glaze Dionna Glaze (7): OvmfPkg: Realize EfiMemoryAcceptProtocol in AmdSevDxe MdePkg: Add EFI_EVENT_BEFORE_EXIT_BOOT_SERVICES_GUID MdeModulePkg: Notify BeforeExitBootServices in CoreExitBootServices OvmfPkg: Introduce CocoDxe driver MdePkg: Introduce the MemoryAcceptance protocol OvmfPkg: Implement AcceptAllUnacceptedMemory in CocoDxe OvmfPkg/PlatformPei: SEV-SNP make >=4GB unaccepted MdeModulePkg/Core/Dxe/DxeMain.inf | 1 + MdeModulePkg/Core/Dxe/DxeMain/DxeMain.c | 6 + MdePkg/Include/Guid/EventGroup.h | 5 + MdePkg/Include/Protocol/MemoryAcceptance.h | 40 +++++ MdePkg/MdePkg.dec | 8 +- OvmfPkg/AmdSev/AmdSevX64.dsc | 1 + OvmfPkg/AmdSev/AmdSevX64.fdf | 1 + OvmfPkg/AmdSevDxe/AmdSevDxe.c | 55 ++++++- OvmfPkg/AmdSevDxe/AmdSevDxe.inf | 3 + OvmfPkg/CocoDxe/CocoDxe.c | 174 ++++++++++++++++++++ OvmfPkg/CocoDxe/CocoDxe.inf | 46 ++++++ OvmfPkg/IntelTdx/IntelTdxX64.dsc | 1 + OvmfPkg/IntelTdx/IntelTdxX64.fdf | 1 + OvmfPkg/Library/BaseMemEncryptSevLib/X64/DxeSnpSystemRamValidate.c | 24 ++- OvmfPkg/OvmfPkgIa32X64.dsc | 1 + OvmfPkg/OvmfPkgIa32X64.fdf | 1 + OvmfPkg/OvmfPkgX64.dsc | 1 + OvmfPkg/OvmfPkgX64.fdf | 1 + OvmfPkg/PlatformPei/AmdSev.c | 5 + 19 files changed, 366 insertions(+), 9 deletions(-) create mode 100644 MdePkg/Include/Protocol/MemoryAcceptance.h create mode 100644 OvmfPkg/CocoDxe/CocoDxe.c create mode 100644 OvmfPkg/CocoDxe/CocoDxe.inf -- 2.38.0.135.g90850a2211-goog