From: "Chiu, Chasel" <chasel.chiu@intel.com>
To: devel@edk2.groups.io
Cc: Chasel Chiu <chasel.chiu@intel.com>,
Nate DeSimone <nathaniel.l.desimone@intel.com>,
Star Zeng <star.zeng@intel.com>
Subject: [PATCH] IntelFsp2Pkg: Update Function header to support IA32/X64.
Date: Thu, 27 Oct 2022 19:58:29 -0700 [thread overview]
Message-ID: <20221028025829.1033-1-chasel.chiu@intel.com> (raw)
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4126
Common functions will have either 32bit or 64bit instances which
having different return code size. Function header should support both
scenarios.
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
Cc: Star Zeng <star.zeng@intel.com>
Signed-off-by: Chasel Chiu <chasel.chiu@intel.com>
---
IntelFsp2Pkg/FspSecCore/SecFsp.h | 4 ++--
IntelFsp2Pkg/Include/Library/FspSecPlatformLib.h | 12 ++++++------
2 files changed, 8 insertions(+), 8 deletions(-)
diff --git a/IntelFsp2Pkg/FspSecCore/SecFsp.h b/IntelFsp2Pkg/FspSecCore/SecFsp.h
index e84528b378..d7a5976c12 100644
--- a/IntelFsp2Pkg/FspSecCore/SecFsp.h
+++ b/IntelFsp2Pkg/FspSecCore/SecFsp.h
@@ -70,7 +70,7 @@ FspDataPointerFixUp (
@return FSP binary base address.
**/
-UINT32
+UINTN
EFIAPI
AsmGetFspBaseAddress (
VOID
@@ -82,7 +82,7 @@ AsmGetFspBaseAddress (
@return FSP binary base address.
**/
-UINT32
+UINTN
EFIAPI
AsmGetFspInfoHeader (
VOID
diff --git a/IntelFsp2Pkg/Include/Library/FspSecPlatformLib.h b/IntelFsp2Pkg/Include/Library/FspSecPlatformLib.h
index c91ea4a78f..598fdb9ec5 100644
--- a/IntelFsp2Pkg/Include/Library/FspSecPlatformLib.h
+++ b/IntelFsp2Pkg/Include/Library/FspSecPlatformLib.h
@@ -17,10 +17,10 @@
The callee should not use XMM6/XMM7.
The return address is saved in MM7.
- @retval in saved in EAX - 0 means platform initialization success.
+ @retval in saved in EAX/RAX - 0 means platform initialization success.
other means platform initialization fail.
**/
-UINT32
+UINTN
EFIAPI
SecPlatformInit (
VOID
@@ -37,10 +37,10 @@ SecPlatformInit (
@param[in] FsptUpdDataPtr Address pointer to the FSPT_UPD data structure. It is saved in ESP.
- @retval in saved in EAX - 0 means Microcode is loaded successfully.
+ @retval in saved in EAX/RAX - 0 means Microcode is loaded successfully.
other means Microcode is not loaded successfully.
**/
-UINT32
+UINTN
EFIAPI
LoadMicrocode (
IN VOID *FsptUpdDataPtr
@@ -56,10 +56,10 @@ LoadMicrocode (
@param[in] FsptUpdDataPtr Address pointer to the FSPT_UPD data structure. It is saved in ESP.
- @retval in saved in EAX - 0 means CAR initialization success.
+ @retval in saved in EAX/RAX - 0 means CAR initialization success.
other means CAR initialization fail.
**/
-UINT32
+UINTN
EFIAPI
SecCarInit (
IN VOID *FsptUpdDataPtr
--
2.35.0.windows.1
next reply other threads:[~2022-10-28 2:58 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-28 2:58 Chiu, Chasel [this message]
2022-11-01 0:52 ` [PATCH] IntelFsp2Pkg: Update Function header to support IA32/X64 Nate DeSimone
2022-11-01 19:15 ` Chiu, Chasel
2022-11-01 21:55 ` [edk2-devel] " Michael Kubacki
2022-11-01 21:56 ` Michael Kubacki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221028025829.1033-1-chasel.chiu@intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox