From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by mx.groups.io with SMTP id smtpd.web12.2172.1666925921569295620 for ; Thu, 27 Oct 2022 19:58:41 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=EvQptHVu; spf=pass (domain: intel.com, ip: 192.55.52.43, mailfrom: chasel.chiu@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1666925921; x=1698461921; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=QG+fXFmgqYOa3AcN09u5aCyrPY/CxAo7eSue6mheQVM=; b=EvQptHVu0tUjwQ5Sf4RXHWZ7TDuMcWPZN2xAzPChH9hB4wFVAZjUZ37+ leg4x+/PCa/4wfjwiQMwSFK0jDHNmaC5xm3sXWEW01NG0+4TM8vNXW+Nw uZYCdSgHmKnBr17rJ2VEGhuo9mGhsIClOpfleyu1PyjaYGsLm8EGgKD4G WAOs0UGQJTwE1GZLDO703QXQjpdnaxaCAqTUGdkZqUWZfMCSgbyF/g2vx tH3phM8YSvumsjWE/QrRKLLN5PxNrV74sD4VNsXH1Zn0xY5L0AZb8QFmS CinF+xpSzwqcVRM36Ug6KVYVlY0dMPmSxfAxHUCEXf9d6ZlcH1ogIjw9b Q==; X-IronPort-AV: E=McAfee;i="6500,9779,10513"; a="394708938" X-IronPort-AV: E=Sophos;i="5.95,219,1661842800"; d="scan'208";a="394708938" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Oct 2022 19:58:40 -0700 X-IronPort-AV: E=McAfee;i="6500,9779,10513"; a="696056774" X-IronPort-AV: E=Sophos;i="5.95,219,1661842800"; d="scan'208";a="696056774" Received: from cchiu4-mobl.gar.corp.intel.com ([10.251.7.172]) by fmsmga008-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Oct 2022 19:58:40 -0700 From: "Chiu, Chasel" To: devel@edk2.groups.io Cc: Chasel Chiu , Nate DeSimone , Star Zeng Subject: [PATCH] IntelFsp2Pkg: Update Function header to support IA32/X64. Date: Thu, 27 Oct 2022 19:58:29 -0700 Message-Id: <20221028025829.1033-1-chasel.chiu@intel.com> X-Mailer: git-send-email 2.35.0.windows.1 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D4126 Common functions will have either 32bit or 64bit instances which having different return code size. Function header should support both scenarios. Cc: Nate DeSimone Cc: Star Zeng Signed-off-by: Chasel Chiu --- IntelFsp2Pkg/FspSecCore/SecFsp.h | 4 ++-- IntelFsp2Pkg/Include/Library/FspSecPlatformLib.h | 12 ++++++------ 2 files changed, 8 insertions(+), 8 deletions(-) diff --git a/IntelFsp2Pkg/FspSecCore/SecFsp.h b/IntelFsp2Pkg/FspSecCore/Sec= Fsp.h index e84528b378..d7a5976c12 100644 --- a/IntelFsp2Pkg/FspSecCore/SecFsp.h +++ b/IntelFsp2Pkg/FspSecCore/SecFsp.h @@ -70,7 +70,7 @@ FspDataPointerFixUp ( @return FSP binary base address.=0D =0D **/=0D -UINT32=0D +UINTN=0D EFIAPI=0D AsmGetFspBaseAddress (=0D VOID=0D @@ -82,7 +82,7 @@ AsmGetFspBaseAddress ( @return FSP binary base address.=0D =0D **/=0D -UINT32=0D +UINTN=0D EFIAPI=0D AsmGetFspInfoHeader (=0D VOID=0D diff --git a/IntelFsp2Pkg/Include/Library/FspSecPlatformLib.h b/IntelFsp2Pk= g/Include/Library/FspSecPlatformLib.h index c91ea4a78f..598fdb9ec5 100644 --- a/IntelFsp2Pkg/Include/Library/FspSecPlatformLib.h +++ b/IntelFsp2Pkg/Include/Library/FspSecPlatformLib.h @@ -17,10 +17,10 @@ The callee should not use XMM6/XMM7.=0D The return address is saved in MM7.=0D =0D - @retval in saved in EAX - 0 means platform initialization success.=0D + @retval in saved in EAX/RAX - 0 means platform initialization success.=0D other means platform initialization fail.=0D **/=0D -UINT32=0D +UINTN=0D EFIAPI=0D SecPlatformInit (=0D VOID=0D @@ -37,10 +37,10 @@ SecPlatformInit ( =0D @param[in] FsptUpdDataPtr Address pointer to the FSPT_UPD data struc= ture. It is saved in ESP.=0D =0D - @retval in saved in EAX - 0 means Microcode is loaded successfully.=0D + @retval in saved in EAX/RAX - 0 means Microcode is loaded successfully.= =0D other means Microcode is not loaded successful= ly.=0D **/=0D -UINT32=0D +UINTN=0D EFIAPI=0D LoadMicrocode (=0D IN VOID *FsptUpdDataPtr=0D @@ -56,10 +56,10 @@ LoadMicrocode ( =0D @param[in] FsptUpdDataPtr Address pointer to the FSPT_UPD data struc= ture. It is saved in ESP.=0D =0D - @retval in saved in EAX - 0 means CAR initialization success.=0D + @retval in saved in EAX/RAX - 0 means CAR initialization success.=0D other means CAR initialization fail.=0D **/=0D -UINT32=0D +UINTN=0D EFIAPI=0D SecCarInit (=0D IN VOID *FsptUpdDataPtr=0D --=20 2.35.0.windows.1