[PATCH v1 0/1] PrmPkg: Fix WHQL Signed Driver Test failure for PRMT device.

[PATCH v1 0/1] PrmPkg: Fix WHQL Signed Driver Test failure for PRMT device.

[Xu, Wei6]

This patch is to fix the WHQL Signed Driver Test failure when there is no driver installed for PRMT device.

The Bugzila link: https://bugzilla.tianocore.org/show_bug.cgi?id=4141
The forked branch for review: https://github.com/xuweiintel/edk2/tree/prm_cid

Cc: Michael Kubacki <michael.kubacki@microsoft.com>
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
Cc: Ankit Sinha <ankit.sinha@intel.com>

Wei6 Xu (1):
  PrmPkg/PrmSsdtInstallDxe: Update PRMT Device CID to PNP0C02.

 PrmPkg/PrmSsdtInstallDxe/Prm.asl | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

-- 
2.29.2.windows.2

[PATCH v1 1/1] PrmPkg/PrmSsdtInstallDxe: Update PRMT Device CID to PNP0C02.

[Xu, Wei6]

REF:https://bugzilla.tianocore.org/show_bug.cgi?id=4141

PRMT device is an unknown device in Device Manager if there is no
Windows Driver installed for it. It will cause WHQL Signed Driver
test failure.
To complete WHQL certification, update PRMT Device CID to PNP0C02.
In this way, PRMT Device will be a Motherboard Resources when no
real driver is loaded (default), but will be shown as the actual
device name when a legitimate Windows Driver is loaded.

Cc: Michael Kubacki <michael.kubacki@microsoft.com>
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
Cc: Ankit Sinha <ankit.sinha@intel.com>
Signed-off-by: Wei6 Xu <wei6.xu@intel.com>
---
 PrmPkg/PrmSsdtInstallDxe/Prm.asl | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/PrmPkg/PrmSsdtInstallDxe/Prm.asl b/PrmPkg/PrmSsdtInstallDxe/Prm.asl
index e34336b4eee6..c4c406e93e2f 100644
--- a/PrmPkg/PrmSsdtInstallDxe/Prm.asl
+++ b/PrmPkg/PrmSsdtInstallDxe/Prm.asl
@@ -22,7 +22,7 @@ DefinitionBlock (
         Device (PRMT)
         {
             Name (_HID, "80860223")
-            Name (_CID, "80860223")
+            Name (_CID, EisaId ("PNP0C02"))
             Name (_DDN, "PRM Test Device")
 
             //PRM operation region format
-- 
2.29.2.windows.2

Re: [edk2-devel] [PATCH v1 1/1] PrmPkg/PrmSsdtInstallDxe: Update PRMT Device CID to PNP0C02.

[Michael Kubacki]

[-- Attachment #1: Type: text/plain, Size: 360 bytes --]

Reviewed-by: Michael Kubacki <michael.kubacki@microsoft.com>

For the future, I prefer my email in Maintainers.txt ( mikuback@linux.microsoft.com ) be used for the mailing list. It has filters set up and works better with lists.

I will merge this patch in 24 hours if there's no additional feedback given indicating rework is needed.

Thanks,
Michael

[-- Attachment #2: Type: text/html, Size: 473 bytes --]

Re: [PATCH v1 1/1] PrmPkg/PrmSsdtInstallDxe: Update PRMT Device CID to PNP0C02.

[Ankit Sinha]

Reviewed-by: Ankit Sinha <ankit.sinha@intel.com>


> -----Original Message-----
> From: Xu, Wei6 <wei6.xu@intel.com>
> Sent: Monday, November 7, 2022 3:58 AM
> To: devel@edk2.groups.io
> Cc: Kubacki, Michael <michael.kubacki@microsoft.com>; Desimone,
> Nathaniel L <nathaniel.l.desimone@intel.com>; Sinha, Ankit
> <ankit.sinha@intel.com>
> Subject: [PATCH v1 1/1] PrmPkg/PrmSsdtInstallDxe: Update PRMT Device CID
> to PNP0C02.
> 
> REF:https://bugzilla.tianocore.org/show_bug.cgi?id=4141
> 
> PRMT device is an unknown device in Device Manager if there is no Windows
> Driver installed for it. It will cause WHQL Signed Driver test failure.
> To complete WHQL certification, update PRMT Device CID to PNP0C02.
> In this way, PRMT Device will be a Motherboard Resources when no real
> driver is loaded (default), but will be shown as the actual device name when
> a legitimate Windows Driver is loaded.
> 
> Cc: Michael Kubacki <michael.kubacki@microsoft.com>
> Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
> Cc: Ankit Sinha <ankit.sinha@intel.com>
> Signed-off-by: Wei6 Xu <wei6.xu@intel.com>
> ---
>  PrmPkg/PrmSsdtInstallDxe/Prm.asl | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/PrmPkg/PrmSsdtInstallDxe/Prm.asl
> b/PrmPkg/PrmSsdtInstallDxe/Prm.asl
> index e34336b4eee6..c4c406e93e2f 100644
> --- a/PrmPkg/PrmSsdtInstallDxe/Prm.asl
> +++ b/PrmPkg/PrmSsdtInstallDxe/Prm.asl
> @@ -22,7 +22,7 @@ DefinitionBlock (
>          Device (PRMT)
>          {
>              Name (_HID, "80860223")
> -            Name (_CID, "80860223")
> +            Name (_CID, EisaId ("PNP0C02"))
>              Name (_DDN, "PRM Test Device")
> 
>              //PRM operation region format
> --
> 2.29.2.windows.2

Re: [edk2-devel] [PATCH v1 1/1] PrmPkg/PrmSsdtInstallDxe: Update PRMT Device CID to PNP0C02.

[Michael Kubacki]

[-- Attachment #1: Type: text/plain, Size: 50 bytes --]

Pushed 6032b46dce1dea705f95ecfdb68656281f0822f7

[-- Attachment #2: Type: text/html, Size: 54 bytes --]