From: "Michael Kubacki" <mikuback@linux.microsoft.com>
To: devel@edk2.groups.io
Cc: Sean Brogan <sean.brogan@microsoft.com>,
Michael D Kinney <michael.d.kinney@intel.com>
Subject: [PATCH v2 2/2] edk2.qls: Allow error severity results and add new queries
Date: Tue, 8 Nov 2022 19:21:41 -0500 [thread overview]
Message-ID: <20221109002141.1804-3-mikuback@linux.microsoft.com> (raw)
In-Reply-To: <20221109002141.1804-1-mikuback@linux.microsoft.com>
From: Michael Kubacki <michael.kubacki@microsoft.com>
The query cpp/conditionallyuninitializedvariable was initially
enabled with the CodeQL code because work was in progress on those
changes. The results were filtered out so CodeQL passed so we could
verify the CodeQL workflow without impacting CI results.
This change allows error severity messages and substitutes that query
with two queries that do not return failures. This allows these
queries to find future problems and prepares the CodeQL workflow to
catch future failures as queries are enabled.
Cc: Sean Brogan <sean.brogan@microsoft.com>
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
Reviewed-by: Sean Brogan <sean.brogan@microsoft.com>
---
.github/codeql/codeql-config.yml | 1 -
.github/codeql/edk2.qls | 4 +++-
2 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/.github/codeql/codeql-config.yml b/.github/codeql/codeql-config.yml
index 3e27c2fb0d28..a51db141ebe3 100644
--- a/.github/codeql/codeql-config.yml
+++ b/.github/codeql/codeql-config.yml
@@ -25,6 +25,5 @@ queries:
query-filters:
- exclude:
problem.severity:
- - error
- warning
- recommendation
diff --git a/.github/codeql/edk2.qls b/.github/codeql/edk2.qls
index 0efc7dca52db..ef9aae790f5f 100644
--- a/.github/codeql/edk2.qls
+++ b/.github/codeql/edk2.qls
@@ -9,4 +9,6 @@
# Enable individual queries below.
- include:
- id: cpp/conditionallyuninitializedvariable
+ id: cpp/infinite-loop-with-unsatisfiable-exit-condition
+- include:
+ id: cpp/overflow-buffer
--
2.28.0.windows.1
next prev parent reply other threads:[~2022-11-09 0:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-09 0:21 [PATCH v2 0/2] Enable CodeQL Failures and Add New Queries Michael Kubacki
2022-11-09 0:21 ` [PATCH v2 1/2] BaseTools: Fix wrong type of arguments to formatting functions Michael Kubacki
2022-11-09 0:21 ` Michael Kubacki [this message]
2022-11-09 0:55 ` [PATCH v2 0/2] Enable CodeQL Failures and Add New Queries Michael D Kinney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221109002141.1804-3-mikuback@linux.microsoft.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox