From: "Ard Biesheuvel" <ardb@kernel.org>
To: devel@edk2.groups.io
Cc: Ard Biesheuvel <ardb@kernel.org>,
Liming Gao <gaoliming@byosoft.com.cn>,
Rebecca Cran <rebecca@bsdio.com>,
Pierre Gondois <pierre.gondois@arm.com>,
Leif Lindholm <quic_llindhol@quicinc.com>,
Sami Mujawar <sami.mujawar@arm.com>,
Gerd Hoffmann <kraxel@redhat.com>,
"Jason A . Donenfeld" <Jason@zx2c4.com>
Subject: [PATCH 1/3] ArmPkg/ArmTrngLib: Fix incorrect GUID reference in DEBUG() output
Date: Thu, 10 Nov 2022 14:47:36 +0100 [thread overview]
Message-ID: <20221110134738.3798618-2-ardb@kernel.org> (raw)
In-Reply-To: <20221110134738.3798618-1-ardb@kernel.org>
ArmTrngLib crashes when run in DEBUG mode due to the fact that it passed
the [truncated] GUID value to a DEBUG() print statement instead of a
pointer to the GUID which is what the %g conversion expects.
Signed-off-by: Ard Biesheuvel <ardb@kernel.org>
---
ArmPkg/Library/ArmTrngLib/ArmTrngLib.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/ArmPkg/Library/ArmTrngLib/ArmTrngLib.c b/ArmPkg/Library/ArmTrngLib/ArmTrngLib.c
index b974a9423880..fdabc02cd39c 100644
--- a/ArmPkg/Library/ArmTrngLib/ArmTrngLib.c
+++ b/ArmPkg/Library/ArmTrngLib/ArmTrngLib.c
@@ -375,7 +375,7 @@ ArmTrngLibConstructor (
"FW-TRNG: Version %d.%d, GUID {%g}\n",
MajorRev,
MinorRev,
- Guid
+ &Guid
));
DEBUG_CODE_END ();
--
2.35.1
next prev parent reply other threads:[~2022-11-10 13:48 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-10 13:47 [PATCH 0/3] OVMF: support EFI_RNG_PROTOCOL without virtio-rng Ard Biesheuvel
2022-11-10 13:47 ` Ard Biesheuvel [this message]
2022-11-10 14:39 ` [PATCH 1/3] ArmPkg/ArmTrngLib: Fix incorrect GUID reference in DEBUG() output Sami Mujawar
2022-11-10 13:47 ` [PATCH 2/3] ArmVirtPkg/ArmVirtQemu: Expose TRNG hypercall via RngDxe if implemented Ard Biesheuvel
2022-11-18 16:48 ` PierreGondois
2023-01-11 16:49 ` [edk2-devel] " Ard Biesheuvel
2023-01-11 17:38 ` PierreGondois
2023-01-11 17:45 ` Ard Biesheuvel
2022-11-10 13:47 ` [PATCH 3/3] OvmfPkg/OvmfX86: Enable RDRAND based EFI_RNG_PROTOCOL implementation Ard Biesheuvel
2022-11-22 11:35 ` [edk2-devel] " Pedro Falcato
2022-11-22 12:20 ` Jason A. Donenfeld
2022-11-22 12:45 ` Pedro Falcato
2022-11-22 13:10 ` Jason A. Donenfeld
2022-11-22 14:17 ` Pedro Falcato
2022-11-22 14:21 ` Jason A. Donenfeld
2022-11-22 12:29 ` Jason A. Donenfeld
2022-11-11 0:41 ` 回复: [PATCH 0/3] OVMF: support EFI_RNG_PROTOCOL without virtio-rng gaoliming
2022-11-11 2:41 ` Jason A. Donenfeld
2022-11-11 7:47 ` Ard Biesheuvel
2022-11-11 17:03 ` Jason A. Donenfeld
[not found] ` <172660F4A69E435E.25609@groups.io>
2022-11-11 3:53 ` 回复: [edk2-devel] 回复: " gaoliming
2022-11-11 7:34 ` Ard Biesheuvel
2022-11-11 8:14 ` [edk2-devel] " Gerd Hoffmann
2023-01-10 18:19 ` Jason A. Donenfeld
2023-01-11 11:41 ` Ard Biesheuvel
2023-01-11 15:23 ` [edk2-devel] " Laszlo Ersek
2023-01-11 16:03 ` Ard Biesheuvel
2023-01-11 16:05 ` Ard Biesheuvel
2023-01-12 9:27 ` Laszlo Ersek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221110134738.3798618-2-ardb@kernel.org \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox