From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by mx.groups.io with SMTP id smtpd.web10.7543.1668088083133740311 for ; Thu, 10 Nov 2022 05:48:03 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=XoSHMYL2; spf=pass (domain: kernel.org, ip: 139.178.84.217, mailfrom: ardb@kernel.org) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 86AE8617BE; Thu, 10 Nov 2022 13:48:02 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0F71AC433D7; Thu, 10 Nov 2022 13:47:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1668088082; bh=DcYAfjGaE4aHsCk4LsJxjZXhyZPynkHu/pdNmOUjsfY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=XoSHMYL2kqZ5ua7ikpI5g3uLWX5cEc/nflYHLX8+bih4psQ+kuZu9+YZnr2D4QfUm EOXsjFr+Pbmb1l63sux+jNIn7oHBCF3NineLV5lYUhTB3ueBkeP9SEIYETXoMg3yut PWr8fh/GkaGdeQELsy/pxLdWZp6sT9RcBJsyBwHOggSDbnet6L3qjHQ1qvaZ8HKImn 01txegXsNCtqgQHpob517ZMNFGo4I7FOaAYUr6jXP4dHuV3ftFjhG6+S+sp14v898B 7qedRgZZTAeV/C6yV4eVDmDAlWVkLmIFb2PUSrXRRATctpY3CoCeCcPRDFwz8zKMt8 enedHvtM8Mjbw== From: "Ard Biesheuvel" To: devel@edk2.groups.io Cc: Ard Biesheuvel , Liming Gao , Rebecca Cran , Pierre Gondois , Leif Lindholm , Sami Mujawar , Gerd Hoffmann , "Jason A . Donenfeld" Subject: [PATCH 1/3] ArmPkg/ArmTrngLib: Fix incorrect GUID reference in DEBUG() output Date: Thu, 10 Nov 2022 14:47:36 +0100 Message-Id: <20221110134738.3798618-2-ardb@kernel.org> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20221110134738.3798618-1-ardb@kernel.org> References: <20221110134738.3798618-1-ardb@kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ArmTrngLib crashes when run in DEBUG mode due to the fact that it passed the [truncated] GUID value to a DEBUG() print statement instead of a pointer to the GUID which is what the %g conversion expects. Signed-off-by: Ard Biesheuvel --- ArmPkg/Library/ArmTrngLib/ArmTrngLib.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ArmPkg/Library/ArmTrngLib/ArmTrngLib.c b/ArmPkg/Library/ArmTrn= gLib/ArmTrngLib.c index b974a9423880..fdabc02cd39c 100644 --- a/ArmPkg/Library/ArmTrngLib/ArmTrngLib.c +++ b/ArmPkg/Library/ArmTrngLib/ArmTrngLib.c @@ -375,7 +375,7 @@ ArmTrngLibConstructor ( "FW-TRNG: Version %d.%d, GUID {%g}\n",=0D MajorRev,=0D MinorRev,=0D - Guid=0D + &Guid=0D ));=0D =0D DEBUG_CODE_END ();=0D --=20 2.35.1