public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Michael Kubacki" <mikuback@linux.microsoft.com>
To: devel@edk2.groups.io
Cc: Sean Brogan <sean.brogan@microsoft.com>,
	Michael Kubacki <mikuback@linux.microsoft.com>,
	Liming Gao <gaoliming@byosoft.com.cn>,
	Andrew Fish <afish@apple.com>,
	Leif Lindholm <quic_llindhol@quicinc.com>
Subject: [PATCH edk2-stable202211 v2 0/2] Update Pytool PIP Versions
Date: Mon, 14 Nov 2022 19:18:39 -0500	[thread overview]
Message-ID: <20221115001841.2018-1-mikuback@linux.microsoft.com> (raw)

From: Michael Kubacki <michael.kubacki@microsoft.com>

1. Updates edk2-pytool-library to 0.12.1
   - Picks up a minor bug fix

2. Updates edk2-pytool-extensions to 0.20.0
   - Picks up a major release

The changes in each update are in the respective patch commit
messages.

CI was run against both of these patches in this pull request:
https://github.com/tianocore/edk2/pull/3632

These changes are recommended to be included in the edk2-stable202211
tag for the following reasons:

1. edk2-pytool-library 0.12.0 to 0.12.1 includes a single bug fix
   that simply returns file paths from
   Edk2Path.GetContainingModules() with the original case used by
   the operating system. This allow case sensitive callers to match
   paths returned by the function correctly.

   This can impact flows such as PR Eval that use this function to
   determine which modules were impacted by a code change. Without
   this change PR eval may not return consistent/expected results
   across operating systems.

2. The edk2-pytool-library change requires edk2-pytool-extensions
   0.20.0. For this reason, edk2-pytool-extensions setup.py was
   updated in 0.20.0 to specify 0.12.1 as the edk2-pytool-library
   requirement. The logic of determining a package in pytool-library
   (Edk2Path.GetContainingPackage()) needs a corresponding change in
   the edk2-pytool-extensions 0.20.0 release.

   Without this change, flows such as PR Eval will not have updated
   logic for calling the function and return incorrect results.

These changes have been tested against edk2 in pytool integration
testing, the PR linked above, and against similar code in Mu.

V2 changes:

1. Add stable tag to patch subject
2. Explain why changes should be included in stable tag
3. Add Reviewed-by tags to patches from v1

Cc: Sean Brogan <sean.brogan@microsoft.com>
Cc: Michael Kubacki <mikuback@linux.microsoft.com>
Cc: Liming Gao <gaoliming@byosoft.com.cn>
Cc: Andrew Fish <afish@apple.com>
Cc: Leif Lindholm <quic_llindhol@quicinc.com>
Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>

Michael Kubacki (2):
  pip-requirements.txt: Update to edk2-pytool-library 0.12.1
  pip-requirements.txt: Update to edk2-pytool-extensions 0.20.0

 pip-requirements.txt | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

-- 
2.28.0.windows.1


             reply	other threads:[~2022-11-15  0:19 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-15  0:18 Michael Kubacki [this message]
2022-11-15  0:18 ` [PATCH edk2-stable202211 v2 1/2] pip-requirements.txt: Update to edk2-pytool-library 0.12.1 Michael Kubacki
2022-11-15  0:18 ` [PATCH edk2-stable202211 v2 2/2] pip-requirements.txt: Update to edk2-pytool-extensions 0.20.0 Michael Kubacki
2022-11-15  3:00 ` 回复: [PATCH edk2-stable202211 v2 0/2] Update Pytool PIP Versions gaoliming
2022-11-15  3:17   ` [edk2-devel] " Michael Kubacki
2022-11-15  3:45     ` Michael D Kinney
2022-11-15 14:35       ` Michael Kubacki
2022-11-16 21:46         ` Michael D Kinney
2022-11-17  1:53           ` 回复: " gaoliming

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221115001841.2018-1-mikuback@linux.microsoft.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox