From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mx.groups.io with SMTP id smtpd.web10.71.1668471550534662722 for ; Mon, 14 Nov 2022 16:19:10 -0800 Authentication-Results: mx.groups.io; dkim=fail reason="body hash did not verify" header.i=@linux.microsoft.com header.s=default header.b=F+8+j8Zs; spf=pass (domain: linux.microsoft.com, ip: 13.77.154.182, mailfrom: mikuback@linux.microsoft.com) Received: from localhost.localdomain (unknown [47.201.8.94]) by linux.microsoft.com (Postfix) with ESMTPSA id 2369820B717A; Mon, 14 Nov 2022 16:19:09 -0800 (PST) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 2369820B717A DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1668471549; bh=Beo9f+CfQYnEHZSljbiUou/P3wz9RrXbPtqT+iNEhvs=; h=From:To:Cc:Subject:Date:From; b=F+8+j8ZsMIDKD/Kx3aD+7/DoamoYhav4Su2PnXVk2ZiUKzV++Q9NI2cXND/RWV6YF u3vKh/Q7vsfN/1F4kLw2XRhBKv191nBv1PqaoNZqASgw2ejd8MMpIWnbmYiwJQlmbn JxydirN+Nra3sz8nxvf/XEc1s2vUp/IkSnIaffHo= From: "Michael Kubacki" To: devel@edk2.groups.io Cc: Sean Brogan , Michael Kubacki , Liming Gao , Andrew Fish , Leif Lindholm Subject: [PATCH edk2-stable202211 v2 0/2] Update Pytool PIP Versions Date: Mon, 14 Nov 2022 19:18:39 -0500 Message-Id: <20221115001841.2018-1-mikuback@linux.microsoft.com> X-Mailer: git-send-email 2.28.0.windows.1 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable From: Michael Kubacki 1. Updates edk2-pytool-library to 0.12.1 - Picks up a minor bug fix 2. Updates edk2-pytool-extensions to 0.20.0 - Picks up a major release The changes in each update are in the respective patch commit messages. CI was run against both of these patches in this pull request: https://github.com/tianocore/edk2/pull/3632 These changes are recommended to be included in the edk2-stable202211 tag for the following reasons: 1. edk2-pytool-library 0.12.0 to 0.12.1 includes a single bug fix that simply returns file paths from Edk2Path.GetContainingModules() with the original case used by the operating system. This allow case sensitive callers to match paths returned by the function correctly. This can impact flows such as PR Eval that use this function to determine which modules were impacted by a code change. Without this change PR eval may not return consistent/expected results across operating systems. 2. The edk2-pytool-library change requires edk2-pytool-extensions 0.20.0. For this reason, edk2-pytool-extensions setup.py was updated in 0.20.0 to specify 0.12.1 as the edk2-pytool-library requirement. The logic of determining a package in pytool-library (Edk2Path.GetContainingPackage()) needs a corresponding change in the edk2-pytool-extensions 0.20.0 release. Without this change, flows such as PR Eval will not have updated logic for calling the function and return incorrect results. These changes have been tested against edk2 in pytool integration testing, the PR linked above, and against similar code in Mu. V2 changes: 1. Add stable tag to patch subject 2. Explain why changes should be included in stable tag 3. Add Reviewed-by tags to patches from v1 Cc: Sean Brogan Cc: Michael Kubacki Cc: Liming Gao Cc: Andrew Fish Cc: Leif Lindholm Signed-off-by: Michael Kubacki Michael Kubacki (2): pip-requirements.txt: Update to edk2-pytool-library 0.12.1 pip-requirements.txt: Update to edk2-pytool-extensions 0.20.0 pip-requirements.txt | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) --=20 2.28.0.windows.1