From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124])
 by mx.groups.io with SMTP id smtpd.web10.32347.1669011839084330618
 for <devel@edk2.groups.io>;
 Sun, 20 Nov 2022 22:23:59 -0800
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=LIjYuyIe;
 spf=pass (domain: redhat.com, ip: 170.10.129.124, mailfrom: kraxel@redhat.com)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
	s=mimecast20190719; t=1669011837;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=FVRn29CG+y9H+Oo9iJcUfz3nRhveIMl6FEZDgAiZ4tQ=;
	b=LIjYuyIeKWnYoHwHDsI83SKlt+jqvtBPK3B4foAD4msTy6/vJAedOnC2c6/UQ6m76do5GE
	MjNKbAhLTAwaAwhFW9fQzNJ51zIb4HEdbvkYa0CDuUB4pfb2RrgUiTOoN7JnhyzCla1PKN
	uLudtWVwDqJD1ksUgtnIYXJCIJzz4DQ=
Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com
 [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS
 (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 us-mta-673-L7Km_eepNb2LiFqvD2R9QQ-1; Mon, 21 Nov 2022 01:23:51 -0500
X-MC-Unique: L7Km_eepNb2LiFqvD2R9QQ-1
Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4])
	(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by mimecast-mx02.redhat.com (Postfix) with ESMTPS id BEBF0811E75;
	Mon, 21 Nov 2022 06:23:50 +0000 (UTC)
Received: from sirius.home.kraxel.org (unknown [10.39.192.24])
	by smtp.corp.redhat.com (Postfix) with ESMTPS id 7FA4B2027062;
	Mon, 21 Nov 2022 06:23:50 +0000 (UTC)
Received: by sirius.home.kraxel.org (Postfix, from userid 1000)
	id E0EA7180091D; Mon, 21 Nov 2022 07:23:46 +0100 (CET)
Date: Mon, 21 Nov 2022 07:23:46 +0100
From: "Gerd Hoffmann" <kraxel@redhat.com>
To: devel@edk2.groups.io, jiewen.yao@intel.com
Cc: "Li, Yi1" <yi1.li@intel.com>, "Wang, Jian J" <jian.j.wang@intel.com>,
	"Lu, Xiaoyu1" <xiaoyu1.lu@intel.com>,
	"Jiang, Guomin" <guomin.jiang@intel.com>
Subject: Re: [edk2-devel] [PATCH] CryptoPkg: Add b_print.c which removed floating-point to OpensslLib
Message-ID: <20221121062346.fu5n2dgx3s74fcrb@sirius.home.kraxel.org>
References: <20221119162754.1034-1-yi1.li@intel.com>
 <SJ1PR11MB6227CE1E87DDAE833E266EF9C5089@SJ1PR11MB6227.namprd11.prod.outlook.com>
 <PH0PR11MB58793D259D8F65379098C7B18C0B9@PH0PR11MB5879.namprd11.prod.outlook.com>
MIME-Version: 1.0
In-Reply-To: <PH0PR11MB58793D259D8F65379098C7B18C0B9@PH0PR11MB5879.namprd11.prod.outlook.com>
X-Scanned-By: MIMEDefang 3.1 on 10.11.54.4
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Sun, Nov 20, 2022 at 02:18:36AM +0000, Yao, Jiewen wrote:
> HI Yi
> I have question for 1 - The original file uses code related to floating-point and ulldrvm.
> 
> a) Openssl supports OPENSSL_SYS_UEFI macro (https://github.com/tianocore/edk2/blob/master/CryptoPkg/Library/Include/openssl/opensslconf.h#L28), why not use OPENSSL_SYS_UEFI macro to eliminate float point action?

openssl 3.x already has that btw.

take care,
  Gerd