From: "Gerd Hoffmann" <kraxel@redhat.com>
To: devel@edk2.groups.io
Cc: Oliver Steffen <osteffen@redhat.com>,
Gerd Hoffmann <kraxel@redhat.com>,
Pawel Polawski <ppolawsk@redhat.com>,
Ard Biesheuvel <ardb+tianocore@kernel.org>,
Jordan Justen <jordan.l.justen@intel.com>,
Jiewen Yao <jiewen.yao@intel.com>
Subject: [PATCH 1/1] OvmfPkg/PciHotPlugInitDxe: fix io window size
Date: Mon, 28 Nov 2022 07:25:58 +0100 [thread overview]
Message-ID: <20221128062558.173307-1-kraxel@redhat.com> (raw)
Smallest IO window size for PCI bridges is 0x1000. Add a check and
fixup the Exponent of needed. Avoids broken resource assignments
like this:
[ ... ]
PciBus: Resource Map for Root Bridge PciRoot(0x0)
Type = Io16; Base = 0x6000; Length = 0x7000; Alignment = 0xFFF
[ ... ]
Base = 0xC000; Length = 0x200; Alignment = 0xFFF; Owner = PPB [00|02|00:**]
Base = 0xC200; Length = 0x40; Alignment = 0x3F; Owner = PCI [00|1F|03:20]
Base = 0xC240; Length = 0x20; Alignment = 0x1F; Owner = PCI [00|1F|02:20]
[ ... ]
... which the linux kernel fixes up later:
[ 0.644657] pci 0000:00:1f.3: BAR 4: assigned [io 0x1000-0x103f]
[ 0.646833] pci 0000:00:1f.2: BAR 4: assigned [io 0x1040-0x105f]
With the patch applied:
{ ... ]
PciBus: Resource Map for Root Bridge PciRoot(0x0)
Type = Io16; Base = 0x6000; Length = 0x8000; Alignment = 0xFFF
[ ... ]
Base = 0xC000; Length = 0x1000; Alignment = 0xFFF; Owner = PPB [00|02|00:**]
Base = 0xD000; Length = 0x40; Alignment = 0x3F; Owner = PCI [00|1F|03:20]
Base = 0xD040; Length = 0x20; Alignment = 0x1F; Owner = PCI [00|1F|02:20]
[ ... ]
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
---
OvmfPkg/PciHotPlugInitDxe/PciHotPlugInit.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/OvmfPkg/PciHotPlugInitDxe/PciHotPlugInit.c b/OvmfPkg/PciHotPlugInitDxe/PciHotPlugInit.c
index 3f9c84cf2b54..6c8bbc3b199d 100644
--- a/OvmfPkg/PciHotPlugInitDxe/PciHotPlugInit.c
+++ b/OvmfPkg/PciHotPlugInitDxe/PciHotPlugInit.c
@@ -117,6 +117,10 @@ SetIoPadding (
IN UINTN SizeExponent
)
{
+ if (SizeExponent < 12) {
+ SizeExponent = 12;
+ }
+
Descriptor->ResType = ACPI_ADDRESS_SPACE_TYPE_IO;
Descriptor->AddrLen = LShiftU64 (1, SizeExponent);
Descriptor->AddrRangeMax = Descriptor->AddrLen - 1;
--
2.38.1
next reply other threads:[~2022-11-28 6:26 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-28 6:25 Gerd Hoffmann [this message]
2022-12-09 7:28 ` [edk2-devel] [PATCH 1/1] OvmfPkg/PciHotPlugInitDxe: fix io window size Yao, Jiewen
[not found] ` <172F0F650773A361.1612@groups.io>
2022-12-09 8:11 ` Yao, Jiewen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221128062558.173307-1-kraxel@redhat.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox