From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124])
 by mx.groups.io with SMTP id smtpd.web11.121454.1669650383440638731
 for <devel@edk2.groups.io>;
 Mon, 28 Nov 2022 07:46:23 -0800
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=XAXN9lPB;
 spf=pass (domain: redhat.com, ip: 170.10.133.124, mailfrom: kraxel@redhat.com)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
	s=mimecast20190719; t=1669650382;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=D4VXQcl2kPyz9ryFuOCm755+xfNwUERLywJpKC+YcHI=;
	b=XAXN9lPB0ewrIgv0TsgKdp9ndNjl7DYxranUaDM5Uxkkt0IOGYWxMOeX6+SZI7aWY+L8rr
	ZWytmfnytgggkg/Wr4a8fR6EoFqT4NpZQAF/acYyfjPG/L/taG7GAWZCiTICDD8MOs9VGk
	dmg+6WWpxuhvo/CUrDzgNSQv3lOTWTs=
Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com
 [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS
 (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 us-mta-498-2f4zORLtMr-HabG-NiXPsg-1; Mon, 28 Nov 2022 10:46:18 -0500
X-MC-Unique: 2f4zORLtMr-HabG-NiXPsg-1
Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.rdu2.redhat.com [10.11.54.8])
	(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 91661101AA45;
	Mon, 28 Nov 2022 15:46:17 +0000 (UTC)
Received: from sirius.home.kraxel.org (unknown [10.39.192.79])
	by smtp.corp.redhat.com (Postfix) with ESMTPS id 3A452C15BAB;
	Mon, 28 Nov 2022 15:46:16 +0000 (UTC)
Received: by sirius.home.kraxel.org (Postfix, from userid 1000)
	id 2389D1800080; Mon, 28 Nov 2022 16:46:10 +0100 (CET)
Date: Mon, 28 Nov 2022 16:46:10 +0100
From: "Gerd Hoffmann" <kraxel@redhat.com>
To: devel@edk2.groups.io, ardb@kernel.org
Cc: Leif Lindholm <quic_llindhol@quicinc.com>,
	Alexander Graf <agraf@csgraf.de>
Subject: Re: [edk2-devel] [PATCH v3 03/16] ArmVirtPkg: make EFI_LOADER_DATA non-executable
Message-ID: <20221128154610.wik3f65bhbfrdpva@sirius.home.kraxel.org>
References: <20220926082511.2110797-1-ardb@kernel.org>
 <20220926082511.2110797-4-ardb@kernel.org>
MIME-Version: 1.0
In-Reply-To: <20220926082511.2110797-4-ardb@kernel.org>
X-Scanned-By: MIMEDefang 3.1 on 10.11.54.8
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Mon, Sep 26, 2022 at 10:24:58AM +0200, Ard Biesheuvel wrote:
> When the memory protections were implemented and enabled on ArmVirtQemu
> 5+ years ago, we had to work around the fact that GRUB at the time
> expected EFI_LOADER_DATA to be executable, as that is the memory type it
> allocates when loading its modules.
> 
> This has been fixed in GRUB in August 2017, so by now, we should be able
> to tighten this, and remove execute permissions from EFI_LOADER_DATA
> allocations.

Data point: https://bugzilla.redhat.com/show_bug.cgi?id=2149020
tl;dr: fedora 37 grub.efi is still broken.

take care,
  Gerd