public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Rebecca Cran" <quic_rcran@quicinc.com>
To: <devel@edk2.groups.io>,
	Ard Biesheuvel <ardb+tianocore@kernel.org>,
	"Thomas Abraham" <thomas.abraham@arm.com>,
	Sami Mujawar <sami.mujawar@arm.com>
Cc: Rebecca Cran <rebecca@quicinc.com>
Subject: [PATCH edk2-platforms 0/3] Platform/ARM/JunoPkg: Timer fixes
Date: Tue, 29 Nov 2022 06:53:55 -0700	[thread overview]
Message-ID: <20221129135358.136555-1-rebecca@quicinc.com> (raw)

The use of the EmbeddedPkg/MetronomeDxe driver on Juno can cause problems
with drivers that use gBS->Stall, since it takes 10x longer than
requested. For example requesting a timeout of 1 ms when doing a USB 
bulk transfer results in it taking 100 ms. Switching to the
MdeModulePkg/Universal/Metronome driver fixes this since it assumes the
timer clock ticks at least every 100 ns.

While here, set the PCD value of the timer frequency to 0 so it gets
read from the SoC instead of hard-coding it.

Also, fix the time between interrupts in TimerDxe to be 1 ms as
the driver wants.

Rebecca Cran (3):
  Platform/ARM/JunoPkg: Switch to MdeModulePkg/Universal/Metronome
    driver
  Platform/ARM/JunoPkg: Override PcdTimerPeriod to be 10000
  Platform/ARM/JunoPkg: Set PcdArmArchTimerFreqInHz to 0 to read from
    CNTFRQ_EL0

 Platform/ARM/JunoPkg/ArmJuno.dsc | 7 ++++---
 Platform/ARM/JunoPkg/ArmJuno.fdf | 2 +-
 2 files changed, 5 insertions(+), 4 deletions(-)

-- 
2.30.2


             reply	other threads:[~2022-11-29 13:54 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-29 13:53 Rebecca Cran [this message]
2022-11-29 13:53 ` [PATCH edk2-platforms 1/3] Platform/ARM/JunoPkg: Switch to MdeModulePkg/Universal/Metronome driver Rebecca Cran
2022-11-29 13:53 ` [PATCH edk2-platforms 2/3] Platform/ARM/JunoPkg: Override PcdTimerPeriod to be 10000 Rebecca Cran
2022-12-05  9:22   ` [edk2-devel] " PierreGondois
2022-12-05 11:48     ` Rebecca Cran
2022-11-29 13:53 ` [PATCH edk2-platforms 3/3] Platform/ARM/JunoPkg: Set PcdArmArchTimerFreqInHz to 0 to read from CNTFRQ_EL0 Rebecca Cran

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221129135358.136555-1-rebecca@quicinc.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox