* [PATCH 1/1] ShellPkg: Improve "ping" output by adding equals sign after time @ 2022-12-01 21:49 Rebecca Cran 2022-12-06 2:17 ` [edk2-devel] " Gao, Zhichao 0 siblings, 1 reply; 6+ messages in thread From: Rebecca Cran @ 2022-12-01 21:49 UTC (permalink / raw) To: devel, Ray Ni, Zhichao Gao; +Cc: Rebecca Cran The output of the "ping" command shows the time without a space between the label and the value. e.g.: 20 bytes from 192.168.0.1 : icmp_seq=1 ttl=1 time1~2ms Improve the readability and consistency by adding an equals sign for the time value: 20 bytes from 192.168.0.1 : icmp_seq=1 ttl=1 time=1~2ms Signed-off-by: Rebecca Cran <rebecca@quicinc.com> --- ShellPkg/Library/UefiShellNetwork1CommandsLib/UefiShellNetwork1CommandsLib.uni | 2 +- ShellPkg/Library/UefiShellNetwork2CommandsLib/UefiShellNetwork2CommandsLib.uni | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/ShellPkg/Library/UefiShellNetwork1CommandsLib/UefiShellNetwork1CommandsLib.uni b/ShellPkg/Library/UefiShellNetwork1CommandsLib/UefiShellNetwork1CommandsLib.uni index 73cf96d9e614..37fd4a11929c 100644 --- a/ShellPkg/Library/UefiShellNetwork1CommandsLib/UefiShellNetwork1CommandsLib.uni +++ b/ShellPkg/Library/UefiShellNetwork1CommandsLib/UefiShellNetwork1CommandsLib.uni @@ -52,7 +52,7 @@ #string STR_PING_NOROUTE_FOUND #language en-US "There is no route to the destination '%B%s%N' from the source '%B%s%N' was found.\r\n" #string STR_PING_START #language en-US "Ping %s %d data bytes.\r\n" #string STR_PING_TIMEOUT #language en-US "Echo request sequence %d timeout.\r\n" -#string STR_PING_REPLY_INFO #language en-US "%d bytes from %s : icmp_seq=%d ttl=%d time%d~%dms\r\n" +#string STR_PING_REPLY_INFO #language en-US "%d bytes from %s : icmp_seq=%d ttl=%d time=%d~%dms\r\n" #string STR_PING_STAT #language en-US "\n%d packets transmitted, %d received, %d%% packet loss, time %dms\r\n" #string STR_PING_RTT #language en-US "\nRtt(round trip time) min=%d~%dms max=%d~%dms avg=%d~%dms\r\n" diff --git a/ShellPkg/Library/UefiShellNetwork2CommandsLib/UefiShellNetwork2CommandsLib.uni b/ShellPkg/Library/UefiShellNetwork2CommandsLib/UefiShellNetwork2CommandsLib.uni index 30913ae5b583..cb9d39a33fbe 100644 --- a/ShellPkg/Library/UefiShellNetwork2CommandsLib/UefiShellNetwork2CommandsLib.uni +++ b/ShellPkg/Library/UefiShellNetwork2CommandsLib/UefiShellNetwork2CommandsLib.uni @@ -33,7 +33,7 @@ #string STR_PING6_NOSOURCE_INDOMAIN #language en-US "No sources in %s's multicast domain.\r\n" #string STR_PING6_START #language en-US "Ping %s %d data bytes\r\n" #string STR_PING6_TIMEOUT #language en-US "Echo request sequence %d timeout.\r\n" -#string STR_PING6_REPLY_INFO #language en-US "%d bytes from %s : icmp_seq=%d ttl=%d time%d~%dms\r\n" +#string STR_PING6_REPLY_INFO #language en-US "%d bytes from %s : icmp_seq=%d ttl=%d time=%d~%dms\r\n" #string STR_PING6_STAT #language en-US "\n%d packets transmitted, %d received, %d%% packet loss, time %dms\r\n" #string STR_PING6_RTT #language en-US "\nRtt(round trip time) min=%d~%dms max=%d~%dms avg=%d~%dms\r\n" -- 2.30.2 ^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [edk2-devel] [PATCH 1/1] ShellPkg: Improve "ping" output by adding equals sign after time 2022-12-01 21:49 [PATCH 1/1] ShellPkg: Improve "ping" output by adding equals sign after time Rebecca Cran @ 2022-12-06 2:17 ` Gao, Zhichao 2023-02-21 0:45 ` Rebecca Cran 0 siblings, 1 reply; 6+ messages in thread From: Gao, Zhichao @ 2022-12-06 2:17 UTC (permalink / raw) To: devel@edk2.groups.io, quic_rcran@quicinc.com, Ni, Ray; +Cc: Rebecca Cran Reviewed-by: Zhichao Gao <zhichao.gao@intel.com> Thanks, Zhichao > -----Original Message----- > From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Rebecca > Cran > Sent: Friday, December 2, 2022 5:50 AM > To: devel@edk2.groups.io; Ni, Ray <ray.ni@intel.com>; Gao, Zhichao > <zhichao.gao@intel.com> > Cc: Rebecca Cran <rebecca@quicinc.com> > Subject: [edk2-devel] [PATCH 1/1] ShellPkg: Improve "ping" output by adding > equals sign after time > > The output of the "ping" command shows the time without a space between > the label and the value. e.g.: > > 20 bytes from 192.168.0.1 : icmp_seq=1 ttl=1 time1~2ms > > Improve the readability and consistency by adding an equals sign for the time > value: > > 20 bytes from 192.168.0.1 : icmp_seq=1 ttl=1 time=1~2ms > > Signed-off-by: Rebecca Cran <rebecca@quicinc.com> > --- > > ShellPkg/Library/UefiShellNetwork1CommandsLib/UefiShellNetwork1Comm > andsLib.uni | 2 +- > ShellPkg/Library/UefiShellNetwork2CommandsLib/UefiShellNetwork2Comm > andsLib.uni | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git > a/ShellPkg/Library/UefiShellNetwork1CommandsLib/UefiShellNetwork1Com > mandsLib.uni > b/ShellPkg/Library/UefiShellNetwork1CommandsLib/UefiShellNetwork1Com > mandsLib.uni > index 73cf96d9e614..37fd4a11929c 100644 > --- > a/ShellPkg/Library/UefiShellNetwork1CommandsLib/UefiShellNetwork1Com > mandsLib.uni > +++ > b/ShellPkg/Library/UefiShellNetwork1CommandsLib/UefiShellNetwork1Com > +++ mandsLib.uni > @@ -52,7 +52,7 @@ > #string STR_PING_NOROUTE_FOUND #language en-US "There is no > route to the destination '%B%s%N' from the source '%B%s%N' was > found.\r\n" > #string STR_PING_START #language en-US "Ping %s %d data > bytes.\r\n" > #string STR_PING_TIMEOUT #language en-US "Echo request > sequence %d timeout.\r\n" > -#string STR_PING_REPLY_INFO #language en-US "%d bytes from %s : > icmp_seq=%d ttl=%d time%d~%dms\r\n" > +#string STR_PING_REPLY_INFO #language en-US "%d bytes from %s : > icmp_seq=%d ttl=%d time=%d~%dms\r\n" > #string STR_PING_STAT #language en-US "\n%d packets > transmitted, %d received, %d%% packet loss, time %dms\r\n" > #string STR_PING_RTT #language en-US "\nRtt(round trip time) > min=%d~%dms max=%d~%dms avg=%d~%dms\r\n" > > diff --git > a/ShellPkg/Library/UefiShellNetwork2CommandsLib/UefiShellNetwork2Com > mandsLib.uni > b/ShellPkg/Library/UefiShellNetwork2CommandsLib/UefiShellNetwork2Com > mandsLib.uni > index 30913ae5b583..cb9d39a33fbe 100644 > --- > a/ShellPkg/Library/UefiShellNetwork2CommandsLib/UefiShellNetwork2Com > mandsLib.uni > +++ > b/ShellPkg/Library/UefiShellNetwork2CommandsLib/UefiShellNetwork2Com > +++ mandsLib.uni > @@ -33,7 +33,7 @@ > #string STR_PING6_NOSOURCE_INDOMAIN #language en-US "No > sources in %s's multicast domain.\r\n" > #string STR_PING6_START #language en-US "Ping %s %d data > bytes\r\n" > #string STR_PING6_TIMEOUT #language en-US "Echo request > sequence %d timeout.\r\n" > -#string STR_PING6_REPLY_INFO #language en-US "%d bytes > from %s : icmp_seq=%d ttl=%d time%d~%dms\r\n" > +#string STR_PING6_REPLY_INFO #language en-US "%d bytes > from %s : icmp_seq=%d ttl=%d time=%d~%dms\r\n" > #string STR_PING6_STAT #language en-US "\n%d packets > transmitted, %d received, %d%% packet loss, time %dms\r\n" > #string STR_PING6_RTT #language en-US "\nRtt(round trip time) > min=%d~%dms max=%d~%dms avg=%d~%dms\r\n" > > -- > 2.30.2 > > > > > ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [edk2-devel] [PATCH 1/1] ShellPkg: Improve "ping" output by adding equals sign after time 2022-12-06 2:17 ` [edk2-devel] " Gao, Zhichao @ 2023-02-21 0:45 ` Rebecca Cran 2023-02-21 13:58 ` Gao, Zhichao 0 siblings, 1 reply; 6+ messages in thread From: Rebecca Cran @ 2023-02-21 0:45 UTC (permalink / raw) To: Gao, Zhichao, devel@edk2.groups.io, Ni, Ray Could someone commit this please? On 12/5/22 19:17, Gao, Zhichao wrote: > Reviewed-by: Zhichao Gao <zhichao.gao@intel.com> > > Thanks, > Zhichao > >> -----Original Message----- >> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Rebecca >> Cran >> Sent: Friday, December 2, 2022 5:50 AM >> To: devel@edk2.groups.io; Ni, Ray <ray.ni@intel.com>; Gao, Zhichao >> <zhichao.gao@intel.com> >> Cc: Rebecca Cran <rebecca@quicinc.com> >> Subject: [edk2-devel] [PATCH 1/1] ShellPkg: Improve "ping" output by adding >> equals sign after time >> >> The output of the "ping" command shows the time without a space between >> the label and the value. e.g.: >> >> 20 bytes from 192.168.0.1 : icmp_seq=1 ttl=1 time1~2ms >> >> Improve the readability and consistency by adding an equals sign for the time >> value: >> >> 20 bytes from 192.168.0.1 : icmp_seq=1 ttl=1 time=1~2ms >> >> Signed-off-by: Rebecca Cran <rebecca@quicinc.com> >> --- >> >> ShellPkg/Library/UefiShellNetwork1CommandsLib/UefiShellNetwork1Comm >> andsLib.uni | 2 +- >> ShellPkg/Library/UefiShellNetwork2CommandsLib/UefiShellNetwork2Comm >> andsLib.uni | 2 +- >> 2 files changed, 2 insertions(+), 2 deletions(-) >> >> diff --git >> a/ShellPkg/Library/UefiShellNetwork1CommandsLib/UefiShellNetwork1Com >> mandsLib.uni >> b/ShellPkg/Library/UefiShellNetwork1CommandsLib/UefiShellNetwork1Com >> mandsLib.uni >> index 73cf96d9e614..37fd4a11929c 100644 >> --- >> a/ShellPkg/Library/UefiShellNetwork1CommandsLib/UefiShellNetwork1Com >> mandsLib.uni >> +++ >> b/ShellPkg/Library/UefiShellNetwork1CommandsLib/UefiShellNetwork1Com >> +++ mandsLib.uni >> @@ -52,7 +52,7 @@ >> #string STR_PING_NOROUTE_FOUND #language en-US "There is no >> route to the destination '%B%s%N' from the source '%B%s%N' was >> found.\r\n" >> #string STR_PING_START #language en-US "Ping %s %d data >> bytes.\r\n" >> #string STR_PING_TIMEOUT #language en-US "Echo request >> sequence %d timeout.\r\n" >> -#string STR_PING_REPLY_INFO #language en-US "%d bytes from %s : >> icmp_seq=%d ttl=%d time%d~%dms\r\n" >> +#string STR_PING_REPLY_INFO #language en-US "%d bytes from %s : >> icmp_seq=%d ttl=%d time=%d~%dms\r\n" >> #string STR_PING_STAT #language en-US "\n%d packets >> transmitted, %d received, %d%% packet loss, time %dms\r\n" >> #string STR_PING_RTT #language en-US "\nRtt(round trip time) >> min=%d~%dms max=%d~%dms avg=%d~%dms\r\n" >> >> diff --git >> a/ShellPkg/Library/UefiShellNetwork2CommandsLib/UefiShellNetwork2Com >> mandsLib.uni >> b/ShellPkg/Library/UefiShellNetwork2CommandsLib/UefiShellNetwork2Com >> mandsLib.uni >> index 30913ae5b583..cb9d39a33fbe 100644 >> --- >> a/ShellPkg/Library/UefiShellNetwork2CommandsLib/UefiShellNetwork2Com >> mandsLib.uni >> +++ >> b/ShellPkg/Library/UefiShellNetwork2CommandsLib/UefiShellNetwork2Com >> +++ mandsLib.uni >> @@ -33,7 +33,7 @@ >> #string STR_PING6_NOSOURCE_INDOMAIN #language en-US "No >> sources in %s's multicast domain.\r\n" >> #string STR_PING6_START #language en-US "Ping %s %d data >> bytes\r\n" >> #string STR_PING6_TIMEOUT #language en-US "Echo request >> sequence %d timeout.\r\n" >> -#string STR_PING6_REPLY_INFO #language en-US "%d bytes >> from %s : icmp_seq=%d ttl=%d time%d~%dms\r\n" >> +#string STR_PING6_REPLY_INFO #language en-US "%d bytes >> from %s : icmp_seq=%d ttl=%d time=%d~%dms\r\n" >> #string STR_PING6_STAT #language en-US "\n%d packets >> transmitted, %d received, %d%% packet loss, time %dms\r\n" >> #string STR_PING6_RTT #language en-US "\nRtt(round trip time) >> min=%d~%dms max=%d~%dms avg=%d~%dms\r\n" >> >> -- >> 2.30.2 >> >> >> >> >> > ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [edk2-devel] [PATCH 1/1] ShellPkg: Improve "ping" output by adding equals sign after time 2023-02-21 0:45 ` Rebecca Cran @ 2023-02-21 13:58 ` Gao, Zhichao 2023-02-21 14:39 ` Ard Biesheuvel 0 siblings, 1 reply; 6+ messages in thread From: Gao, Zhichao @ 2023-02-21 13:58 UTC (permalink / raw) To: Rebecca Cran, devel@edk2.groups.io, Ni, Ray Sorry, I forgot this patch. Now it is the hard freeze for edk2. Would create the PR after edk2 202302 release. Thanks, Zhichao > -----Original Message----- > From: Rebecca Cran <rebecca@quicinc.com> > Sent: Tuesday, February 21, 2023 8:45 AM > To: Gao, Zhichao <zhichao.gao@intel.com>; devel@edk2.groups.io; Ni, Ray > <ray.ni@intel.com> > Subject: Re: [edk2-devel] [PATCH 1/1] ShellPkg: Improve "ping" output by > adding equals sign after time > > Could someone commit this please? > > On 12/5/22 19:17, Gao, Zhichao wrote: > > Reviewed-by: Zhichao Gao <zhichao.gao@intel.com> > > > > Thanks, > > Zhichao > > > >> -----Original Message----- > >> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of > >> Rebecca Cran > >> Sent: Friday, December 2, 2022 5:50 AM > >> To: devel@edk2.groups.io; Ni, Ray <ray.ni@intel.com>; Gao, Zhichao > >> <zhichao.gao@intel.com> > >> Cc: Rebecca Cran <rebecca@quicinc.com> > >> Subject: [edk2-devel] [PATCH 1/1] ShellPkg: Improve "ping" output by > >> adding equals sign after time > >> > >> The output of the "ping" command shows the time without a space > >> between the label and the value. e.g.: > >> > >> 20 bytes from 192.168.0.1 : icmp_seq=1 ttl=1 time1~2ms > >> > >> Improve the readability and consistency by adding an equals sign for > >> the time > >> value: > >> > >> 20 bytes from 192.168.0.1 : icmp_seq=1 ttl=1 time=1~2ms > >> > >> Signed-off-by: Rebecca Cran <rebecca@quicinc.com> > >> --- > >> > >> > ShellPkg/Library/UefiShellNetwork1CommandsLib/UefiShellNetwork1Comm > >> andsLib.uni | 2 +- > >> > ShellPkg/Library/UefiShellNetwork2CommandsLib/UefiShellNetwork2Comm > >> andsLib.uni | 2 +- > >> 2 files changed, 2 insertions(+), 2 deletions(-) > >> > >> diff --git > >> > a/ShellPkg/Library/UefiShellNetwork1CommandsLib/UefiShellNetwork1Com > >> mandsLib.uni > >> > b/ShellPkg/Library/UefiShellNetwork1CommandsLib/UefiShellNetwork1Com > >> mandsLib.uni > >> index 73cf96d9e614..37fd4a11929c 100644 > >> --- > >> > a/ShellPkg/Library/UefiShellNetwork1CommandsLib/UefiShellNetwork1Com > >> mandsLib.uni > >> +++ > >> > b/ShellPkg/Library/UefiShellNetwork1CommandsLib/UefiShellNetwork1Com > >> +++ mandsLib.uni > >> @@ -52,7 +52,7 @@ > >> #string STR_PING_NOROUTE_FOUND #language en-US "There is no > >> route to the destination '%B%s%N' from the source '%B%s%N' was > >> found.\r\n" > >> #string STR_PING_START #language en-US "Ping %s %d data > >> bytes.\r\n" > >> #string STR_PING_TIMEOUT #language en-US "Echo request > >> sequence %d timeout.\r\n" > >> -#string STR_PING_REPLY_INFO #language en-US "%d bytes from %s : > >> icmp_seq=%d ttl=%d time%d~%dms\r\n" > >> +#string STR_PING_REPLY_INFO #language en-US "%d bytes > from %s : > >> icmp_seq=%d ttl=%d time=%d~%dms\r\n" > >> #string STR_PING_STAT #language en-US "\n%d packets > >> transmitted, %d received, %d%% packet loss, time %dms\r\n" > >> #string STR_PING_RTT #language en-US "\nRtt(round trip time) > >> min=%d~%dms max=%d~%dms avg=%d~%dms\r\n" > >> > >> diff --git > >> > a/ShellPkg/Library/UefiShellNetwork2CommandsLib/UefiShellNetwork2Com > >> mandsLib.uni > >> > b/ShellPkg/Library/UefiShellNetwork2CommandsLib/UefiShellNetwork2Com > >> mandsLib.uni > >> index 30913ae5b583..cb9d39a33fbe 100644 > >> --- > >> > a/ShellPkg/Library/UefiShellNetwork2CommandsLib/UefiShellNetwork2Com > >> mandsLib.uni > >> +++ > >> > b/ShellPkg/Library/UefiShellNetwork2CommandsLib/UefiShellNetwork2Com > >> +++ mandsLib.uni > >> @@ -33,7 +33,7 @@ > >> #string STR_PING6_NOSOURCE_INDOMAIN #language en-US "No > >> sources in %s's multicast domain.\r\n" > >> #string STR_PING6_START #language en-US "Ping %s %d data > >> bytes\r\n" > >> #string STR_PING6_TIMEOUT #language en-US "Echo request > >> sequence %d timeout.\r\n" > >> -#string STR_PING6_REPLY_INFO #language en-US "%d bytes > >> from %s : icmp_seq=%d ttl=%d time%d~%dms\r\n" > >> +#string STR_PING6_REPLY_INFO #language en-US "%d bytes > >> from %s : icmp_seq=%d ttl=%d time=%d~%dms\r\n" > >> #string STR_PING6_STAT #language en-US "\n%d packets > >> transmitted, %d received, %d%% packet loss, time %dms\r\n" > >> #string STR_PING6_RTT #language en-US "\nRtt(round trip > time) > >> min=%d~%dms max=%d~%dms avg=%d~%dms\r\n" > >> > >> -- > >> 2.30.2 > >> > >> > >> > >> > >> > > ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [edk2-devel] [PATCH 1/1] ShellPkg: Improve "ping" output by adding equals sign after time 2023-02-21 13:58 ` Gao, Zhichao @ 2023-02-21 14:39 ` Ard Biesheuvel 2023-02-21 19:02 ` Michael D Kinney 0 siblings, 1 reply; 6+ messages in thread From: Ard Biesheuvel @ 2023-02-21 14:39 UTC (permalink / raw) To: devel, zhichao.gao; +Cc: Rebecca Cran, Ni, Ray On Tue, 21 Feb 2023 at 14:58, Gao, Zhichao <zhichao.gao@intel.com> wrote: > > Sorry, I forgot this patch. Now it is the hard freeze for edk2. Would create the PR after edk2 202302 release. > The hard freeze has been deferred until early march, so you can go ahead and merge this patch. -- Ard. > > -----Original Message----- > > From: Rebecca Cran <rebecca@quicinc.com> > > Sent: Tuesday, February 21, 2023 8:45 AM > > To: Gao, Zhichao <zhichao.gao@intel.com>; devel@edk2.groups.io; Ni, Ray > > <ray.ni@intel.com> > > Subject: Re: [edk2-devel] [PATCH 1/1] ShellPkg: Improve "ping" output by > > adding equals sign after time > > > > Could someone commit this please? > > > > On 12/5/22 19:17, Gao, Zhichao wrote: > > > Reviewed-by: Zhichao Gao <zhichao.gao@intel.com> > > > > > > Thanks, > > > Zhichao > > > > > >> -----Original Message----- > > >> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of > > >> Rebecca Cran > > >> Sent: Friday, December 2, 2022 5:50 AM > > >> To: devel@edk2.groups.io; Ni, Ray <ray.ni@intel.com>; Gao, Zhichao > > >> <zhichao.gao@intel.com> > > >> Cc: Rebecca Cran <rebecca@quicinc.com> > > >> Subject: [edk2-devel] [PATCH 1/1] ShellPkg: Improve "ping" output by > > >> adding equals sign after time > > >> > > >> The output of the "ping" command shows the time without a space > > >> between the label and the value. e.g.: > > >> > > >> 20 bytes from 192.168.0.1 : icmp_seq=1 ttl=1 time1~2ms > > >> > > >> Improve the readability and consistency by adding an equals sign for > > >> the time > > >> value: > > >> > > >> 20 bytes from 192.168.0.1 : icmp_seq=1 ttl=1 time=1~2ms > > >> > > >> Signed-off-by: Rebecca Cran <rebecca@quicinc.com> > > >> --- > > >> > > >> > > ShellPkg/Library/UefiShellNetwork1CommandsLib/UefiShellNetwork1Comm > > >> andsLib.uni | 2 +- > > >> > > ShellPkg/Library/UefiShellNetwork2CommandsLib/UefiShellNetwork2Comm > > >> andsLib.uni | 2 +- > > >> 2 files changed, 2 insertions(+), 2 deletions(-) > > >> > > >> diff --git > > >> > > a/ShellPkg/Library/UefiShellNetwork1CommandsLib/UefiShellNetwork1Com > > >> mandsLib.uni > > >> > > b/ShellPkg/Library/UefiShellNetwork1CommandsLib/UefiShellNetwork1Com > > >> mandsLib.uni > > >> index 73cf96d9e614..37fd4a11929c 100644 > > >> --- > > >> > > a/ShellPkg/Library/UefiShellNetwork1CommandsLib/UefiShellNetwork1Com > > >> mandsLib.uni > > >> +++ > > >> > > b/ShellPkg/Library/UefiShellNetwork1CommandsLib/UefiShellNetwork1Com > > >> +++ mandsLib.uni > > >> @@ -52,7 +52,7 @@ > > >> #string STR_PING_NOROUTE_FOUND #language en-US "There is no > > >> route to the destination '%B%s%N' from the source '%B%s%N' was > > >> found.\r\n" > > >> #string STR_PING_START #language en-US "Ping %s %d data > > >> bytes.\r\n" > > >> #string STR_PING_TIMEOUT #language en-US "Echo request > > >> sequence %d timeout.\r\n" > > >> -#string STR_PING_REPLY_INFO #language en-US "%d bytes from %s : > > >> icmp_seq=%d ttl=%d time%d~%dms\r\n" > > >> +#string STR_PING_REPLY_INFO #language en-US "%d bytes > > from %s : > > >> icmp_seq=%d ttl=%d time=%d~%dms\r\n" > > >> #string STR_PING_STAT #language en-US "\n%d packets > > >> transmitted, %d received, %d%% packet loss, time %dms\r\n" > > >> #string STR_PING_RTT #language en-US "\nRtt(round trip time) > > >> min=%d~%dms max=%d~%dms avg=%d~%dms\r\n" > > >> > > >> diff --git > > >> > > a/ShellPkg/Library/UefiShellNetwork2CommandsLib/UefiShellNetwork2Com > > >> mandsLib.uni > > >> > > b/ShellPkg/Library/UefiShellNetwork2CommandsLib/UefiShellNetwork2Com > > >> mandsLib.uni > > >> index 30913ae5b583..cb9d39a33fbe 100644 > > >> --- > > >> > > a/ShellPkg/Library/UefiShellNetwork2CommandsLib/UefiShellNetwork2Com > > >> mandsLib.uni > > >> +++ > > >> > > b/ShellPkg/Library/UefiShellNetwork2CommandsLib/UefiShellNetwork2Com > > >> +++ mandsLib.uni > > >> @@ -33,7 +33,7 @@ > > >> #string STR_PING6_NOSOURCE_INDOMAIN #language en-US "No > > >> sources in %s's multicast domain.\r\n" > > >> #string STR_PING6_START #language en-US "Ping %s %d data > > >> bytes\r\n" > > >> #string STR_PING6_TIMEOUT #language en-US "Echo request > > >> sequence %d timeout.\r\n" > > >> -#string STR_PING6_REPLY_INFO #language en-US "%d bytes > > >> from %s : icmp_seq=%d ttl=%d time%d~%dms\r\n" > > >> +#string STR_PING6_REPLY_INFO #language en-US "%d bytes > > >> from %s : icmp_seq=%d ttl=%d time=%d~%dms\r\n" > > >> #string STR_PING6_STAT #language en-US "\n%d packets > > >> transmitted, %d received, %d%% packet loss, time %dms\r\n" > > >> #string STR_PING6_RTT #language en-US "\nRtt(round trip > > time) > > >> min=%d~%dms max=%d~%dms avg=%d~%dms\r\n" > > >> > > >> -- > > >> 2.30.2 > > >> > > >> > > >> > > >> > > >> > > > > > > > > ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [edk2-devel] [PATCH 1/1] ShellPkg: Improve "ping" output by adding equals sign after time 2023-02-21 14:39 ` Ard Biesheuvel @ 2023-02-21 19:02 ` Michael D Kinney 0 siblings, 0 replies; 6+ messages in thread From: Michael D Kinney @ 2023-02-21 19:02 UTC (permalink / raw) To: devel@edk2.groups.io, ardb@kernel.org, Gao, Zhichao Cc: Rebecca Cran, Ni, Ray, Kinney, Michael D Hi Ard, There have been some communication issues on status with Liming. Miki and I think those are resolved now. We are wanting to move to hard freeze ASAP to keep as close as possible to the original planned release date. We will discuss with Liming when he is back online later today. I recommend holding off on merging any non-critical changes until there is updated status from Liming. Thanks, Mike > -----Original Message----- > From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Ard Biesheuvel > Sent: Tuesday, February 21, 2023 6:40 AM > To: devel@edk2.groups.io; Gao, Zhichao <zhichao.gao@intel.com> > Cc: Rebecca Cran <rebecca@quicinc.com>; Ni, Ray <ray.ni@intel.com> > Subject: Re: [edk2-devel] [PATCH 1/1] ShellPkg: Improve "ping" output by adding equals sign after time > > On Tue, 21 Feb 2023 at 14:58, Gao, Zhichao <zhichao.gao@intel.com> wrote: > > > > Sorry, I forgot this patch. Now it is the hard freeze for edk2. Would create the PR after edk2 202302 release. > > > > The hard freeze has been deferred until early march, so you can go > ahead and merge this patch. > > -- > Ard. > > > > -----Original Message----- > > > From: Rebecca Cran <rebecca@quicinc.com> > > > Sent: Tuesday, February 21, 2023 8:45 AM > > > To: Gao, Zhichao <zhichao.gao@intel.com>; devel@edk2.groups.io; Ni, Ray > > > <ray.ni@intel.com> > > > Subject: Re: [edk2-devel] [PATCH 1/1] ShellPkg: Improve "ping" output by > > > adding equals sign after time > > > > > > Could someone commit this please? > > > > > > On 12/5/22 19:17, Gao, Zhichao wrote: > > > > Reviewed-by: Zhichao Gao <zhichao.gao@intel.com> > > > > > > > > Thanks, > > > > Zhichao > > > > > > > >> -----Original Message----- > > > >> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of > > > >> Rebecca Cran > > > >> Sent: Friday, December 2, 2022 5:50 AM > > > >> To: devel@edk2.groups.io; Ni, Ray <ray.ni@intel.com>; Gao, Zhichao > > > >> <zhichao.gao@intel.com> > > > >> Cc: Rebecca Cran <rebecca@quicinc.com> > > > >> Subject: [edk2-devel] [PATCH 1/1] ShellPkg: Improve "ping" output by > > > >> adding equals sign after time > > > >> > > > >> The output of the "ping" command shows the time without a space > > > >> between the label and the value. e.g.: > > > >> > > > >> 20 bytes from 192.168.0.1 : icmp_seq=1 ttl=1 time1~2ms > > > >> > > > >> Improve the readability and consistency by adding an equals sign for > > > >> the time > > > >> value: > > > >> > > > >> 20 bytes from 192.168.0.1 : icmp_seq=1 ttl=1 time=1~2ms > > > >> > > > >> Signed-off-by: Rebecca Cran <rebecca@quicinc.com> > > > >> --- > > > >> > > > >> > > > ShellPkg/Library/UefiShellNetwork1CommandsLib/UefiShellNetwork1Comm > > > >> andsLib.uni | 2 +- > > > >> > > > ShellPkg/Library/UefiShellNetwork2CommandsLib/UefiShellNetwork2Comm > > > >> andsLib.uni | 2 +- > > > >> 2 files changed, 2 insertions(+), 2 deletions(-) > > > >> > > > >> diff --git > > > >> > > > a/ShellPkg/Library/UefiShellNetwork1CommandsLib/UefiShellNetwork1Com > > > >> mandsLib.uni > > > >> > > > b/ShellPkg/Library/UefiShellNetwork1CommandsLib/UefiShellNetwork1Com > > > >> mandsLib.uni > > > >> index 73cf96d9e614..37fd4a11929c 100644 > > > >> --- > > > >> > > > a/ShellPkg/Library/UefiShellNetwork1CommandsLib/UefiShellNetwork1Com > > > >> mandsLib.uni > > > >> +++ > > > >> > > > b/ShellPkg/Library/UefiShellNetwork1CommandsLib/UefiShellNetwork1Com > > > >> +++ mandsLib.uni > > > >> @@ -52,7 +52,7 @@ > > > >> #string STR_PING_NOROUTE_FOUND #language en-US "There is no > > > >> route to the destination '%B%s%N' from the source '%B%s%N' was > > > >> found.\r\n" > > > >> #string STR_PING_START #language en-US "Ping %s %d data > > > >> bytes.\r\n" > > > >> #string STR_PING_TIMEOUT #language en-US "Echo request > > > >> sequence %d timeout.\r\n" > > > >> -#string STR_PING_REPLY_INFO #language en-US "%d bytes from %s : > > > >> icmp_seq=%d ttl=%d time%d~%dms\r\n" > > > >> +#string STR_PING_REPLY_INFO #language en-US "%d bytes > > > from %s : > > > >> icmp_seq=%d ttl=%d time=%d~%dms\r\n" > > > >> #string STR_PING_STAT #language en-US "\n%d packets > > > >> transmitted, %d received, %d%% packet loss, time %dms\r\n" > > > >> #string STR_PING_RTT #language en-US "\nRtt(round trip time) > > > >> min=%d~%dms max=%d~%dms avg=%d~%dms\r\n" > > > >> > > > >> diff --git > > > >> > > > a/ShellPkg/Library/UefiShellNetwork2CommandsLib/UefiShellNetwork2Com > > > >> mandsLib.uni > > > >> > > > b/ShellPkg/Library/UefiShellNetwork2CommandsLib/UefiShellNetwork2Com > > > >> mandsLib.uni > > > >> index 30913ae5b583..cb9d39a33fbe 100644 > > > >> --- > > > >> > > > a/ShellPkg/Library/UefiShellNetwork2CommandsLib/UefiShellNetwork2Com > > > >> mandsLib.uni > > > >> +++ > > > >> > > > b/ShellPkg/Library/UefiShellNetwork2CommandsLib/UefiShellNetwork2Com > > > >> +++ mandsLib.uni > > > >> @@ -33,7 +33,7 @@ > > > >> #string STR_PING6_NOSOURCE_INDOMAIN #language en-US "No > > > >> sources in %s's multicast domain.\r\n" > > > >> #string STR_PING6_START #language en-US "Ping %s %d data > > > >> bytes\r\n" > > > >> #string STR_PING6_TIMEOUT #language en-US "Echo request > > > >> sequence %d timeout.\r\n" > > > >> -#string STR_PING6_REPLY_INFO #language en-US "%d bytes > > > >> from %s : icmp_seq=%d ttl=%d time%d~%dms\r\n" > > > >> +#string STR_PING6_REPLY_INFO #language en-US "%d bytes > > > >> from %s : icmp_seq=%d ttl=%d time=%d~%dms\r\n" > > > >> #string STR_PING6_STAT #language en-US "\n%d packets > > > >> transmitted, %d received, %d%% packet loss, time %dms\r\n" > > > >> #string STR_PING6_RTT #language en-US "\nRtt(round trip > > > time) > > > >> min=%d~%dms max=%d~%dms avg=%d~%dms\r\n" > > > >> > > > >> -- > > > >> 2.30.2 > > > >> > > > >> > > > >> > > > >> > > > >> > > > > > > > > > > > > > > > > > > ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2023-02-21 19:03 UTC | newest] Thread overview: 6+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2022-12-01 21:49 [PATCH 1/1] ShellPkg: Improve "ping" output by adding equals sign after time Rebecca Cran 2022-12-06 2:17 ` [edk2-devel] " Gao, Zhichao 2023-02-21 0:45 ` Rebecca Cran 2023-02-21 13:58 ` Gao, Zhichao 2023-02-21 14:39 ` Ard Biesheuvel 2023-02-21 19:02 ` Michael D Kinney
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox