From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.groups.io with SMTP id smtpd.web10.74419.1669986619764409664 for ; Fri, 02 Dec 2022 05:10:19 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=HVcFnH+2; spf=pass (domain: redhat.com, ip: 170.10.133.124, mailfrom: kraxel@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1669986618; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=HaGnAuF3wr7nuWrq0AVcXCMFZfX8jxh+EonZkK2CJ1o=; b=HVcFnH+2xFD1AQJz7DkW3jFPHgTfdH+I64Er3o0BbSB8yruAuEGza2SJTiJZL5g7rKq10X PAVsCNoajEg9BjCziUMFeKr+m6exDoBn2Fo43suC80nCFP+sIu/NLD6IWiFOql5H0HBqH7 skfa8S/D+XAHSE9u0kEBalBz1EZJp6E= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-26-2vUhYnbePduaOA58LIngEg-1; Fri, 02 Dec 2022 08:10:16 -0500 X-MC-Unique: 2vUhYnbePduaOA58LIngEg-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 539B786EB20; Fri, 2 Dec 2022 13:10:15 +0000 (UTC) Received: from sirius.home.kraxel.org (unknown [10.39.192.79]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 1890A111E3FF; Fri, 2 Dec 2022 13:10:13 +0000 (UTC) Received: by sirius.home.kraxel.org (Postfix, from userid 1000) id C791A180127A; Fri, 2 Dec 2022 14:10:09 +0100 (CET) From: "Gerd Hoffmann" To: devel@edk2.groups.io Cc: Bob Feng , Yuwei Chen , Erdem Aktas , Jordan Justen , Peter Grehan , Rebecca Cran , Liming Gao , Ard Biesheuvel , Gerd Hoffmann , Jiewen Yao , Min Xu , Brijesh Singh , Oliver Steffen , Pawel Polawski , Tom Lendacky , James Bottomley Subject: [PATCH 00/14] OvmfPkg: avoid global variables in PEI Date: Fri, 2 Dec 2022 14:09:55 +0100 Message-Id: <20221202131009.3190040-1-kraxel@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.3 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Writing to global variables changes the PEI firmware volume which in turn screws up firmware volume measurements. Fix OvmfPkg to avoid that, for the most part by using the PlatformInfoHob instead. Gerd Hoffmann (14): tools_def: remove GCC_IA32_CC_FLAGS/GCC_X64_CC_FLAGS tools_def: add -fno-omit-frame-pointer to GCC48_{IA32,X64}_CC_FLAGS OvmfPkg/PlatformPei: AmdSev: stop using mPlatformInfoHob OvmfPkg/PlatformPei: PeiFv: stop using mPlatformInfoHob OvmfPkg/PlatformPei Q35 SMM helpers: stop using mPlatformInfoHob OvmfPkg/PlatformPei: PeiMemory: stop using mPlatformInfoHob OvmfPkg/PlatformPei: MemTypeInfo: stop using mPlatformInfoHob OvmfPkg/PlatformPei: NoExec: stop using mPlatformInfoHob OvmfPkg/PlatformPei: Verification: stop using mPlatformInfoHob OvmfPkg/PlatformPei: remove mPlatformInfoHob OvmfPkg/PlatformPei: remove mFeatureControlValue OvmfPkg/DebugLibIoPort: use Rom version for PEI OvmfPkg/QemuFwCfgLib: rewrite fw_cfg probe OvmfPkg/QemuFwCfgLib: remove mQemuFwCfgSupported + mQemuFwCfgDmaSupported OvmfPkg/AmdSev/AmdSevX64.dsc | 4 +- OvmfPkg/Bhyve/BhyveX64.dsc | 4 +- OvmfPkg/Microvm/MicrovmX64.dsc | 4 +- OvmfPkg/OvmfPkgIa32.dsc | 4 +- OvmfPkg/OvmfPkgIa32X64.dsc | 4 +- OvmfPkg/OvmfPkgX64.dsc | 4 +- .../PlatformRomDebugLibIoPort.inf | 2 +- .../Library/QemuFwCfgLib/QemuFwCfgPeiLib.inf | 5 +- OvmfPkg/Include/Library/PlatformInitLib.h | 6 + OvmfPkg/PlatformPei/Platform.h | 18 +-- OvmfPkg/Library/QemuFwCfgLib/QemuFwCfgPei.c | 143 ++++++++++-------- OvmfPkg/PlatformPei/AmdSev.c | 14 +- OvmfPkg/PlatformPei/FeatureControl.c | 44 ++++-- OvmfPkg/PlatformPei/Fv.c | 6 +- OvmfPkg/PlatformPei/MemDetect.c | 56 +++---- OvmfPkg/PlatformPei/MemTypeInfo.c | 4 +- OvmfPkg/PlatformPei/Platform.c | 92 ++++++----- BaseTools/Conf/tools_def.template | 6 +- 18 files changed, 232 insertions(+), 188 deletions(-) -- 2.38.1