public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Rebecca Cran" <quic_rcran@quicinc.com>
To: <devel@edk2.groups.io>, Liming Gao <gaoliming@byosoft.com.cn>,
	Ray Ni <ray.ni@intel.com>, J Wang <jian.j.wang@intel.com>,
	Hao Wu <hao.a.wu@intel.com>
Cc: Rebecca Cran <rebecca@quicinc.com>
Subject: [PATCH v2 0/1] MdeModulePkg: Put USB DEBUGs that occur for bulk timeouts under VERBOSE
Date: Tue, 6 Dec 2022 07:30:38 -0700	[thread overview]
Message-ID: <20221206143039.278566-1-rebecca@quicinc.com> (raw)

*Changes between v1 and v2*

Only switch to DEBUG_VERBOSE for EFI_TIMEOUT errors.

Test Pull Request:  https://github.com/tianocore/edk2/pull/3705

---

MdeModulePkg: Put USB DEBUGs that occur for bulk timeouts under VERBOSE
   
With the pending commit of UsbNetworkPkg, it will become common for
UsbBulkTransfer calls to timeout, given that the drivers are called from
MnpSystemPoll every MNP_SYS_POLL_INTERVAL milliseconds: the drivers
check for network packets by calling UsbBulkTransfer with a timeout of
1ms.
    
Avoid console spam by moving DEBUG messages that occur each time a bulk
transfer request times out from DEBUG_ERROR to DEBUG_VERBOSE, for both
EHCI and XHCI drivers.

Rebecca Cran (1):
  MdeModulePkg: Put USB DEBUGs that occur for bulk timeouts under
    VERBOSE

 MdeModulePkg/Bus/Pci/EhciDxe/Ehci.c      | 9 ++++++++-
 MdeModulePkg/Bus/Pci/EhciDxe/EhciSched.c | 2 +-
 MdeModulePkg/Bus/Pci/XhciDxe/Xhci.c      | 9 ++++++++-
 MdeModulePkg/Bus/Pci/XhciDxe/XhciSched.c | 6 +++---
 4 files changed, 20 insertions(+), 6 deletions(-)

-- 
2.30.2


             reply	other threads:[~2022-12-06 14:31 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-06 14:30 Rebecca Cran [this message]
2022-12-06 14:30 ` [PATCH v2 1/1] MdeModulePkg: Put USB DEBUGs that occur for bulk timeouts under VERBOSE Rebecca Cran
2022-12-07  1:07   ` Wu, Hao A
2022-12-08  3:01     ` [edk2-devel] " Wu, Hao A

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221206143039.278566-1-rebecca@quicinc.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox