public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Gerd Hoffmann" <kraxel@redhat.com>
To: devel@edk2.groups.io, mcb30@ipxe.org
Cc: Laszlo Ersek <lersek@redhat.com>,
	Paolo Bonzini <pbonzini@redhat.com>,
	Ard Biesheuvel <ardb@kernel.org>
Subject: Re: [edk2-devel] [PATCH 2/3] OvmfPkg: Add library to handle TPL from within nested interrupt handlers
Date: Fri, 9 Dec 2022 16:02:27 +0100	[thread overview]
Message-ID: <20221209150227.wns5mhtcfismxtgd@sirius.home.kraxel.org> (raw)
In-Reply-To: <01020184f66682f9-7696e0c5-f2f6-43e0-962f-38f1d5af4859-000000@eu-west-1.amazonses.com>

  Hi,

[ Cc'ing ard ]

> Add the Nested Interrupt TPL Library (NestedInterruptTplLib) to
> provide helper functions that can be used by nested interrupt handlers
> in place of RaiseTPL()/RestoreTPL().

So, in a nutshell this makes inner interrupt handler only run callbacks
with a priority higher than the priority of the outer interrupt handler.
Anything with equal or lower priority is deferred to the outer handler.
That way we never nest at the same priority, which in turn limits
nesting to the number of different priorities in use.

Correct?

The idea looks sane to me and I couldn't spot any logic errors in this.

take care,
  Gerd


  reply	other threads:[~2022-12-09 15:02 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <cover.1670328507.git.mcb30@ipxe.org>
2022-12-09 10:20 ` [PATCH 1/3] OvmfPkg: Send EOI before RestoreTPL() in timer interrupt handlers Michael Brown
2022-12-09 10:20 ` [PATCH 2/3] OvmfPkg: Add library to handle TPL from within nested " Michael Brown
2022-12-09 15:02   ` Gerd Hoffmann [this message]
2022-12-09 15:22     ` [edk2-devel] " Michael Brown
     [not found]     ` <ac60f07a-df27-bcfd-4129-0d6bfcf7ac77@ipxe.org>
2022-12-20 15:02       ` Michael Brown
2022-12-21  8:06         ` Laszlo Ersek
2022-12-23 14:25           ` Ard Biesheuvel
2022-12-09 10:20 ` [PATCH 3/3] OvmfPkg: Use NestedInterruptTplLib in " Michael Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221209150227.wns5mhtcfismxtgd@sirius.home.kraxel.org \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox