From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lf1-f48.google.com (mail-lf1-f48.google.com [209.85.167.48]) by mx.groups.io with SMTP id smtpd.web11.5561.1670602277630375568 for ; Fri, 09 Dec 2022 08:11:20 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@gmail.com header.s=20210112 header.b=Pwyj7Wh5; spf=pass (domain: gmail.com, ip: 209.85.167.48, mailfrom: savvamtr@gmail.com) Received: by mail-lf1-f48.google.com with SMTP id y25so7747341lfa.9 for ; Fri, 09 Dec 2022 08:11:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=AnVv7xND2ypq5+9BWYwoRyhhzmUQKZs9DOtn3Z5bKQQ=; b=Pwyj7Wh5zbWurZVoFO2NU0nldv42RVyu9c7kWS9iQ6neiz+kZXruDYninBvi9f9Gsp JzIHw74DvjB55APJjwaTHzS/TXE0knr5+Wk7BlrVTkxlQ+6rUTp2OgbDIDbloTMvUPM7 REAPk+Dc5hlxZ2lu8gv7qmUnpb7YnSE8Giiwb2WkPki/sa0MnB+kGcPi38ES2KbhldxX wV67OUD6SXQq2gj+lqekiweSvMxhQixiOjeBDlhoY95N/lOalRykCbvxZgQpDFqcNv2d 4UkpRyI+p5l/GQZJDGMIE0WswDOp/06zI5RV1XY7QYMpT0EAcz25cnEFpmCuJry+DTez /5kw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=AnVv7xND2ypq5+9BWYwoRyhhzmUQKZs9DOtn3Z5bKQQ=; b=J3onDZgSr/MOEpNN7HpzIQgdcQJU2OPtVHxI6QZr6eP1rDwKxu9ImIVUvx1vR1i1WL 5StqdB9Y0agIbXnAjr+j9aId8/vE+TtTYdXobNFZfRhZSVPENjbRDFyPViM7MtweYjIU MDOZ/4p5necj7Hi8E5dkmulwYjXwP1oq3n2VT/ARWwrsC2mSYdDcfmUURkc7Vzy36p+S 6oTJFg/6ZUsA9sQb8pamr0iyA09s/apUCcYkcnicd79jJ8bXKs4SZi7898+2AXWk/R+Z l/LMeIXolN8VgOrmzUu+gOjJUMJeQVylhUDNDU4VOXbm0bwsApnG80QaqbrJSi2ObJMm IoTA== X-Gm-Message-State: ANoB5pnLaGhHqNWX2UBhtr+kJBt4mbMnRB/pyIWwWqmp2wg9ONatktNk ccwzqR1PmD6BkSKAI5QluG1wgm264WHC5Q+8 X-Google-Smtp-Source: AA0mqf5+LQllDE0izuhlFXkJM6jtW/CG3G3d1WYwuLRE/N7mln2+J83m2RPg4Z9dzDP1HKqwEtfRmw== X-Received: by 2002:a05:6512:4024:b0:4b5:2aea:8f5e with SMTP id br36-20020a056512402400b004b52aea8f5emr2121012lfb.16.1670602279293; Fri, 09 Dec 2022 08:11:19 -0800 (PST) Return-Path: Received: from localhost.localdomain ([109.194.121.139]) by smtp.gmail.com with ESMTPSA id v5-20020a05651203a500b00492c663bba2sm318430lfp.124.2022.12.09.08.11.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 09 Dec 2022 08:11:18 -0800 (PST) From: "Savva Mitrofanov" To: devel@edk2.groups.io Cc: =?UTF-8?q?Marvin=20H=C3=A4user?= , Pedro Falcato , Vitaly Cheptsov Subject: [edk2-platforms][PATCH v1 05/12] Ext4Pkg: Fix division by zero by adding check for s_inodes_per_group Date: Fri, 9 Dec 2022 22:10:57 +0600 Message-Id: <20221209161104.70220-6-savvamtr@gmail.com> X-Mailer: git-send-email 2.38.1 In-Reply-To: <20221209161104.70220-1-savvamtr@gmail.com> References: <20221209161104.70220-1-savvamtr@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Superblock s_inodes_per_group field can't be zero, it leads to division by zero in BlockGroup routine Ext4ReadInode Cc: Marvin H=C3=A4user Cc: Pedro Falcato Cc: Vitaly Cheptsov Signed-off-by: Savva Mitrofanov --- Features/Ext4Pkg/Ext4Dxe/Superblock.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/Features/Ext4Pkg/Ext4Dxe/Superblock.c b/Features/Ext4Pkg/Ext4D= xe/Superblock.c index 4c662bd1784f..adaf475ea54d 100644 --- a/Features/Ext4Pkg/Ext4Dxe/Superblock.c +++ b/Features/Ext4Pkg/Ext4Dxe/Superblock.c @@ -243,6 +243,11 @@ Ext4OpenSuperblock ( =0D DEBUG ((DEBUG_FS, "Read only =3D %u\n", Partition->ReadOnly));=0D =0D + if (Sb->s_inodes_per_group =3D=3D 0) {=0D + DEBUG ((DEBUG_ERROR, "[ext4] Inodes per group can not be zero\n"));=0D + return EFI_VOLUME_CORRUPTED;=0D + }=0D +=0D Partition->BlockSize =3D (UINT32)LShiftU64 (1024, Sb->s_log_block_size);= =0D =0D // The size of a block group can also be calculated as 8 * Partition->Bl= ockSize=0D --=20 2.38.1