From: "Gerd Hoffmann" <kraxel@redhat.com>
To: devel@edk2.groups.io, thomas.lendacky@amd.com
Cc: Adam Dunlap <acdunlap@google.com>,
Ard Biesheuvel <ardb+tianocore@kernel.org>,
Jiewen Yao <jiewen.yao@intel.com>,
Jordan Justen <jordan.l.justen@intel.com>,
Brijesh Singh <brijesh.singh@amd.com>,
Erdem Aktas <erdemaktas@google.com>,
James Bottomley <jejb@linux.ibm.com>, Min Xu <min.m.xu@intel.com>,
Dionna Glaze <dionnaglaze@google.com>
Subject: Re: [edk2-devel] [PATCH v2] OvmfPkg/PlatformPei: Validate SEC's GHCB page
Date: Mon, 12 Dec 2022 07:51:11 +0100 [thread overview]
Message-ID: <20221212065111.tuzdlz7d4kojnhgp@sirius.home.kraxel.org> (raw)
In-Reply-To: <aa7579b8-df03-bfd5-1663-2850927db321@amd.com>
Hi,
> > + Status = MemEncryptSevSetPageEncMask (
> > + 0, // Cr3 -- use system Cr3
> > + FixedPcdGet32 (PcdOvmfSecGhcbBase),
> > + 1 // Number of pages
> > + );
>
> These arguments need to be aligned under the lower case "m", too.
Best way to deal with this and the other code style issues is to install
uncrustify locally and let it format the source code correctly.
take care,
Gerd
next prev parent reply other threads:[~2022-12-12 6:51 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-08 23:43 [PATCH] OvmfPkg/PlatformPei: Validate SEC's GHCB page acdunlap
2022-12-09 16:41 ` [edk2-devel] " Lendacky, Thomas
2022-12-09 18:58 ` [PATCH v2] " Adam Dunlap
2022-12-09 20:06 ` Lendacky, Thomas
2022-12-12 6:51 ` Gerd Hoffmann [this message]
2022-12-09 20:08 ` [edk2-devel] [PATCH] " Ard Biesheuvel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221212065111.tuzdlz7d4kojnhgp@sirius.home.kraxel.org \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox