From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124])
 by mx.groups.io with SMTP id smtpd.web10.37243.1670827879689395505
 for <devel@edk2.groups.io>;
 Sun, 11 Dec 2022 22:51:20 -0800
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=Ftaldv+b;
 spf=pass (domain: redhat.com, ip: 170.10.129.124, mailfrom: kraxel@redhat.com)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
	s=mimecast20190719; t=1670827878;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=rdGwMq++/SjVYQGspeXNm8pL4PWNtcee+IKTvrTdD/k=;
	b=Ftaldv+bgjhJvw7yzlFXWdc6R1d2TSwm41XdFnH33LXPcQGMmLZpGqRDyAbNbru5WPGxXh
	oABv0dyDTD7za6u1EKJNcqq6JZ4QvgK4/t4JzdDPyzrngyRHOKfv52MlKG/5CWR5dF17oS
	4he8A+WQKcdajmyddGSKL0CKiyMf5N4=
Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com
 [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS
 (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 us-mta-153-s8BQe7MYM7WazRAsFrawyg-1; Mon, 12 Dec 2022 01:51:15 -0500
X-MC-Unique: s8BQe7MYM7WazRAsFrawyg-1
Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6])
	(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by mimecast-mx02.redhat.com (Postfix) with ESMTPS id B7434185A78B;
	Mon, 12 Dec 2022 06:51:14 +0000 (UTC)
Received: from sirius.home.kraxel.org (unknown [10.39.192.83])
	by smtp.corp.redhat.com (Postfix) with ESMTPS id 812402166B26;
	Mon, 12 Dec 2022 06:51:14 +0000 (UTC)
Received: by sirius.home.kraxel.org (Postfix, from userid 1000)
	id 3422A1800913; Mon, 12 Dec 2022 07:51:11 +0100 (CET)
Date: Mon, 12 Dec 2022 07:51:11 +0100
From: "Gerd Hoffmann" <kraxel@redhat.com>
To: devel@edk2.groups.io, thomas.lendacky@amd.com
Cc: Adam Dunlap <acdunlap@google.com>,
	Ard Biesheuvel <ardb+tianocore@kernel.org>,
	Jiewen Yao <jiewen.yao@intel.com>,
	Jordan Justen <jordan.l.justen@intel.com>,
	Brijesh Singh <brijesh.singh@amd.com>,
	Erdem Aktas <erdemaktas@google.com>,
	James Bottomley <jejb@linux.ibm.com>, Min Xu <min.m.xu@intel.com>,
	Dionna Glaze <dionnaglaze@google.com>
Subject: Re: [edk2-devel] [PATCH v2] OvmfPkg/PlatformPei: Validate SEC's GHCB page
Message-ID: <20221212065111.tuzdlz7d4kojnhgp@sirius.home.kraxel.org>
References: <ba66a8db-d5eb-8d66-ae42-d498fc4c46cc@amd.com>
 <9b9c4946b7b825d2dc6ba2d6aab9ea703db81bf7.1670611881.git.acdunlap@google.com>
 <aa7579b8-df03-bfd5-1663-2850927db321@amd.com>
MIME-Version: 1.0
In-Reply-To: <aa7579b8-df03-bfd5-1663-2850927db321@amd.com>
X-Scanned-By: MIMEDefang 3.1 on 10.11.54.6
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

  Hi,

> > +  Status = MemEncryptSevSetPageEncMask (
> > +    0,                                  // Cr3 -- use system Cr3
> > +    FixedPcdGet32 (PcdOvmfSecGhcbBase),
> > +    1                                   // Number of pages
> > +    );
> 
> These arguments need to be aligned under the lower case "m", too.

Best way to deal with this and the other code style issues is to install
uncrustify locally and let it format the source code correctly.

take care,
  Gerd