public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Konstantin Aladyshev" <aladyshev22@gmail.com>
To: devel@edk2.groups.io
Cc: bob.c.feng@intel.com, gaoliming@byosoft.com.cn,
	yuwei.chen@intel.com, jake@nvidia.com,
	Konstantin Aladyshev <aladyshev22@gmail.com>
Subject: [PATCH] Revert "BaseTools/Conf: Fix Dynamic-Library-File template"
Date: Mon, 12 Dec 2022 16:09:24 +0300	[thread overview]
Message-ID: <20221212130924.8156-1-aladyshev22@gmail.com> (raw)

Revert commit d372ab585a2cdc5348af5f701c56c631235fe698.

EdkII build system supports OptionROM generation if particular PCI_*
defines are present in the module INF file:
```
[Defines]
  ...
  PCI_VENDOR_ID                  = <...>
  PCI_DEVICE_ID                  = <...>
  PCI_CLASS_CODE                 = <...>
  PCI_REVISION                   = <...>
```
Although after the commit d372ab585a2cdc5348af5f701c56c631235fe698
it is no longer possible.
The build system fails with the error:
```
Cyclic dependency detected while generating rule for
"<...>/DEBUG/<...>.efi" file
```
Revert d372ab585a2cdc5348af5f701c56c631235fe698 until the issue
is resolved.
---
 BaseTools/Conf/build_rule.template | 2 --
 1 file changed, 2 deletions(-)

diff --git a/BaseTools/Conf/build_rule.template b/BaseTools/Conf/build_rule.template
index af4819de92..32053f6353 100755
--- a/BaseTools/Conf/build_rule.template
+++ b/BaseTools/Conf/build_rule.template
@@ -342,8 +342,6 @@
 
     <OutputFile>
         $(OUTPUT_DIR)(+)$(MODULE_NAME).efi
-        $(DEBUG_DIR)(+)$(MODULE_NAME).efi
-        $(OUTPUT_DIR)(+)$(MODULE_NAME).map
 
     <Command.MSFT, Command.INTEL, Command.CLANGPDB>
         "$(GENFW)" -e $(MODULE_TYPE) -o ${dst} ${src} $(GENFW_FLAGS)
-- 
2.34.1


             reply	other threads:[~2022-12-12 13:09 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-12 13:09 Konstantin Aladyshev [this message]
2022-12-12 15:35 ` [PATCH] Revert "BaseTools/Conf: Fix Dynamic-Library-File template" Jake Garver
2022-12-12 16:07   ` Konstantin Aladyshev
2022-12-13 15:42     ` Jake Garver
2022-12-13 16:24       ` Konstantin Aladyshev
2022-12-13 16:22 ` [PATCH] Fix cyclic dependency error on OptionROM build Konstantin Aladyshev
2022-12-13 18:47   ` Jake Garver
2023-01-15 10:53     ` Konstantin Aladyshev
2023-01-17  5:04     ` Bob Feng
     [not found]     ` <173B00341150B4F6.23170@groups.io>
2023-01-17  5:17       ` [edk2-devel] " Bob Feng
2023-01-17  8:23         ` Konstantin Aladyshev
2023-01-17  9:22           ` Bob Feng

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221212130924.8156-1-aladyshev22@gmail.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox