From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lf1-f52.google.com (mail-lf1-f52.google.com [209.85.167.52]) by mx.groups.io with SMTP id smtpd.web11.44996.1670856420231674637 for ; Mon, 12 Dec 2022 06:47:00 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@gmail.com header.s=20210112 header.b=plPNmcjX; spf=pass (domain: gmail.com, ip: 209.85.167.52, mailfrom: savvamtr@gmail.com) Received: by mail-lf1-f52.google.com with SMTP id z26so1092124lfu.8 for ; Mon, 12 Dec 2022 06:46:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=paRTc3hySFeZxmbXx0YxvtC5ZdwTMoxrmHYfjRMQiFs=; b=plPNmcjXEdC8J8DGpR6OhET0YsDQ2yvdvOUsm5rexKHfEHRVdmnxgzRIr4CvxYiWx9 5E6+GgnYQZXEqOyrD966ouHNyPrri+ctnzsxfXNUI9sxH8UtSOcSiAcD0jHmcO/rSH3g uLQzcpfv1k/LoIGTLH29cmVA6TmtyyoqAGJ5pwHFm9LKF2HhMsIrIMQy77/aKCBUrUUl JjzEOXMMj0WVF5YzRBfeZ/4Tgzh9sIsK/3LRaHu/Fw/bLKFxbBX7QHlGdeo7yu3SUXuY 0Bu9k/MXi/apWZkiCvOshmWQRE8ZtE7qvafvcHi05jsHuP3FC1JiJ17fdemFgPvFGDqf DcbA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=paRTc3hySFeZxmbXx0YxvtC5ZdwTMoxrmHYfjRMQiFs=; b=dYdkEqDum9JI2D9bMfPS5CWXQHD/0axERHEKtWjscmG98IZq0xWznyQoPdgRdVl9eP oR7KhurxhTvtLaLLGBgU0o4sfrx5cFSUuYTteI/YdwfynlKMSnNrIjzGF84pHJhXuzjv Or/dDlGRxs1TZjmVOn+aOZvo/u+Lw1yseLkRUhJ1l8heT+lKDxbBbsz54tFvVPpkZB6F oQYKumFd5TRo12PyZ/caDGBx0O+Z3l06ETiU/06FaCIijB8oXGCdwhP7yYHBQBizHIVa Z+r7aiNOXo3mXcI1eOh+j5aMllg7eTSWjly9afESXmZkR061VZi22/mCs4QaEI1XO33N LWdg== X-Gm-Message-State: ANoB5pmUUbXJSEcK4bxvmNAVhIAafMwyWC4dw0dMNsZKBoYfxExMdfjo 8+nTu8WeR8e7/9J5d6tCBpFEPWlJTl4Bom/A X-Google-Smtp-Source: AA0mqf4G8ciXt0WihbL/UmpxEST12ua1mRi0BWGun8DjVephgGEJiTy3Gkq/fsGLMQtl4K3QicSO+A== X-Received: by 2002:a05:6512:298f:b0:4b6:ee97:36d2 with SMTP id du15-20020a056512298f00b004b6ee9736d2mr866255lfb.40.1670856418413; Mon, 12 Dec 2022 06:46:58 -0800 (PST) Return-Path: Received: from localhost.localdomain ([77.221.215.144]) by smtp.gmail.com with ESMTPSA id t4-20020a056512030400b0049c29292250sm1643313lfp.149.2022.12.12.06.46.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 12 Dec 2022 06:46:57 -0800 (PST) From: "Savva Mitrofanov" To: devel@edk2.groups.io Cc: =?UTF-8?q?Marvin=20H=C3=A4user?= , Pedro Falcato , Vitaly Cheptsov Subject: [edk2-platforms][PATCH v2 00/11] Ext4Pkg: Code correctness and security improvements Date: Mon, 12 Dec 2022 20:46:43 +0600 Message-Id: <20221212144654.2650-1-savvamtr@gmail.com> X-Mailer: git-send-email 2.38.1 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Hi all, In v2 I corrected remarks from Pedro Falcato. Also I added 'Fixes' tag to track which exactly state of driver is fixed by this patchset. This patchset fixes several code problems found by fuzzing Ext4Dxe like buffer and integer overflows, memory leaks, logic bugs and so on. REF: https://github.com/savvamitrofanov/edk2-platforms/tree/master Cc: Marvin Häuser Cc: Pedro Falcato Cc: Vitaly Cheptsov Savva Mitrofanov (11): Ext4Pkg: Fix memory leak in Ext4RetrieveDirent Ext4Pkg: Move EXT4_NAME_MAX definition to Ext4Disk.h Ext4Pkg: Fix global buffer overflow in Ext4ReadDir Ext4Pkg: Fix incorrect checksum metadata feature check Ext4Pkg: Fix division by zero by adding check for s_inodes_per_group Ext4Pkg: Add inode number validity check Ext4Pkg: Fix shift out of bounds in Ext4OpenSuperblock Ext4Pkg: Corrects integer overflow check logic in DiskUtil Ext4Pkg: Check that source file is directory in Ext4OpenInternal Ext4Pkg: Check VolumeName allocation correctness in Ext4GetVolumeName Ext4Pkg: Add missing exit Status in Ext4OpenDirent Features/Ext4Pkg/Ext4Pkg.dsc | 2 +- Features/Ext4Pkg/Ext4Dxe/Ext4Disk.h | 17 +++++-- Features/Ext4Pkg/Ext4Dxe/Ext4Dxe.h | 42 +++++++++++++++- Features/Ext4Pkg/Ext4Dxe/BlockGroup.c | 5 ++ Features/Ext4Pkg/Ext4Dxe/Directory.c | 51 ++++++++++++-------- Features/Ext4Pkg/Ext4Dxe/DiskUtil.c | 8 +-- Features/Ext4Pkg/Ext4Dxe/File.c | 23 ++++++--- Features/Ext4Pkg/Ext4Dxe/Inode.c | 2 +- Features/Ext4Pkg/Ext4Dxe/Superblock.c | 16 ++++-- 9 files changed, 125 insertions(+), 41 deletions(-) -- 2.38.1