From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lf1-f46.google.com (mail-lf1-f46.google.com [209.85.167.46]) by mx.groups.io with SMTP id smtpd.web11.44999.1670856421448535571 for ; Mon, 12 Dec 2022 06:47:11 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@gmail.com header.s=20210112 header.b=en2vjRbA; spf=pass (domain: gmail.com, ip: 209.85.167.46, mailfrom: savvamtr@gmail.com) Received: by mail-lf1-f46.google.com with SMTP id y25so18966017lfa.9 for ; Mon, 12 Dec 2022 06:47:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=qOQgebSf/CCRV6jXSa3BEBs1KrC22s7Jza9yyvOf27Q=; b=en2vjRbA0bgFlRDNEmH5cozCPHeU4T9NuyJBgkcZcoI0cWiWBu9BqNSuscfvKqWlE4 zbClZmDp+DXsTGoDdVFjoGWSp8bltUTOkP1KOnefv4S9w+flNbyOfaE8ImGnSNixGuXs it0qU3KzKimiqvWjipzMIq9vbE3FsLHxY/oARBlqIlWq+Dpx2hLELN5vda1KiWFdzkiL BlL63kdqPZr3CpUqo4Q/+3a1YyYfAOAB7a/z5l6eKlUmVDSNGoWgASIWVlVaFLHqHTq8 LFTO6rT6bGzaf1PfEWFM04C5SiMAkJ9pKjf0EA3vo8zYAMRoqilGjEiWSsPCjVJZGtaY 7RAA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=qOQgebSf/CCRV6jXSa3BEBs1KrC22s7Jza9yyvOf27Q=; b=4bkWyfd2EQUoeB+ohoMBlwmXvEBLRj7VRmVA8tE7xzGz6+F3HauRtfqsRtb5M1D5Ra 5kCbaVqKq+JFQNd7WrqW/RQgQdmvu8LNKSXI08ig8whq09JvxhrW7JfDIFF/PK/pJkSH kajpiM2k5e3dtPAq+xn5rzQv4XUjLbZqTcdQiqi0U/Foox57fKgQSZ1LNq1Sz2BhOeSa q2UjqC1nUs9qc1CDq9ByMXuEDpd88A5TrsKZXwHmhyWFZYhPBznLkquei/ImIDXmW0Yo bSAUQy36vilcsUS+ELILCfRCPHgm868OR9lNSNLgG0kOcBvwB9lTuMVEUBC9MzLjXknA i+Wg== X-Gm-Message-State: ANoB5pmBGyMJZp3WuHOzsKODCKNmhnSbuHksiFmacrEr4usyyRjDyHZX gqZb6fdtv4nB/u9eV6MCfgaQAhk5HjEjOy6H X-Google-Smtp-Source: AA0mqf67FybjucBZ0nSSIZNNHYcB7DJua11FfbY9w/byUIg5mdXyGJnBevcVX1+P/TZHMmjnFj8B1w== X-Received: by 2002:ac2:4c24:0:b0:4b4:900c:3a28 with SMTP id u4-20020ac24c24000000b004b4900c3a28mr3968031lfq.60.1670856430183; Mon, 12 Dec 2022 06:47:10 -0800 (PST) Return-Path: Received: from localhost.localdomain ([77.221.215.144]) by smtp.gmail.com with ESMTPSA id t4-20020a056512030400b0049c29292250sm1643313lfp.149.2022.12.12.06.47.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 12 Dec 2022 06:47:09 -0800 (PST) From: "Savva Mitrofanov" To: devel@edk2.groups.io Cc: =?UTF-8?q?Marvin=20H=C3=A4user?= , Pedro Falcato , Vitaly Cheptsov Subject: [edk2-platforms][PATCH v2 11/11] Ext4Pkg: Add missing exit Status in Ext4OpenDirent Date: Mon, 12 Dec 2022 20:46:54 +0600 Message-Id: <20221212144654.2650-12-savvamtr@gmail.com> X-Mailer: git-send-email 2.38.1 In-Reply-To: <20221212144654.2650-1-savvamtr@gmail.com> References: <20221212144654.2650-1-savvamtr@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Missing EFI_OUT_OF_RESOURCES exit status on failed Ext4CreateDentry leads to NULL-pointer dereference in Ext4GetFileInfo (passing NULL buffer in Ext4ReadDir) Cc: Marvin H=C3=A4user Cc: Pedro Falcato Cc: Vitaly Cheptsov Fixes: e55f0527dde48a5f139c1b8f35acc4e6b59dd794 Signed-off-by: Savva Mitrofanov --- Features/Ext4Pkg/Ext4Dxe/Directory.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/Features/Ext4Pkg/Ext4Dxe/Directory.c b/Features/Ext4Pkg/Ext4Dx= e/Directory.c index ff476c8641e8..efdce1477246 100644 --- a/Features/Ext4Pkg/Ext4Dxe/Directory.c +++ b/Features/Ext4Pkg/Ext4Dxe/Directory.c @@ -260,7 +260,8 @@ Ext4OpenDirent ( } else {=0D File->Dentry =3D Ext4CreateDentry (FileName, Directory->Dentry);=0D =0D - if (!File->Dentry) {=0D + if (File->Dentry =3D=3D NULL) {=0D + Status =3D EFI_OUT_OF_RESOURCES;=0D goto Error;=0D }=0D }=0D --=20 2.38.1