From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lf1-f44.google.com (mail-lf1-f44.google.com [209.85.167.44]) by mx.groups.io with SMTP id smtpd.web10.44805.1670856425579707957 for ; Mon, 12 Dec 2022 06:47:05 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@gmail.com header.s=20210112 header.b=WC+ISo9d; spf=pass (domain: gmail.com, ip: 209.85.167.44, mailfrom: savvamtr@gmail.com) Received: by mail-lf1-f44.google.com with SMTP id cf42so19016136lfb.1 for ; Mon, 12 Dec 2022 06:47:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=oSIJq/FwgRlGYjehgAO9G3FruhWGtistliakz/BDSmg=; b=WC+ISo9dKAh+G8Y8dXJ537+L7Lgs5TZrwspZddESiygvDwgOHU5W5WPuQ0MoFJEaYZ cF3b3TKVdT2A/WfuBpRCxifSmZk2b0tE34eIr5+LPcY1FoFiYk4z45GGAMtU6OFOm+Ac 98mTIyLD6JWX3Wlk4+AS78sq9eUKao9GZV6yGA/eDffQlfgN8lGJXa4BvshqXgysuFCL 2QEDRRUJGlHumXsL/W3qQSqJAocxKe5YiQ/UI4HZ6PAccwRLXIkCuOXKWCldjoJRbwUT z/tH7mrTQk1QQ2Hzw03ik4ErXfx4Ht+oFydz7djaoayXMq3A0vVY8HApTEIBcIxCxgQr 1fbw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=oSIJq/FwgRlGYjehgAO9G3FruhWGtistliakz/BDSmg=; b=zYj/aFbSnAoYZoOUGwsXjwCS5qiKhsip0oOBP3ARmOzKDmtfYN2o/b18BgOCq3kuhw DS+Fn4OT5W/syJHwBHJs8/4Du+19/1uCUwAL3ORVAl2XBP/T22y6jTwI8+q2JDkkmyx/ DdMSpTTaPFAqcv1mcNagDEs8BmmhqaqoUXF94m5bPPSNfwqpnAZr929uZmC2ee9QGvxl SFrcq09TmCk1d90cdrS/p532j4FUHMQpzlM9kgvmYPAaqYOeMXsywZKv8Fese2jLwpm8 RcZ2inFvPsSBpVJMQ30mp/rk47JvpXTFHvhFGoMVcyakxW+ntHvjM8LsssMQvPsAD4hg it3g== X-Gm-Message-State: ANoB5pnyhGrFGP5TY1BeNS4WEO5mAx0fr5bzVCxsKBse3zj9l2eSmKdI quQK8dCiaQjOrNlO8sIW20VXkaBByQkXGWyR X-Google-Smtp-Source: AA0mqf53qZM6Jd860mJYyb8NTFSiaW07/fiCZpdgPx2eJAuPqSZrNyb7lE+AwlQAqUxOnHG8kQjzlg== X-Received: by 2002:a19:ad05:0:b0:4b5:b8cd:d2c6 with SMTP id t5-20020a19ad05000000b004b5b8cdd2c6mr2246305lfc.14.1670856423667; Mon, 12 Dec 2022 06:47:03 -0800 (PST) Return-Path: Received: from localhost.localdomain ([77.221.215.144]) by smtp.gmail.com with ESMTPSA id t4-20020a056512030400b0049c29292250sm1643313lfp.149.2022.12.12.06.47.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 12 Dec 2022 06:47:03 -0800 (PST) From: "Savva Mitrofanov" To: devel@edk2.groups.io Cc: =?UTF-8?q?Marvin=20H=C3=A4user?= , Pedro Falcato , Vitaly Cheptsov Subject: [edk2-platforms][PATCH v2 05/11] Ext4Pkg: Fix division by zero by adding check for s_inodes_per_group Date: Mon, 12 Dec 2022 20:46:48 +0600 Message-Id: <20221212144654.2650-6-savvamtr@gmail.com> X-Mailer: git-send-email 2.38.1 In-Reply-To: <20221212144654.2650-1-savvamtr@gmail.com> References: <20221212144654.2650-1-savvamtr@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Superblock s_inodes_per_group field can't be zero, it leads to division by zero in BlockGroup routine Ext4ReadInode Cc: Marvin H=C3=A4user Cc: Pedro Falcato Cc: Vitaly Cheptsov Fixes: e55f0527dde48a5f139c1b8f35acc4e6b59dd794 Signed-off-by: Savva Mitrofanov --- Features/Ext4Pkg/Ext4Dxe/Superblock.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/Features/Ext4Pkg/Ext4Dxe/Superblock.c b/Features/Ext4Pkg/Ext4D= xe/Superblock.c index 4c662bd1784f..adaf475ea54d 100644 --- a/Features/Ext4Pkg/Ext4Dxe/Superblock.c +++ b/Features/Ext4Pkg/Ext4Dxe/Superblock.c @@ -243,6 +243,11 @@ Ext4OpenSuperblock ( =0D DEBUG ((DEBUG_FS, "Read only =3D %u\n", Partition->ReadOnly));=0D =0D + if (Sb->s_inodes_per_group =3D=3D 0) {=0D + DEBUG ((DEBUG_ERROR, "[ext4] Inodes per group can not be zero\n"));=0D + return EFI_VOLUME_CORRUPTED;=0D + }=0D +=0D Partition->BlockSize =3D (UINT32)LShiftU64 (1024, Sb->s_log_block_size);= =0D =0D // The size of a block group can also be calculated as 8 * Partition->Bl= ockSize=0D --=20 2.38.1