From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lj1-f175.google.com (mail-lj1-f175.google.com [209.85.208.175]) by mx.groups.io with SMTP id smtpd.web10.77948.1670948545369207626 for ; Tue, 13 Dec 2022 08:22:25 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@gmail.com header.s=20210112 header.b=pGLOYfFZ; spf=pass (domain: gmail.com, ip: 209.85.208.175, mailfrom: aladyshev22@gmail.com) Received: by mail-lj1-f175.google.com with SMTP id f20so3816837lja.4 for ; Tue, 13 Dec 2022 08:22:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=A4MsDDAKiLSCmshaFk6MqJKlCk3/f5t7qs3fH014p44=; b=pGLOYfFZ1Dc7oiI/+PzrDchVRWuLn1dZ+cPkf+0Lu48Nxy7L+GE1wTTqDsxDmhsros tNxPpPhgnd2T+RTcchoFDGZZ2z1MpnDZN/l/NBmnW1c03c20kE9Gpu0EE8uMGLXNgV3T FFfKIPfnUbfD10oqwFwo/1H82OZZu8O2dBATFy4SdewXR6i2ZoqgZkV9lmcfNKM+9neW pUq4bUDdMfScFpF4X8gK2Kmcck8+B7R7u9491nM7BnYrtJv5WTI0z8FDJ8gId7Gtdmla tHJz0TVj78ShmsiYh4+8ozxQwkX8dRVVgJ7c7FME8xsgcXR2+HUK6XIL0yn0jvdLgp6j oDaA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=A4MsDDAKiLSCmshaFk6MqJKlCk3/f5t7qs3fH014p44=; b=CmWaXHJBg2EwQrZDpNLjBKWv9kuImqrNwZMQxpKrrH+HdBI2kwKJpgg6AvtNyYBlQg xC9rDk5E1WdMR/EgueuU+9clBsfMt40eW7jEZ9RMqwH+lQbk+AWvPqR4bRnovU9bclLX hwyFEBXAdm67Cegu4uIhgxYw7lqbaG3rXAtE5I4p6om+791OW61/xXWV3lcm7Qez4jgG fb5IQ/UtLYg53FLVSFx8V/6vqDzBWfGEFVrm3clrWNQJxnu/5xRChQaN/hdOsl4focF2 0nnIWyJtnT4GhymIIQOODHvzBQ+6Y1RH43XxBgYiUzyMfg+85USPrrzj3FcpnnbaLzS3 P0Hg== X-Gm-Message-State: ANoB5pmW9G94ToU2NiTIse4rMQmJzOfKOpRsWLVt3GEKyQ8v7PCK+vcu 4abg+X/QPsvM3wFQ2QuCGTrOYotrlJg= X-Google-Smtp-Source: AA0mqf4JzNb+Bg4mqTzX8wKCJdFIMjQbx5xYAxvH0aDDIsc2dKY6oDWs1jV0iMzUxnOkmmjTHC+apg== X-Received: by 2002:a05:651c:1248:b0:279:bbe1:72e1 with SMTP id h8-20020a05651c124800b00279bbe172e1mr4924059ljh.18.1670948543276; Tue, 13 Dec 2022 08:22:23 -0800 (PST) Return-Path: Received: from PC10319.67 ([82.97.198.254]) by smtp.googlemail.com with ESMTPSA id w28-20020a05651c119c00b0026dfbdfc1ddsm317677ljo.11.2022.12.13.08.22.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 13 Dec 2022 08:22:22 -0800 (PST) From: "Konstantin Aladyshev" To: devel@edk2.groups.io Cc: bob.c.feng@intel.com, gaoliming@byosoft.com.cn, yuwei.chen@intel.com, jake@nvidia.com, Konstantin Aladyshev Subject: [PATCH] Fix cyclic dependency error on OptionROM build Date: Tue, 13 Dec 2022 19:22:22 +0300 Message-Id: <20221213162222.590-1-aladyshev22@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20221212130924.8156-1-aladyshev22@gmail.com> References: <20221212130924.8156-1-aladyshev22@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable EDKII build system supports OptionROM generation if particular PCI_* defines are present in the module INF file: ``` [Defines] ... PCI_VENDOR_ID =3D <...> PCI_DEVICE_ID =3D <...> PCI_CLASS_CODE =3D <...> PCI_REVISION =3D <...> ``` Although after the commit d372ab585a2cdc5348af5f701c56c631235fe698 ("BaseTools/Conf: Fix Dynamic-Library-File template") it is no longer possible. The build system fails with the error: ``` Cyclic dependency detected while generating rule for "<...>/DEBUG/<...>.efi" file ``` Remove "$(DEBUG_DIR)(+)$(MODULE_NAME).efi" from the 'dll' output files to fix the cyclic dependency. --- BaseTools/Conf/build_rule.template | 1 - 1 file changed, 1 deletion(-) diff --git a/BaseTools/Conf/build_rule.template b/BaseTools/Conf/build_rule= .template index af4819de92..21ccd864fa 100755 --- a/BaseTools/Conf/build_rule.template +++ b/BaseTools/Conf/build_rule.template @@ -342,7 +342,6 @@ =0D =0D $(OUTPUT_DIR)(+)$(MODULE_NAME).efi=0D - $(DEBUG_DIR)(+)$(MODULE_NAME).efi=0D $(OUTPUT_DIR)(+)$(MODULE_NAME).map=0D =0D =0D --=20 2.34.1