From: "Gerd Hoffmann" <kraxel@redhat.com>
To: "Lee, Chun-Yi" <joeyli.kernel@gmail.com>
Cc: devel@edk2.groups.io, Min M Xu <min.m.xu@intel.com>,
Jiewen Yao <jiewen.yao@intel.com>,
Tom Lendacky <thomas.lendacky@amd.com>,
James Bottomley <jejb@linux.ibm.com>,
Erdem Aktas <erdemaktas@google.com>,
"Lee, Chun-Yi" <jlee@suse.com>
Subject: Re: [PATCH] OvmfPkg/PlatformInitLib: Fix integrity checking failed of NvVarStore in some cases
Date: Wed, 14 Dec 2022 07:15:28 +0100 [thread overview]
Message-ID: <20221214061528.zi627mkk4mumtdoo@sirius.home.kraxel.org> (raw)
In-Reply-To: <20221213155502.29548-1-jlee@suse.com>
Hi,
> When the variable store has those variables, then system booting/rebooting will
> hangs in a ASSERT:
>
> NvVarStore Variable header State was invalid.
> ASSERT
> /mnt/working/source_code-git/edk2/OvmfPkg/Library/PlatformInitLib/Platform.c(819):
> ((BOOLEAN)(0==1))
I'm wondering how you manage to trigger this assert?
> Adding more log to UpdateVariable() and PlatformValidateNvVarStore(), we
> can see there have some variables have 0x3C or 0x3D state in store.
> e.g.
PlatformValidateNvVarStore() validates the varstore in ROM before
copying it to RAM. The normal UpdateVariable() cycle changes the
copy in RAM ...
take care,
Gerd
next prev parent reply other threads:[~2022-12-14 6:15 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-13 15:55 [PATCH] OvmfPkg/PlatformInitLib: Fix integrity checking failed of NvVarStore in some cases Lee, Chun-Yi
2022-12-14 6:15 ` Gerd Hoffmann [this message]
2022-12-14 13:46 ` [edk2-devel] " joeyli
2022-12-14 14:12 ` Gerd Hoffmann
2022-12-14 15:24 ` joeyli
2022-12-14 14:24 ` joeyli
2022-12-14 6:53 ` Yao, Jiewen
2022-12-14 15:05 ` [edk2-devel] " joeyli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221214061528.zi627mkk4mumtdoo@sirius.home.kraxel.org \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox