* [PATCH edk2-platforms 1/1] Platform/Sgi: Use MmUnblockMemoryLib when SECURE_STORAGE_ENABLE
@ 2022-12-14 8:33 PierreGondois
2022-12-14 8:38 ` Ard Biesheuvel
0 siblings, 1 reply; 3+ messages in thread
From: PierreGondois @ 2022-12-14 8:33 UTC (permalink / raw)
To: devel; +Cc: Ard Biesheuvel, Thomas Abraham, Sami Mujawar
From: Pierre Gondois <pierre.gondois@arm.com>
Building the RdV1 platform fails when only providing the
'-D SECURE_STORAGE_ENABLE' flag due to MmUnblockMemoryLib missing.
Signed-off-by: Pierre Gondois <Pierre.Gondois@arm.com>
---
Platform/ARM/SgiPkg/SgiPlatform.dsc.inc | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Platform/ARM/SgiPkg/SgiPlatform.dsc.inc b/Platform/ARM/SgiPkg/SgiPlatform.dsc.inc
index 81764368a0b7..b36c130722b6 100644
--- a/Platform/ARM/SgiPkg/SgiPlatform.dsc.inc
+++ b/Platform/ARM/SgiPkg/SgiPlatform.dsc.inc
@@ -38,7 +38,7 @@ [LibraryClasses.common]
HobLib|MdePkg/Library/DxeHobLib/DxeHobLib.inf
ResetSystemLib|ArmPkg/Library/ArmSmcPsciResetSystemLib/ArmSmcPsciResetSystemLib.inf
TimerLib|ArmPkg/Library/ArmArchTimerLib/ArmArchTimerLib.inf
-!if $(SECURE_BOOT_ENABLE) == TRUE
+!if ($(SECURE_BOOT_ENABLE) == TRUE) || ($(SECURE_STORAGE_ENABLE) == TRUE)
MmUnblockMemoryLib|MdePkg/Library/MmUnblockMemoryLib/MmUnblockMemoryLibNull.inf
!endif
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH edk2-platforms 1/1] Platform/Sgi: Use MmUnblockMemoryLib when SECURE_STORAGE_ENABLE
2022-12-14 8:33 [PATCH edk2-platforms 1/1] Platform/Sgi: Use MmUnblockMemoryLib when SECURE_STORAGE_ENABLE PierreGondois
@ 2022-12-14 8:38 ` Ard Biesheuvel
2022-12-14 8:58 ` PierreGondois
0 siblings, 1 reply; 3+ messages in thread
From: Ard Biesheuvel @ 2022-12-14 8:38 UTC (permalink / raw)
To: Pierre.Gondois; +Cc: devel, Ard Biesheuvel, Thomas Abraham, Sami Mujawar
On Wed, 14 Dec 2022 at 09:34, <Pierre.Gondois@arm.com> wrote:
>
> From: Pierre Gondois <pierre.gondois@arm.com>
>
> Building the RdV1 platform fails when only providing the
> '-D SECURE_STORAGE_ENABLE' flag due to MmUnblockMemoryLib missing.
>
> Signed-off-by: Pierre Gondois <Pierre.Gondois@arm.com>
> ---
> Platform/ARM/SgiPkg/SgiPlatform.dsc.inc | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Platform/ARM/SgiPkg/SgiPlatform.dsc.inc b/Platform/ARM/SgiPkg/SgiPlatform.dsc.inc
> index 81764368a0b7..b36c130722b6 100644
> --- a/Platform/ARM/SgiPkg/SgiPlatform.dsc.inc
> +++ b/Platform/ARM/SgiPkg/SgiPlatform.dsc.inc
> @@ -38,7 +38,7 @@ [LibraryClasses.common]
> HobLib|MdePkg/Library/DxeHobLib/DxeHobLib.inf
> ResetSystemLib|ArmPkg/Library/ArmSmcPsciResetSystemLib/ArmSmcPsciResetSystemLib.inf
> TimerLib|ArmPkg/Library/ArmArchTimerLib/ArmArchTimerLib.inf
> -!if $(SECURE_BOOT_ENABLE) == TRUE
> +!if ($(SECURE_BOOT_ENABLE) == TRUE) || ($(SECURE_STORAGE_ENABLE) == TRUE)
> MmUnblockMemoryLib|MdePkg/Library/MmUnblockMemoryLib/MmUnblockMemoryLibNull.inf
> !endif
>
Thanks for the fix. However, if MmUnblockMemoryLib is just a library
resolution that is always satisfied by the same implementation,
couldn't we drop the conditional altogether?
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH edk2-platforms 1/1] Platform/Sgi: Use MmUnblockMemoryLib when SECURE_STORAGE_ENABLE
2022-12-14 8:38 ` Ard Biesheuvel
@ 2022-12-14 8:58 ` PierreGondois
0 siblings, 0 replies; 3+ messages in thread
From: PierreGondois @ 2022-12-14 8:58 UTC (permalink / raw)
To: Ard Biesheuvel; +Cc: devel, Ard Biesheuvel, Thomas Abraham, Sami Mujawar
On 12/14/22 09:38, Ard Biesheuvel wrote:
> On Wed, 14 Dec 2022 at 09:34, <Pierre.Gondois@arm.com> wrote:
>>
>> From: Pierre Gondois <pierre.gondois@arm.com>
>>
>> Building the RdV1 platform fails when only providing the
>> '-D SECURE_STORAGE_ENABLE' flag due to MmUnblockMemoryLib missing.
>>
>> Signed-off-by: Pierre Gondois <Pierre.Gondois@arm.com>
>> ---
>> Platform/ARM/SgiPkg/SgiPlatform.dsc.inc | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/Platform/ARM/SgiPkg/SgiPlatform.dsc.inc b/Platform/ARM/SgiPkg/SgiPlatform.dsc.inc
>> index 81764368a0b7..b36c130722b6 100644
>> --- a/Platform/ARM/SgiPkg/SgiPlatform.dsc.inc
>> +++ b/Platform/ARM/SgiPkg/SgiPlatform.dsc.inc
>> @@ -38,7 +38,7 @@ [LibraryClasses.common]
>> HobLib|MdePkg/Library/DxeHobLib/DxeHobLib.inf
>> ResetSystemLib|ArmPkg/Library/ArmSmcPsciResetSystemLib/ArmSmcPsciResetSystemLib.inf
>> TimerLib|ArmPkg/Library/ArmArchTimerLib/ArmArchTimerLib.inf
>> -!if $(SECURE_BOOT_ENABLE) == TRUE
>> +!if ($(SECURE_BOOT_ENABLE) == TRUE) || ($(SECURE_STORAGE_ENABLE) == TRUE)
>> MmUnblockMemoryLib|MdePkg/Library/MmUnblockMemoryLib/MmUnblockMemoryLibNull.inf
>> !endif
>>
>
> Thanks for the fix. However, if MmUnblockMemoryLib is just a library
> resolution that is always satisfied by the same implementation,
> couldn't we drop the conditional altogether?
Yes right, I will send a v2 removing the condition,
Regards,
Pierre
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-12-14 8:58 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-12-14 8:33 [PATCH edk2-platforms 1/1] Platform/Sgi: Use MmUnblockMemoryLib when SECURE_STORAGE_ENABLE PierreGondois
2022-12-14 8:38 ` Ard Biesheuvel
2022-12-14 8:58 ` PierreGondois
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox