From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from EUR03-DBA-obe.outbound.protection.outlook.com (EUR03-DBA-obe.outbound.protection.outlook.com [40.107.104.46]) by mx.groups.io with SMTP id smtpd.web11.103751.1671025612299835071 for ; Wed, 14 Dec 2022 05:46:52 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@suse.com header.s=selector1 header.b=E61uSP0F; spf=pass (domain: suse.com, ip: 40.107.104.46, mailfrom: jlee@suse.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=lzmsZfDExhjxIPO36tKxEoZ+gmtwBRtOcYXrMKXv+Z/oN/n7sZvBEiVPy5++xrMkSBy3XZt5shD3K3kcgDLkAtqK4Dsbd/HVBXHBPWgzFyxalRXowX5yWj0dHp6xYSgdwvvrPMcfuzy9HfRVGgDslbkzzdEZHJtu+JxD87YbI6FSqdcRa++ovxX0jUGywuDYIQ8NLilHSgQgdmgJT6V4zIvFd1AyvjNAciFNsGqltjRZGLoR89LTqcFNMqomckRhW7Gjwz1yb2+4cpJvv8XC6CbQSTa5FsLNu7vhmE2dM7fHxa/Cm6nBFrkkf2vVHlVuJ0wzFN63ghIDvvxDIcQ6GA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=WkLHQEraZ5i1rrRoIOSlaLmEznR6BLkjQ8TBHIjlURQ=; b=maCQChwvtWCKAYP0KIEUXvxy98sTJ6ysOSNUvOVcLXzRSVPGs3uXF6+QVLqblXrDp1jikK9tJQlYUI7h6xHyyR4qh6Osfn0gD+wDTHil7mV9PG9Oz4pCMobq2kY+z/eD+/hoUXdhxKtBC/eU8shQz9jqKDSst2xKnGhMGkOkFy5Gh9FKuzXcvbm2KIy4gBgwYYF5KkBU6sLL8WMKe4HPckepVi6hh62D5055/vL/Y98zXjXS4sjjFfgsugm/nkGY1L8Ittep17vGTnuMCFB/TtZHQet1H4IZHVIC4d9U4rDN8tAy40B529PQmfI/twlL4ZiDsXTMzj+HbvOneMvpsw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=WkLHQEraZ5i1rrRoIOSlaLmEznR6BLkjQ8TBHIjlURQ=; b=E61uSP0FOwAfiMPKrQlnVlEVcsouaWbhyjTaB7CgQzQ3hFTnn4FW+EEPEWZelhrv08JYyCwTKwscrGpglS9J+u5daRzL//P+aMlrzmiwA9wtMIZL7sboYHfxD8K6MoEwqYigpnravfqM8R3eE008CJi8o2LjfWD6WpgA5uhXZjDUC2jPeXWJPlFQ4gdw8k6xdcVXOrpkkKs8xE5OgzTfKuJheZYOvqoqm8+vfUEy8s+A9KjehH5HAaGO9duqESC9NiL5tYNlr+9jVLGlsnq9l5sEWRsvVWBhlLbuhngi1zfmHAozAlBSkNLSDn+704uPLW9PXg2UkzEcQnNlYwqZXg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Received: from DB8PR04MB7164.eurprd04.prod.outlook.com (2603:10a6:10:129::23) by PAXPR04MB8928.eurprd04.prod.outlook.com (2603:10a6:102:20f::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5880.11; Wed, 14 Dec 2022 13:46:49 +0000 Received: from DB8PR04MB7164.eurprd04.prod.outlook.com ([fe80::3cc9:78f1:6e76:b1ef]) by DB8PR04MB7164.eurprd04.prod.outlook.com ([fe80::3cc9:78f1:6e76:b1ef%5]) with mapi id 15.20.5880.019; Wed, 14 Dec 2022 13:46:49 +0000 Date: Wed, 14 Dec 2022 21:46:36 +0800 From: "joeyli" To: devel@edk2.groups.io, kraxel@redhat.com Cc: "Lee, Chun-Yi" , Min M Xu , Jiewen Yao , Tom Lendacky , James Bottomley , Erdem Aktas Subject: Re: [edk2-devel] [PATCH] OvmfPkg/PlatformInitLib: Fix integrity checking failed of NvVarStore in some cases Message-ID: <20221214134516.GY11807@linux-l9pv.suse> References: <20221213155502.29548-1-jlee@suse.com> <20221214061528.zi627mkk4mumtdoo@sirius.home.kraxel.org> In-Reply-To: <20221214061528.zi627mkk4mumtdoo@sirius.home.kraxel.org> User-Agent: Mutt/1.11.4 (2019-03-13) X-ClientProxiedBy: TYCPR01CA0158.jpnprd01.prod.outlook.com (2603:1096:400:2b1::9) To DB8PR04MB7164.eurprd04.prod.outlook.com (2603:10a6:10:129::23) Return-Path: JLee@suse.com MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DB8PR04MB7164:EE_|PAXPR04MB8928:EE_ X-MS-Office365-Filtering-Correlation-Id: 967865b9-7341-43e5-48d4-08daddd9a644 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: m25luKbmEfjfUBwqKs2oaok87L2Vq1bXv5WYP9xUuzqcTqyWkoqjeoi0VJSfkx8Cd+HZiDG4/rlKGbS8sAUV/1bPGtnMGtpqEo+gk+7HITIMWv1oNVHUgqfK1RD04fTwa9Vx5LgCG1NP56BLCM/FAxubeWPuTeGYSbqaePb/RfgMXj9hR8M+MYXYfdnjyO6D8qZiNHIpgIxXxC1/Adfvg4I4rlffFlyjHR7VFF5RikFmDjUjHneNg0xxFrSm95TIrZLV79R96dNlxlTZHr0rAab7VILo0mkO9LG8yxGLAI7gtta1r09t820QBvCaoJEkezavw6cL8sq1gl+wlC6gSZusJXGcyEc6U/izHAivFvNmqEs97RLV4gfSedYcOnzgS1VNGtUTBJD5pyx46d58rC1gEuYXQBz+Wau2ld5WXLxWMvJgXGD4xyHRTCxulki9teS2rLUtoxg/8Y6t9zZQLhARUofJikT6YHHr5FfcogCsQuSMQdFU0uXjjaVW5Xu4g35o70sTeqPhieVolBST3bvtBv9Lqv/MHzNhwSxghRevXXKwKI0LKzqwgt6/UtF0pjgRhuFo2+ribXhSQOokBt7USK2gF9fgR40q/NvAaGzhKDREIfzjNQsOsQNRuEwFfE7KNCQ6PcUWbcpB5U2WzMwRVnocHe7LEEcacaF+poTIuuqRrBm6yGPzB1oKCPnQ X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DB8PR04MB7164.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(6029001)(39860400002)(136003)(346002)(376002)(396003)(366004)(451199015)(83380400001)(6666004)(36756003)(86362001)(54906003)(478600001)(33656002)(316002)(19627235002)(38100700002)(6486002)(2906002)(66476007)(66556008)(5660300002)(4326008)(8676002)(8936002)(41300700001)(66946007)(26005)(6512007)(9686003)(186003)(6506007)(1076003)(43062005);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?EOwe24FwRFIapHRLAWNt599AvnqazciPQ9SDUipsqdqT/fRFCXqODYvS6lkm?= =?us-ascii?Q?0xSzM+DQSoYia+Dh1OUCc2fbyD/ho3NZANwnlvdWpxrj+hb1YP2upmIFxqKw?= =?us-ascii?Q?6D1A5J++/LEEvKjaHUwiJkRu9kpI6mnXKV0V7k1+05Xhv0Sp8EeLsLpf4pyR?= =?us-ascii?Q?ASq0jGCEECy4exj0Q+aOw62z7Mi2rRZCthC0tOQwLywP11Fl8TB3ItynGjLH?= =?us-ascii?Q?eAnjneTYRdZyJmvXKXL8cdrECoMk70bLWjubHZ4IrpWorOKDFE1REwaR5VWv?= =?us-ascii?Q?+89rb1AHUSulAXkVif8QGxI83fzSjBI/UHLfn1uxTJE3UOpfq5D2PxY2dDZh?= =?us-ascii?Q?EXz9CJF2xeE2Wta6hPRnBrqbHc3Q/cSLmGZzvDUNmdCh/O4zUTm7J3OFaDVi?= =?us-ascii?Q?GZyWajMSLTaTWUx6YMUMwdynpXqIN8i7TWWMWIYn3526ZXi/DIppBIdJb19L?= =?us-ascii?Q?U87+buYgILQuIhICgIoME1x8mqPukDGK+gsHHnM3yUTyh1+8ZTiKBZK6WbnM?= =?us-ascii?Q?9PTcAPKlIWHP6EUclV2hcVHTmrdH/UES4sJO0Xn8d++rz8MBasGVBDMDVQFc?= =?us-ascii?Q?NBiij5NMmTE92RNR+2aBAleem5DAZt1SMmNeE4N7bKBjXOBC4nCj/FqTePLW?= =?us-ascii?Q?khFbTtqIupEIdq1Xd7w5KIlBKJnkoudlvXkk7MUoNgAa8xd7cY3OEholp/6X?= =?us-ascii?Q?n8sc4mk8eapK7WdRKAufklXW6AtA39ZGuVByccA+UhwYoAIMd5/QZUg7Bygj?= =?us-ascii?Q?zra1tdbYes/eRv8JfqtXPPtZBpxtcGn0RIFPFRVjH2NN+5TFfhLGD3zrKobQ?= =?us-ascii?Q?THItXEo6V4iLmDyFY5iXm8JYAHEZk7I4lQSusUZ56eM7PUH8v5AQHGvTi7x9?= =?us-ascii?Q?bb/5qnszOy1hKSsB99FY+4gj4BSkcUwPzjfzW1zVR50w1wbhbPdSnWb1GS18?= =?us-ascii?Q?mrED9Szr+fwejnpBCEwQCVrg3Tg2AyuTk+nSFw8gsQboo367FVQdLujix5zI?= =?us-ascii?Q?wFLK8M7B9P51ahxNxSF0qagxqrzuursruvOCvF9MqAqox9g0kYYlqAkU6tnX?= =?us-ascii?Q?0Ptik+5Wde3I/NcgGWnhNsI0FlLzBTTVcRvJ9plELr4FUKMDbqyhPIncxZWi?= =?us-ascii?Q?TtMnOYrUeVOOzy+19hpzmAH1PaEddnrI/pIxBfRuHuKADGRpYG1hIsA5CaeF?= =?us-ascii?Q?eMm+gBW+TpXupH5VFCPnRdu0gDNR5od4aJLB8+AFBI1VPfDATYW6ovcHg5Dv?= =?us-ascii?Q?L7zDUDrdzzTf4e6TOdbeHKMD9wRKixMPKbWbY1n2HyJDVSpvIEEZtteljm+7?= =?us-ascii?Q?ph5TJ5b4p8HTgyixYTpGyH4G/NufETyGvBWmc1uuCq4wA7DSL5xYWuPw7bUz?= =?us-ascii?Q?WyzYNLQVCy1yS0QqlB6Fok4JMG94OmkZN3TElnFevM76NDkIyTc75QHOB+95?= =?us-ascii?Q?ONOyiCTfKrJ5yQS6ukEdfXBexiOKwrYpxrkWoArSb1LQm4qDhZHedoAlZOuW?= =?us-ascii?Q?CM8d5IXI+XY/KRnPQotntDnpubginQPsBqg6bUllS6pM1qIIdyCZBORFviqm?= =?us-ascii?Q?wRyBQ7y40LY1KfcjEcQ=3D?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 967865b9-7341-43e5-48d4-08daddd9a644 X-MS-Exchange-CrossTenant-AuthSource: DB8PR04MB7164.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Dec 2022 13:46:49.5355 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: QoLOcRglBPUo53FSrj+0cb7VvCLNQDQY+nFRzpCcYpzgzwvStbdvtREFHkUKBMO8 X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB8928 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Hi Gerd, Thanks for your response! On Wed, Dec 14, 2022 at 07:15:28AM +0100, Gerd Hoffmann via groups.io wrote: > Hi, > > > When the variable store has those variables, then system booting/rebooting will > > hangs in a ASSERT: > > > > NvVarStore Variable header State was invalid. > > ASSERT > > /mnt/working/source_code-git/edk2/OvmfPkg/Library/PlatformInitLib/Platform.c(819): > > ((BOOLEAN)(0==1)) > > I'm wondering how you manage to trigger this assert? > Sorry for I forgot to put my testing environment in patch description. My testing is on qemu with OVMF: - edk2-master or edk2-stable202211 build --verbose --debug=1 -D SECURE_BOOT_ENABLE -D TPM_ENABLE -D TPM_CONFIG_ENABLE \ -D NETWORK_IP6_ENABLE -D NETWORK_HTTP_BOOT_ENABLE -a X64 -b DEBUG -t GCC5 \ -p OvmfPkg/OvmfPkgX64.dsc -D FD_SIZE_4MB -D NETWORK_TLS_ENABLE - qemu-7.1.0 with libvirt-8.0.0 pc-q35 with pflash type and nvram: hvm /usr/share/qemu/ovmf-x86_64-code.bin /var/lib/libvirt/qemu/nvram/opensuseTW_VARS.fd - grub2 2.06 and Linux kernel 6.1.0-rc5 Two test cases, both of them can reproduce the assert: - First booting to grub2 menu, then "virsh destroy" the guest. The second boot hangs in the "NvVarStore Variable header State was invalid." assert - First boot to Linux kernel 6.1.0-rc5, bash shell prompt shows up. Then run shutdown or reboot command. The second boot hangs in in the "NvVarStore Variable header State was invalid." assert > > Adding more log to UpdateVariable() and PlatformValidateNvVarStore(), we > > can see there have some variables have 0x3C or 0x3D state in store. > > e.g. > > PlatformValidateNvVarStore() validates the varstore in ROM before > copying it to RAM. The normal UpdateVariable() cycle changes the > copy in RAM ... > Yes, in the first boot, those variables have 0x3C or 0x3C state be created. After shutdown or reboot, system hangs in the second boot. The assert shows up in debug log. Thanks a lot! Joey Lee