* [PATCH v2 1/1] Platform/Sgi: Use MmUnblockMemoryLib when SECURE_BOOT_ENABLE
@ 2022-12-15 8:34 PierreGondois
2022-12-15 9:54 ` Ard Biesheuvel
0 siblings, 1 reply; 2+ messages in thread
From: PierreGondois @ 2022-12-15 8:34 UTC (permalink / raw)
To: devel; +Cc: Ard Biesheuvel, Thomas Abraham, Sami Mujawar
From: Pierre Gondois <pierre.gondois@arm.com>
Building the RdV1 platform fails when only providing the
'-D SECURE_BOOT_ENABLE' flag due to MmUnblockMemoryLib missing.
There is only one MmUnblockMemoryLib implementation used,
so unconditionally use this implementation.
Signed-off-by: Pierre Gondois <Pierre.Gondois@arm.com>
---
Notes:
v2:
- Instead of defining the library when SECURE_BOOT_ENABLE is defined,
unconditionally include the library. [Ard]
Platform/ARM/SgiPkg/SgiPlatform.dsc.inc | 2 --
1 file changed, 2 deletions(-)
diff --git a/Platform/ARM/SgiPkg/SgiPlatform.dsc.inc b/Platform/ARM/SgiPkg/SgiPlatform.dsc.inc
index 81764368a0b7..a21faa249b07 100644
--- a/Platform/ARM/SgiPkg/SgiPlatform.dsc.inc
+++ b/Platform/ARM/SgiPkg/SgiPlatform.dsc.inc
@@ -38,9 +38,7 @@ [LibraryClasses.common]
HobLib|MdePkg/Library/DxeHobLib/DxeHobLib.inf
ResetSystemLib|ArmPkg/Library/ArmSmcPsciResetSystemLib/ArmSmcPsciResetSystemLib.inf
TimerLib|ArmPkg/Library/ArmArchTimerLib/ArmArchTimerLib.inf
-!if $(SECURE_BOOT_ENABLE) == TRUE
MmUnblockMemoryLib|MdePkg/Library/MmUnblockMemoryLib/MmUnblockMemoryLibNull.inf
-!endif
# Virtio Support
VirtioLib|OvmfPkg/Library/VirtioLib/VirtioLib.inf
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH v2 1/1] Platform/Sgi: Use MmUnblockMemoryLib when SECURE_BOOT_ENABLE
2022-12-15 8:34 [PATCH v2 1/1] Platform/Sgi: Use MmUnblockMemoryLib when SECURE_BOOT_ENABLE PierreGondois
@ 2022-12-15 9:54 ` Ard Biesheuvel
0 siblings, 0 replies; 2+ messages in thread
From: Ard Biesheuvel @ 2022-12-15 9:54 UTC (permalink / raw)
To: Pierre.Gondois; +Cc: devel, Thomas Abraham, Sami Mujawar
On Thu, 15 Dec 2022 at 09:35, <Pierre.Gondois@arm.com> wrote:
>
> From: Pierre Gondois <pierre.gondois@arm.com>
>
> Building the RdV1 platform fails when only providing the
> '-D SECURE_BOOT_ENABLE' flag due to MmUnblockMemoryLib missing.
> There is only one MmUnblockMemoryLib implementation used,
> so unconditionally use this implementation.
>
> Signed-off-by: Pierre Gondois <Pierre.Gondois@arm.com>
> ---
>
> Notes:
> v2:
> - Instead of defining the library when SECURE_BOOT_ENABLE is defined,
> unconditionally include the library. [Ard]
>
Pushed as 425cce541517..20e07099d8f1, thanks.
> Platform/ARM/SgiPkg/SgiPlatform.dsc.inc | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/Platform/ARM/SgiPkg/SgiPlatform.dsc.inc b/Platform/ARM/SgiPkg/SgiPlatform.dsc.inc
> index 81764368a0b7..a21faa249b07 100644
> --- a/Platform/ARM/SgiPkg/SgiPlatform.dsc.inc
> +++ b/Platform/ARM/SgiPkg/SgiPlatform.dsc.inc
> @@ -38,9 +38,7 @@ [LibraryClasses.common]
> HobLib|MdePkg/Library/DxeHobLib/DxeHobLib.inf
> ResetSystemLib|ArmPkg/Library/ArmSmcPsciResetSystemLib/ArmSmcPsciResetSystemLib.inf
> TimerLib|ArmPkg/Library/ArmArchTimerLib/ArmArchTimerLib.inf
> -!if $(SECURE_BOOT_ENABLE) == TRUE
> MmUnblockMemoryLib|MdePkg/Library/MmUnblockMemoryLib/MmUnblockMemoryLibNull.inf
> -!endif
>
> # Virtio Support
> VirtioLib|OvmfPkg/Library/VirtioLib/VirtioLib.inf
> --
> 2.25.1
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-12-15 9:54 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-12-15 8:34 [PATCH v2 1/1] Platform/Sgi: Use MmUnblockMemoryLib when SECURE_BOOT_ENABLE PierreGondois
2022-12-15 9:54 ` Ard Biesheuvel
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox