From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (NAM12-MW2-obe.outbound.protection.outlook.com [40.107.244.55]) by mx.groups.io with SMTP id smtpd.web10.25319.1671644534326670763 for ; Wed, 21 Dec 2022 09:42:14 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@amd.com header.s=selector1 header.b=TgMsfqnf; spf=permerror, err=parse error for token &{10 18 %{i}._ip.%{h}._ehlo.%{d}._spf.vali.email}: invalid domain name (domain: amd.com, ip: 40.107.244.55, mailfrom: michael.roth@amd.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=XcXTWO5W77CDNq6/aJtY89BEoMAQ2S7q/B69blPOPz5ejJmzoqCIYAeZJxSCD16lXnUPb0EjTFyemUXiCIG/fp3ly7QYC8TfH5s5LguUNS6BSG2ZPOIEF7sOMYLY2t71bzxXEeP/Pu5Eyl6c9XqA2F1FFDxMMz1Usf4Rrz3Oj5SCP0NjpSkSK2upKf0je1zJvgWGkcceaNY7JTlYrO/6qS01tRqcQZXTmibYpdC3uErRx8C/aIkEqFJET49sk7v4y5ATp6Eo1pPth+EPR8SVc8PymOypiz8xC3H4k+E9oW6YDbil9qsL+Zo9sJpGchRXzNEQq7zzv87+6UHc10Dxdw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=KNRGks5UiHBPxjuSxIgJdHeee3Nzv3F7mkQxM4He9ps=; b=iZNJ582Z1IWPBqHbIrgjD/CFO+MgYK1NUb+4UGBFWUNC7KUNH9ZiBQ4K8+Is81MRumYXXJHi4R+D/QjlvgW8RljGYdJTvlagA7VjBFWqFRNls4AbmZU5/P0lsZkyH9xF4EBQj4O9fHnVsbODGM2hAWFpcrhRsN1T4LScwZajCJ4gozpiv1eQ/auGXfjfJNk4xrnL2LKIRsW1A7GeYVy1NhiNrX1EsBlO+sg6G4MUQkmX1psepWWf57TI58aUA3a2+oJWEo7hx4rsuAtebrEjFcr3Lc5bWRLHq7UdWepjyMofu9UlOnm0U5fYs5MvN1GLKqajeaMwD0WN0Vx7x0NRow== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=edk2.groups.io smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=KNRGks5UiHBPxjuSxIgJdHeee3Nzv3F7mkQxM4He9ps=; b=TgMsfqnfcxlz6YXCHpaEF5jw9SQkfgJCv52tuTBsmlMnw1HB6f5b6CC1dM7bRznC6sJ8IKCOSNS9P36adAseeOurihBNAULg9mR4cmhcG0iFwWLGC3QwUu8esBzC+VkW9xWxTODb9RgYsUYYsXUgs/AWqiz+d5YcKmy5zfbykhU= Received: from MW4P222CA0024.NAMP222.PROD.OUTLOOK.COM (2603:10b6:303:114::29) by MN6PR12MB8513.namprd12.prod.outlook.com (2603:10b6:208:472::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5924.16; Wed, 21 Dec 2022 17:42:12 +0000 Received: from CO1PEPF00001A5D.namprd05.prod.outlook.com (2603:10b6:303:114:cafe::ea) by MW4P222CA0024.outlook.office365.com (2603:10b6:303:114::29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5924.21 via Frontend Transport; Wed, 21 Dec 2022 17:42:12 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by CO1PEPF00001A5D.mail.protection.outlook.com (10.167.241.4) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5944.8 via Frontend Transport; Wed, 21 Dec 2022 17:42:11 +0000 Received: from localhost (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Wed, 21 Dec 2022 11:42:11 -0600 Date: Wed, 21 Dec 2022 11:41:30 -0600 From: "Roth, Michael" To: CC: Tom Lendacky , , Ard Biesheuvel , Jiewen Yao , Gerd Hoffmann , Erdem Aktas , James Bottomley , Min Xu Subject: Re: [PATCH 0/4] Fixes for SEV-SNP CC blob and CPUID table handling Message-ID: <20221221174130.xbi6q3irva6kcitx@amd.com> References: <20221221160651.182143-1-michael.roth@amd.com> MIME-Version: 1.0 In-Reply-To: <20221221160651.182143-1-michael.roth@amd.com> Return-Path: Michael.Roth@amd.com X-Originating-IP: [10.180.168.240] X-ClientProxiedBy: SATLEXMB04.amd.com (10.181.40.145) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CO1PEPF00001A5D:EE_|MN6PR12MB8513:EE_ X-MS-Office365-Filtering-Correlation-Id: a59fced0-d52a-42c2-e4e2-08dae37ab0f8 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 26gAEd7AnyuO1d66Q3cqn3MtUtgWomPnFWPMhJyi3Hdfq0da6hv/p9ionIaAwPzuJ3C7O3oPoIypUuq6l6A0t5aOxs75u7dBatbXhV8fq/ylD7ggDy7e7dVDzrXelimRjgsfR3NKfIcQvakI3PH1oRIpIiPBzkJL291AUU5Z8f2AGTZT/QLErq2AH9vKFcoOcU6NWfb13IiutU14p55MPQLo9WyDNlwGMc5pWSOgbO3VzzWabuTHac0T7+4FsgBbZScDCqw7BjOudsBrquPeviOqrJRMM8vf2lMgp+Nf4dGi9JzRZTYEHURG3XbmLvw4JXN0f7Jaeze8isy8nzFBmsHXNXX1qTCbaOK7HJo+4Wn7eqEJ7ENbZYlZdAAbgP7yhnWGvXHmSoewZS2VPHQeRPnx831zoUiFxou+ISd6eTiP7l102K4C6Diy3jYRQxLGHKn6DwxNscnEP4cL1+cGLGrdoI//8SEKgFN435gCkMkEkkLlVr0M6ZXAPqa9xzeZpRTI86djJ6Ak9lycCCa6lPSQ0XcX7nfuIvltWsfc+2daf3QDfk7WYxj9O3uB34btezCcfv6p96IOVd1uZRhdReV5wGziPp1+7QKPb9sVufuXC4iNqwT6iW5pttSPz2HrstmDkVRMeBKJTVVG4z1Lgo7clseRq1RbcR6KV6EuTFZjefH00oZlRRTX2eFbci29Qym/BOQT6GM5i2vX1d6pga9DAV2aeqjEcSDo+OiOQxw= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230022)(4636009)(396003)(346002)(39860400002)(136003)(376002)(451199015)(40470700004)(46966006)(36840700001)(54906003)(36756003)(40480700001)(47076005)(356005)(83380400001)(316002)(86362001)(6916009)(40460700003)(478600001)(41300700001)(6666004)(8936002)(2906002)(70586007)(36860700001)(70206006)(5660300002)(4326008)(8676002)(44832011)(82740400003)(186003)(426003)(2616005)(1076003)(16526019)(82310400005)(81166007)(26005)(336012)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Dec 2022 17:42:11.9400 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: a59fced0-d52a-42c2-e4e2-08dae37ab0f8 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: CO1PEPF00001A5D.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN6PR12MB8513 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline On Wed, Dec 21, 2022 at 10:06:47AM -0600, Michael Roth wrote: > Here are a number of fixes related to OVMF handling of the SEV-SNP > Confidential Computing blob and CPUID table. > > Patch #1 is a fix for recently-reported issue that can cause > significant problems with some SEV-SNP guest operating systems. > Please consider applying this patch directly if the other > patches in this series are held up for any reason. > > Patches 2-4 are minor changes for things that aren't currently > triggered in practice, but make OVMF's SEV-SNP implementation more > robust for different build/hypervisor environments in the future. > Patch #2 was submitted previously, but refreshed here to apply > cleanly on top of Patch #1, with no other functional changes since > the initial review. > > ---------------------------------------------------------------- > Michael Roth (4): > OvmfPkg/AmdSevDxe: Allocate SEV-SNP CC blob as EfiACPIReclaimMemory > OvmfPkg/AmdSevDxe: Update ConfidentialComputing blob struct definition > OvmfPkg/CcExitLib: Fix SEV-SNP XSave area size calculation > OvmfPkg/CcExitLib: Use documented XSave area base size for SEV-SNP Adding some Cc's from Maintainers.txt that I should have included originally: Ard Biesheuvel Jiewen Yao Gerd Hoffmann Erdem Aktas James Bottomley Min Xu Thanks, Mike > > OvmfPkg/AmdSevDxe/AmdSevDxe.c | 64 ++++++++++++++++++++++++++++++++++---------- > OvmfPkg/Include/Guid/ConfidentialComputingSevSnpBlob.h | 6 +++-- > OvmfPkg/Library/CcExitLib/CcExitVcHandler.c | 13 ++++----- > 3 files changed, 59 insertions(+), 24 deletions(-) > >