From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mx.groups.io with SMTP id smtpd.web10.9663.1672831305877798228 for ; Wed, 04 Jan 2023 03:21:46 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=L7iPrNB9; spf=pass (domain: redhat.com, ip: 170.10.129.124, mailfrom: kraxel@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1672831304; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Ekrju15nR4fxGpwYIFe4BFyPDnvCTOhGdNnJV6VukBA=; b=L7iPrNB9TvD0pHORucMcKnQbLQWxZseYQu6T/TWwu5afp2PSY18Uu3qshF/usr7osrMEnR 8X0atjasrxt7nvGqHDjEaGl0aNHsOdtjheHR+XRBMFRmcc4QZM7F/vqbCfWj/FQNUdRJ/+ qnPmQIOODoq169BBvFgkYNg6Y3D6zvQ= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-647-8JXXcMNNNE6YJVFjfpLV5g-1; Wed, 04 Jan 2023 06:21:35 -0500 X-MC-Unique: 8JXXcMNNNE6YJVFjfpLV5g-1 Received: from smtp.corp.redhat.com (int-mx09.intmail.prod.int.rdu2.redhat.com [10.11.54.9]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id CDF6A101A52E; Wed, 4 Jan 2023 11:21:29 +0000 (UTC) Received: from sirius.home.kraxel.org (unknown [10.39.192.238]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 8EEC7492B06; Wed, 4 Jan 2023 11:21:29 +0000 (UTC) Received: by sirius.home.kraxel.org (Postfix, from userid 1000) id C5FF3180039D; Wed, 4 Jan 2023 12:21:27 +0100 (CET) Date: Wed, 4 Jan 2023 12:21:27 +0100 From: "Gerd Hoffmann" To: Laszlo Ersek Cc: devel@edk2.groups.io, Andrew Fish , Eric Dong , Leif Lindholm , Michael D Kinney , Rahul Kumar , Ray Ni Subject: Re: [PATCH 1/1] Maintainers.txt: designate Gerd Hoffmann as UefiCpuPkg reviewer Message-ID: <20230104112127.mhiovgisg6xzslrs@sirius.home.kraxel.org> References: <20230103160539.87830-1-lersek@redhat.com> MIME-Version: 1.0 In-Reply-To: <20230103160539.87830-1-lersek@redhat.com> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.9 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Tue, Jan 03, 2023 at 05:05:39PM +0100, Laszlo Ersek wrote: > I suggest that Gerd be notified about all UefiCpuPkg patches, so he may > take a quick look at, or (by his preference) even test, the proposed > change, in a genuine QEMU/KVM environment. > > Assuming this patch is accepted -- subsequently, please *wait* for Gerd's > approval on UefiCpuPkg patches, before merging them. > > Notes: > > - It's perfectly fine for a reviewer to give an A-b just so the review > process be unblocked, if they don't have anything to add, or don't have > time to review or test in detail. The point is that someone outside of > Intel should *consistently get a chance* to raise concerns about > UefiCpuPkg patches before they are merged. > > - My A-b's and R-b's on UefiCpuPkg patches were never supposed to be > "sufficient", only "necessary", for merging. The intent is the same > here, with Gerd's designation as a reviewer. > > Cc: Andrew Fish > Cc: Eric Dong > Cc: Gerd Hoffmann > Cc: Leif Lindholm > Cc: Michael D Kinney > Cc: Rahul Kumar > Cc: Ray Ni > Signed-off-by: Laszlo Ersek Acked-by: Gerd Hoffmann take care, Gerd