From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mx.groups.io with SMTP id smtpd.web10.10907.1672918324768447138 for ; Thu, 05 Jan 2023 03:32:05 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=B2n2qKgb; spf=pass (domain: redhat.com, ip: 170.10.129.124, mailfrom: kraxel@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1672918323; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=fJneSlaT3JzgN1GH/nv900dndPcuGGs1baTMjql32h0=; b=B2n2qKgbiCKRRaz1/XU8J0H+gBR+3cYLr63reKopTasm0JJwZ1dS7LFVvzwK8136meqBQj jqaUGDhEtczFYXxBZMGid9XENYtTGkEi+HfamG0uMqv4UzfWuAhGuh3SXi5T6TMwQwlkAG qFgrY/R9GEyOf9qhlIKdJM+ok5MG3j4= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-93-7LxhEHnYNY6DTyRqrSJOLw-1; Thu, 05 Jan 2023 06:32:01 -0500 X-MC-Unique: 7LxhEHnYNY6DTyRqrSJOLw-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 3B08718A6462; Thu, 5 Jan 2023 11:32:00 +0000 (UTC) Received: from sirius.home.kraxel.org (unknown [10.39.192.238]) by smtp.corp.redhat.com (Postfix) with ESMTPS id BCDEA2166B30; Thu, 5 Jan 2023 11:31:59 +0000 (UTC) Received: by sirius.home.kraxel.org (Postfix, from userid 1000) id 0E8A1180062D; Thu, 5 Jan 2023 12:31:58 +0100 (CET) Date: Thu, 5 Jan 2023 12:31:58 +0100 From: "Gerd Hoffmann" To: Min Xu Cc: devel@edk2.groups.io, Anthony Perard , Ard Biesheuvel , Brijesh Singh , Erdem Aktas , James Bottomley , Jiewen Yao , Jordan Justen , Julien Grall , Laszlo Ersek , Peter Grehan , Rebecca Cran , Sebastien Boeuf , Tom Lendacky Subject: Re: [PATCH V1 1/1] OvmfPkg/IntelTdxX64: Raise DXEFV size to 13MB Message-ID: <20230105113158.lq5r5zxuyrgapqjy@sirius.home.kraxel.org> References: <20230105072105.144-1-min.m.xu@intel.com> MIME-Version: 1.0 In-Reply-To: <20230105072105.144-1-min.m.xu@intel.com> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.6 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Thu, Jan 05, 2023 at 03:21:05PM +0800, Min Xu wrote: > From: Min M Xu > > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4236 > > Similarly to the "cadence" mentioned in commit d272449 ("OvmfPkg: > raise DXEFV size to 11 MB", 2018-05-29), it's been ~1.75 years since > commit 5e75c4d ("OvmfPkg: raise DXEFV size to 12 MB", 2020-03-11), > and we've outgrown DXEFV again (with NOOPT builds). Increase the DXEFV > size of IntelTdxX64 to 13MB now. Not sure this makes sense given that you want split DXEFV into two smaller volumes for IntelTdx (patch series sent in december IIRC). Also we maybe should move the MEMFD section to a Include/Fdf snippet to reduce code duplication and make it easier to keep things in sync? take care, Gerd