From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124])
 by mx.groups.io with SMTP id smtpd.web10.12412.1672924560855711561
 for <devel@edk2.groups.io>;
 Thu, 05 Jan 2023 05:16:01 -0800
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=NuPsiws4;
 spf=pass (domain: redhat.com, ip: 170.10.129.124, mailfrom: kraxel@redhat.com)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
	s=mimecast20190719; t=1672924560;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=RQyYyVSr3G4IqTvI0Mf6efioBXUp9kVpfW4ExJWrwgY=;
	b=NuPsiws4rCZJFNYbFs/aJMbttzqTW+4C1mnR166bSelgkny3rxmml0np7e4g+3NI3ya0sF
	olVSkvT7D5wqFAo1Ki9XHBOqblRYxZGsHcCSbLFw/DpaZ8jc/UAHGZ+ES84qk8Td3t9ww7
	aBv1YP0ckndOVDobO+Ilp1b4qA9f9ic=
Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com
 [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS
 (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 us-mta-497-K6EaGrzQM6Cvpz_ljl4lAA-1; Thu, 05 Jan 2023 08:15:57 -0500
X-MC-Unique: K6EaGrzQM6Cvpz_ljl4lAA-1
Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3])
	(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 8E4E087B2A0;
	Thu,  5 Jan 2023 13:15:56 +0000 (UTC)
Received: from sirius.home.kraxel.org (unknown [10.39.192.238])
	by smtp.corp.redhat.com (Postfix) with ESMTPS id 61DFB1121314;
	Thu,  5 Jan 2023 13:15:56 +0000 (UTC)
Received: by sirius.home.kraxel.org (Postfix, from userid 1000)
	id 0D37F180062F; Thu,  5 Jan 2023 14:15:55 +0100 (CET)
Date: Thu, 5 Jan 2023 14:15:55 +0100
From: "Gerd Hoffmann" <kraxel@redhat.com>
To: devel@edk2.groups.io, min.m.xu@intel.com
Cc: Laszlo Ersek <lersek@redhat.com>, Erdem Aktas <erdemaktas@google.com>,
	James Bottomley <jejb@linux.ibm.com>,
	Jiewen Yao <jiewen.yao@intel.com>,
	Tom Lendacky <thomas.lendacky@amd.com>,
	Sebastien Boeuf <sebastien.boeuf@intel.com>
Subject: Re: [edk2-devel] [PATCH V1 1/1] OvmfPkg/AcpiPlatformDxe: Add back log and fix code cohesion
Message-ID: <20230105131555.vkjy64tvaxzwouky@sirius.home.kraxel.org>
References: <20230104141309.1426-1-min.m.xu@intel.com>
MIME-Version: 1.0
In-Reply-To: <20230104141309.1426-1-min.m.xu@intel.com>
X-Scanned-By: MIMEDefang 3.1 on 10.11.54.3
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Wed, Jan 04, 2023 at 10:13:09PM +0800, Min Xu wrote:
> From: Min M Xu <min.m.xu@intel.com>
> 
> BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4237
> 
> Commit 9fdc70af6ba8 breaks log analysis and code cohesion in
> AcpiPlatformDxe. See the detailed information in BZ#4237.
> 
> There are below changes in this patch:
> 1) Add back debug log
> 2) Add error checking and handling if InstallProtocolInterface failed.
> 3) Delete the QemuAcpiTableNotify.h because it is superfluous.
> 4) Delete the global variable "mQemuAcpiHandle" instead of a local
>    variable.
> 5) Install the QEMU_ACPI_TABLE_NOTIFY_PROTOCOL with a NULL associated
>    interface.

Five changes in a single patch.  Can this be splitted up please?

thanks,
  Gerd