* [edk2-platforms][PATCH V2] IPMI changes for Redfish
@ 2023-01-05 16:00 Chang, Abner
2023-01-05 16:00 ` [edk2-platforms][PATCH V2] Features/IpmiFeaturePkg: Add IPMI functions Chang, Abner
` (4 more replies)
0 siblings, 5 replies; 9+ messages in thread
From: Chang, Abner @ 2023-01-05 16:00 UTC (permalink / raw)
To: devel
Cc: Isaac Oram, Nate DeSimone, Michael D Kinney, Liming Gao,
Zhiguang Liu, Nickle Wang, Igor Kulchytskyy
From: Abner Chang <abner.chang@amd.com>
In V2: Addressed the comments from Isaac.
BZ# 4214
This patch adds IPMI functions for building up SMBIOS 42
record for the USB NIC host interface exposed by BMC.
The corresponding updates on edk2 is in the separate pacth.
This is the part I of upstream, the follow up patche sets are:
- RedfishPlatformCredentialLib contributed by NVidia.
- Relocate IpmiCommandLib.h from edk2-platforms
to edk2/MdePkg. A NULL instance of IpmiCommandLib is created
and located under MdePkg. With above, RedfishPkg doesn't have the
dependence with edk2-platforms. The implementation of IpmiCommandLib
stays in edk2-platforms without relocation, which can be pulled in
to platform DSC as needed.
- PlatformHostInterfaceBmcUsbNic would be upstream to edk2-staging
temporarily because some requirements are necessray to be spec out
in the Redfish section in UEFI spec.
Signed-off-by: Abner Chang <abner.chang@amd.com>
Cc: Isaac Oram <isaac.w.oram@intel.com>
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Cc: Liming Gao <gaoliming@byosoft.com.cn>
Cc: Zhiguang Liu <zhiguang.liu@intel.com>
Cc: Nickle Wang <nicklew@nvidia.com>
Cc: Igor Kulchytskyy <igork@ami.com>
Abner Chang (3):
Features/IpmiFeaturePkg: Add IPMI functions
IpmiFeaturePkg/IpmiCommandLib: Add IPMI functions
IpmiFeaturePkg: Add reference of IpmiBaseLib
.../IpmiFeaturePkg/IpmiFeaturePkg.dec | 5 ++
.../Include/Library/IpmiCommandLib.h | 62 +++++++++++++
.../IpmiCommandLib/IpmiCommandLibNetFnApp.c | 88 +++++++++++++++++++
.../IpmiCommandLibNetFnTransport.c | 43 +++++++++
4 files changed, 198 insertions(+)
--
2.37.1.windows.1
^ permalink raw reply [flat|nested] 9+ messages in thread
* [edk2-platforms][PATCH V2] Features/IpmiFeaturePkg: Add IPMI functions
2023-01-05 16:00 [edk2-platforms][PATCH V2] IPMI changes for Redfish Chang, Abner
@ 2023-01-05 16:00 ` Chang, Abner
2023-01-05 16:00 ` [edk2-platforms][PATCH V2] IpmiFeaturePkg/IpmiCommandLib: " Chang, Abner
` (3 subsequent siblings)
4 siblings, 0 replies; 9+ messages in thread
From: Chang, Abner @ 2023-01-05 16:00 UTC (permalink / raw)
To: devel; +Cc: Isaac Oram, Nate DeSimone, Liming Gao, Nickle Wang,
Igor Kulchytskyy
From: Abner Chang <abner.chang@amd.com>
Add functions to get system UUID and LAN
configuration parameter.
Signed-off-by: Abner Chang <abner.chang@amd.com>
Cc: Isaac Oram <isaac.w.oram@intel.com>
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
Cc: Liming Gao <gaoliming@byosoft.com.cn>
Cc: Nickle Wang <nicklew@nvidia.com>
Cc: Igor Kulchytskyy <igork@ami.com>
---
.../Include/Library/IpmiCommandLib.h | 62 +++++++++++++++++++
1 file changed, 62 insertions(+)
diff --git a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Include/Library/IpmiCommandLib.h b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Include/Library/IpmiCommandLib.h
index 18f9d123c9..911b9c1d7a 100644
--- a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Include/Library/IpmiCommandLib.h
+++ b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Include/Library/IpmiCommandLib.h
@@ -2,6 +2,8 @@
This library abstract how to send/receive IPMI command.
Copyright (c) 2018-2021, Intel Corporation. All rights reserved.<BR>
+Copyright (C) 2023 Advanced Micro Devices, Inc. All rights reserved.<BR>
+
SPDX-License-Identifier: BSD-2-Clause-Patent
**/
@@ -88,6 +90,44 @@ IpmiSendMessage (
IN OUT UINT32 *SendMessageResponseSize
);
+/**
+ This function gets the system UUID.
+
+ @param[out] SystemGuid The pointer to retrieve system UUID.
+
+ @retval EFI_SUCCESS UUID is returned.
+ @retval EFI_INVALID_PARAMETER SystemGuid is a NULL pointer.
+ @retval Others Other errors.
+
+**/
+EFI_STATUS
+EFIAPI
+IpmiGetSystemUuid (
+ OUT EFI_GUID *SystemGuid
+ );
+
+/**
+ This function gets the channel information.
+
+ @param[in] GetChannelInfoRequest The get channel information request.
+ @param[out] GetChannelInfoResponse The get channel information response.
+ @param[out] GetChannelInfoResponseSize When input, the expected size of response.
+ When output, the exact size of the returned
+ response.
+
+ @retval EFI_SUCCESS Get channel information successfully.
+ @retval EFI_INVALID_PARAMETER One of the given input parameters is invalid.
+ @retval Others Other errors.
+
+**/
+EFI_STATUS
+EFIAPI
+IpmiGetChannelInfo (
+ IN IPMI_GET_CHANNEL_INFO_REQUEST *GetChannelInfoRequest,
+ OUT IPMI_GET_CHANNEL_INFO_RESPONSE *GetChannelInfoResponse,
+ OUT UINT32 *GetChannelInfoResponseSize
+ );
+
//
// NetFnTransport
//
@@ -114,6 +154,28 @@ IpmiGetSolConfigurationParameters (
IN OUT UINT32 *GetConfigurationParametersResponseSize
);
+/**
+ This function gets the LAN configuration parameter.
+
+ @param[in] GetLanConfigurationParametersRequest Request data
+ @param[out] GetLanConfigurationParametersResponse Response data
+ @param[in,out] GetLanConfigurationParametersSize When input, the expected size of response data.
+ When out, the exact size of response data.
+
+ @retval EFI_SUCCESS Lan configuration parameter is returned in the response.
+ @retval EFI_INVALID_PARAMETER One of the given input parameters is invalid.
+ @retval Others Other errors.
+
+**/
+
+EFI_STATUS
+EFIAPI
+IpmiGetLanConfigurationParameters (
+ IN IPMI_GET_LAN_CONFIGURATION_PARAMETERS_REQUEST *GetLanConfigurationParametersRequest,
+ OUT IPMI_GET_LAN_CONFIGURATION_PARAMETERS_RESPONSE *GetLanConfigurationParametersResponse,
+ IN OUT UINT32 *GetLanConfigurationParametersSize
+ );
+
//
// NetFnChasis
//
--
2.37.1.windows.1
^ permalink raw reply related [flat|nested] 9+ messages in thread
* [edk2-platforms][PATCH V2] IpmiFeaturePkg/IpmiCommandLib: Add IPMI functions
2023-01-05 16:00 [edk2-platforms][PATCH V2] IPMI changes for Redfish Chang, Abner
2023-01-05 16:00 ` [edk2-platforms][PATCH V2] Features/IpmiFeaturePkg: Add IPMI functions Chang, Abner
@ 2023-01-05 16:00 ` Chang, Abner
2023-01-05 16:01 ` [edk2-platforms][PATCH V2] IpmiFeaturePkg: Add reference of IpmiBaseLib Chang, Abner
` (2 subsequent siblings)
4 siblings, 0 replies; 9+ messages in thread
From: Chang, Abner @ 2023-01-05 16:00 UTC (permalink / raw)
To: devel; +Cc: Isaac Oram, Nate DeSimone, Liming Gao, Nickle Wang,
Igor Kulchytskyy
From: Abner Chang <abner.chang@amd.com>
Add functions to get system UUID and LAN
configuration parameter.
Signed-off-by: Abner Chang <abner.chang@amd.com>
Cc: Isaac Oram <isaac.w.oram@intel.com>
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
Cc: Liming Gao <gaoliming@byosoft.com.cn>
Cc: Nickle Wang <nicklew@nvidia.com>
Cc: Igor Kulchytskyy <igork@ami.com>
Reviewed-by: Isaac Oram <isaac.w.oram@intel.com>
---
.../IpmiCommandLib/IpmiCommandLibNetFnApp.c | 88 +++++++++++++++++++
.../IpmiCommandLibNetFnTransport.c | 43 +++++++++
2 files changed, 131 insertions(+)
diff --git a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Library/IpmiCommandLib/IpmiCommandLibNetFnApp.c b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Library/IpmiCommandLib/IpmiCommandLibNetFnApp.c
index addabc554e..2e34909f3e 100644
--- a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Library/IpmiCommandLib/IpmiCommandLibNetFnApp.c
+++ b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Library/IpmiCommandLib/IpmiCommandLibNetFnApp.c
@@ -2,6 +2,8 @@
IPMI Command - NetFnApp.
Copyright (c) 2018 - 2021, Intel Corporation. All rights reserved.<BR>
+ Copyright (C) 2023 Advanced Micro Devices, Inc. All rights reserved.<BR>
+
SPDX-License-Identifier: BSD-2-Clause-Patent
**/
@@ -245,3 +247,89 @@ IpmiSendMessage (
);
return Status;
}
+
+/**
+ This function gets the system UUID.
+
+ @param[out] SystemGuid The pointer to retrieve system UUID.
+
+ @retval EFI_SUCCESS UUID is returned.
+ @retval EFI_INVALID_PARAMETER SystemGuid is a NULL pointer.
+ @retval Others Other errors.
+
+**/
+EFI_STATUS
+EFIAPI
+IpmiGetSystemUuid (
+ OUT EFI_GUID *SystemGuid
+ )
+{
+ EFI_STATUS Status;
+ UINT32 RequestSize;
+ UINT32 ResponseSize;
+ IPMI_GET_SYSTEM_UUID_RESPONSE GetSystemUuidResponse;
+
+ if (SystemGuid == NULL) {
+ return EFI_INVALID_PARAMETER;
+ }
+ RequestSize = 0;
+ ResponseSize = sizeof (IPMI_GET_SYSTEM_UUID_RESPONSE);
+ Status = IpmiSubmitCommand (
+ IPMI_NETFN_APP,
+ IPMI_APP_GET_SYSTEM_GUID,
+ (VOID *)NULL,
+ RequestSize,
+ (VOID *)&GetSystemUuidResponse,
+ &ResponseSize
+ );
+ if (!EFI_ERROR (Status) && GetSystemUuidResponse.CompletionCode == IPMI_COMP_CODE_NORMAL) {
+ CopyMem (
+ (VOID *)SystemGuid,
+ (VOID *)&GetSystemUuidResponse.SystemUuid,
+ sizeof (EFI_GUID)
+ );
+ }
+ return Status;
+}
+
+/**
+ This function gets the channel information.
+
+ @param[in] GetChannelInfoRequest The get channel information request.
+ @param[out] GetChannelInfoResponse The get channel information response.
+ @param[out] GetChannelInfoResponseSize When input, the expected size of response.
+ When output, the exact size of the returned
+ response.
+
+ @retval EFI_SUCCESS Get channel information successfully.
+ @retval EFI_INVALID_PARAMETER One of the given input parameters is invalid.
+ @retval Others Other errors.
+
+**/
+EFI_STATUS
+EFIAPI
+IpmiGetChannelInfo (
+ IN IPMI_GET_CHANNEL_INFO_REQUEST *GetChannelInfoRequest,
+ OUT IPMI_GET_CHANNEL_INFO_RESPONSE *GetChannelInfoResponse,
+ OUT UINT32 *GetChannelInfoResponseSize
+ )
+{
+ EFI_STATUS Status;
+
+ if (GetChannelInfoRequest == NULL ||
+ GetChannelInfoResponse == NULL ||
+ GetChannelInfoResponseSize == NULL) {
+ return EFI_INVALID_PARAMETER;
+ }
+
+ *GetChannelInfoResponseSize = sizeof (IPMI_GET_CHANNEL_INFO_RESPONSE);
+ Status = IpmiSubmitCommand (
+ IPMI_NETFN_APP,
+ IPMI_APP_GET_CHANNEL_INFO,
+ (UINT8 *)GetChannelInfoRequest,
+ sizeof (IPMI_GET_CHANNEL_INFO_REQUEST),
+ (UINT8 *)GetChannelInfoResponse,
+ GetChannelInfoResponseSize
+ );
+ return Status;
+}
diff --git a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Library/IpmiCommandLib/IpmiCommandLibNetFnTransport.c b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Library/IpmiCommandLib/IpmiCommandLibNetFnTransport.c
index 7dfcf86126..30ea84c04b 100644
--- a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Library/IpmiCommandLib/IpmiCommandLibNetFnTransport.c
+++ b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Library/IpmiCommandLib/IpmiCommandLibNetFnTransport.c
@@ -2,6 +2,8 @@
IPMI Command - NetFnTransport.
Copyright (c) 2018 - 2021, Intel Corporation. All rights reserved.<BR>
+ Copyright (C) 2023 Advanced Micro Devices, Inc. All rights reserved.<BR>
+
SPDX-License-Identifier: BSD-2-Clause-Patent
**/
@@ -78,3 +80,44 @@ IpmiGetSolConfigurationParameters (
);
return Status;
}
+
+/**
+ This function gets the LAN configuration parameter.
+
+ @param[in] GetLanConfigurationParametersRequest Request data
+ @param[out] GetLanConfigurationParametersResponse Response data
+ @param[in,out] GetLanConfigurationParametersSize When input, the expected size of response data.
+ When out, the exact size of response data.
+
+ @retval EFI_SUCCESS Lan configuration parameter is returned in the response.
+ @retval EFI_INVALID_PARAMETER One of the given input parameters is invalid.
+ @retval Others Other errors.
+
+**/
+
+EFI_STATUS
+EFIAPI
+IpmiGetLanConfigurationParameters (
+ IN IPMI_GET_LAN_CONFIGURATION_PARAMETERS_REQUEST *GetLanConfigurationParametersRequest,
+ OUT IPMI_GET_LAN_CONFIGURATION_PARAMETERS_RESPONSE *GetLanConfigurationParametersResponse,
+ IN OUT UINT32 *GetLanConfigurationParametersSize
+ )
+{
+ EFI_STATUS Status;
+
+ if (GetLanConfigurationParametersRequest == NULL ||
+ GetLanConfigurationParametersResponse == NULL ||
+ GetLanConfigurationParametersSize == NULL) {
+ return EFI_INVALID_PARAMETER;
+ }
+
+ Status = IpmiSubmitCommand (
+ IPMI_NETFN_TRANSPORT,
+ IPMI_TRANSPORT_GET_LAN_CONFIG_PARAMETERS,
+ (UINT8 *)GetLanConfigurationParametersRequest,
+ sizeof(*GetLanConfigurationParametersRequest),
+ (UINT8 *)GetLanConfigurationParametersResponse,
+ GetLanConfigurationParametersSize
+ );
+ return Status;
+}
--
2.37.1.windows.1
^ permalink raw reply related [flat|nested] 9+ messages in thread
* [edk2-platforms][PATCH V2] IpmiFeaturePkg: Add reference of IpmiBaseLib
2023-01-05 16:00 [edk2-platforms][PATCH V2] IPMI changes for Redfish Chang, Abner
2023-01-05 16:00 ` [edk2-platforms][PATCH V2] Features/IpmiFeaturePkg: Add IPMI functions Chang, Abner
2023-01-05 16:00 ` [edk2-platforms][PATCH V2] IpmiFeaturePkg/IpmiCommandLib: " Chang, Abner
@ 2023-01-05 16:01 ` Chang, Abner
2023-01-05 17:05 ` [edk2-platforms][PATCH V2] IPMI changes for Redfish Isaac Oram
[not found] ` <17377895696F6651.2132@groups.io>
4 siblings, 0 replies; 9+ messages in thread
From: Chang, Abner @ 2023-01-05 16:01 UTC (permalink / raw)
To: devel; +Cc: Isaac Oram, Nate DeSimone, Liming Gao, Nickle Wang,
Igor Kulchytskyy
From: Abner Chang <abner.chang@amd.com>
Add reference of IpmiBaseLib
Signed-off-by: Abner Chang <abner.chang@amd.com>
Cc: Isaac Oram <isaac.w.oram@intel.com>
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
Cc: Liming Gao <gaoliming@byosoft.com.cn>
Cc: Nickle Wang <nicklew@nvidia.com>
Cc: Igor Kulchytskyy <igork@ami.com>
Reviewed-by: Isaac Oram <isaac.w.oram@intel.com>
---
.../OutOfBandManagement/IpmiFeaturePkg/IpmiFeaturePkg.dec | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/IpmiFeaturePkg.dec b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/IpmiFeaturePkg.dec
index 48f4ebf931..8c1b902446 100644
--- a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/IpmiFeaturePkg.dec
+++ b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/IpmiFeaturePkg.dec
@@ -8,6 +8,7 @@
# for the build infrastructure.
#
# Copyright (c) 2019-2021, Intel Corporation. All rights reserved.<BR>
+# Copyright (C) 2023 Advanced Micro Devices, Inc. All rights reserved.<BR>
#
# SPDX-License-Identifier: BSD-2-Clause-Patent
#
@@ -38,6 +39,10 @@
#
IpmiCommandLib|Include/Library/IpmiPlatformHookLib.h
+ ## @libraryclass Provides an API for the base IPMI library
+ #
+ IpmiBaseLib|Include/Library/IpmiBaseLib.h
+
[Guids]
gIpmiFeaturePkgTokenSpaceGuid = {0xc05283f6, 0xd6a8, 0x48f3, {0x9b, 0x59, 0xfb, 0xca, 0x71, 0x32, 0x0f, 0x12}}
--
2.37.1.windows.1
^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [edk2-platforms][PATCH V2] IPMI changes for Redfish
2023-01-05 16:00 [edk2-platforms][PATCH V2] IPMI changes for Redfish Chang, Abner
` (2 preceding siblings ...)
2023-01-05 16:01 ` [edk2-platforms][PATCH V2] IpmiFeaturePkg: Add reference of IpmiBaseLib Chang, Abner
@ 2023-01-05 17:05 ` Isaac Oram
[not found] ` <17377895696F6651.2132@groups.io>
4 siblings, 0 replies; 9+ messages in thread
From: Isaac Oram @ 2023-01-05 17:05 UTC (permalink / raw)
To: abner.chang@amd.com, devel@edk2.groups.io
Cc: Desimone, Nathaniel L, Kinney, Michael D, Gao, Liming,
Liu, Zhiguang, Nickle Wang, Igor Kulchytskyy
Series Reviewed-by: Isaac Oram <isaac.w.oram@intel.com>
-----Original Message-----
From: abner.chang@amd.com <abner.chang@amd.com>
Sent: Thursday, January 5, 2023 8:01 AM
To: devel@edk2.groups.io
Cc: Oram, Isaac W <isaac.w.oram@intel.com>; Desimone, Nathaniel L <nathaniel.l.desimone@intel.com>; Kinney, Michael D <michael.d.kinney@intel.com>; Gao, Liming <gaoliming@byosoft.com.cn>; Liu, Zhiguang <zhiguang.liu@intel.com>; Nickle Wang <nicklew@nvidia.com>; Igor Kulchytskyy <igork@ami.com>
Subject: [edk2-platforms][PATCH V2] IPMI changes for Redfish
From: Abner Chang <abner.chang@amd.com>
In V2: Addressed the comments from Isaac.
BZ# 4214
This patch adds IPMI functions for building up SMBIOS 42 record for the USB NIC host interface exposed by BMC.
The corresponding updates on edk2 is in the separate pacth.
This is the part I of upstream, the follow up patche sets are:
- RedfishPlatformCredentialLib contributed by NVidia.
- Relocate IpmiCommandLib.h from edk2-platforms
to edk2/MdePkg. A NULL instance of IpmiCommandLib is created
and located under MdePkg. With above, RedfishPkg doesn't have the
dependence with edk2-platforms. The implementation of IpmiCommandLib
stays in edk2-platforms without relocation, which can be pulled in
to platform DSC as needed.
- PlatformHostInterfaceBmcUsbNic would be upstream to edk2-staging
temporarily because some requirements are necessray to be spec out
in the Redfish section in UEFI spec.
Signed-off-by: Abner Chang <abner.chang@amd.com>
Cc: Isaac Oram <isaac.w.oram@intel.com>
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Cc: Liming Gao <gaoliming@byosoft.com.cn>
Cc: Zhiguang Liu <zhiguang.liu@intel.com>
Cc: Nickle Wang <nicklew@nvidia.com>
Cc: Igor Kulchytskyy <igork@ami.com>
Abner Chang (3):
Features/IpmiFeaturePkg: Add IPMI functions
IpmiFeaturePkg/IpmiCommandLib: Add IPMI functions
IpmiFeaturePkg: Add reference of IpmiBaseLib
.../IpmiFeaturePkg/IpmiFeaturePkg.dec | 5 ++
.../Include/Library/IpmiCommandLib.h | 62 +++++++++++++
.../IpmiCommandLib/IpmiCommandLibNetFnApp.c | 88 +++++++++++++++++++
.../IpmiCommandLibNetFnTransport.c | 43 +++++++++
4 files changed, 198 insertions(+)
--
2.37.1.windows.1
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [edk2-devel] [edk2-platforms][PATCH V2] IPMI changes for Redfish
[not found] ` <17377895696F6651.2132@groups.io>
@ 2023-01-05 17:41 ` Isaac Oram
2023-01-06 2:27 ` Chang, Abner
0 siblings, 1 reply; 9+ messages in thread
From: Isaac Oram @ 2023-01-05 17:41 UTC (permalink / raw)
To: devel@edk2.groups.io, Oram, Isaac W, abner.chang@amd.com
Cc: Desimone, Nathaniel L, Kinney, Michael D, Gao, Liming,
Liu, Zhiguang, Nickle Wang, Igor Kulchytskyy
Series pushed as: 28f3ce4a6a251de327b8d19c3316a654887f4f13.. f5da8af6befbfc655fd3e4cb899eda158dd9ede5
My apologies, I was sloppy and didn't ensure the edk2 changes were pushed first, so IpmiFeaturePkg build is currently broken pending https://edk2.groups.io/g/devel/message/97789being being pushed.
Regards,
Isaac
-----Original Message-----
From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Isaac Oram
Sent: Thursday, January 5, 2023 9:05 AM
To: abner.chang@amd.com; devel@edk2.groups.io
Cc: Desimone, Nathaniel L <nathaniel.l.desimone@intel.com>; Kinney, Michael D <michael.d.kinney@intel.com>; Gao, Liming <gaoliming@byosoft.com.cn>; Liu, Zhiguang <zhiguang.liu@intel.com>; Nickle Wang <nicklew@nvidia.com>; Igor Kulchytskyy <igork@ami.com>
Subject: Re: [edk2-devel] [edk2-platforms][PATCH V2] IPMI changes for Redfish
Series Reviewed-by: Isaac Oram <isaac.w.oram@intel.com>
-----Original Message-----
From: abner.chang@amd.com <abner.chang@amd.com>
Sent: Thursday, January 5, 2023 8:01 AM
To: devel@edk2.groups.io
Cc: Oram, Isaac W <isaac.w.oram@intel.com>; Desimone, Nathaniel L <nathaniel.l.desimone@intel.com>; Kinney, Michael D <michael.d.kinney@intel.com>; Gao, Liming <gaoliming@byosoft.com.cn>; Liu, Zhiguang <zhiguang.liu@intel.com>; Nickle Wang <nicklew@nvidia.com>; Igor Kulchytskyy <igork@ami.com>
Subject: [edk2-platforms][PATCH V2] IPMI changes for Redfish
From: Abner Chang <abner.chang@amd.com>
In V2: Addressed the comments from Isaac.
BZ# 4214
This patch adds IPMI functions for building up SMBIOS 42 record for the USB NIC host interface exposed by BMC.
The corresponding updates on edk2 is in the separate pacth.
This is the part I of upstream, the follow up patche sets are:
- RedfishPlatformCredentialLib contributed by NVidia.
- Relocate IpmiCommandLib.h from edk2-platforms
to edk2/MdePkg. A NULL instance of IpmiCommandLib is created
and located under MdePkg. With above, RedfishPkg doesn't have the
dependence with edk2-platforms. The implementation of IpmiCommandLib
stays in edk2-platforms without relocation, which can be pulled in
to platform DSC as needed.
- PlatformHostInterfaceBmcUsbNic would be upstream to edk2-staging
temporarily because some requirements are necessray to be spec out
in the Redfish section in UEFI spec.
Signed-off-by: Abner Chang <abner.chang@amd.com>
Cc: Isaac Oram <isaac.w.oram@intel.com>
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Cc: Liming Gao <gaoliming@byosoft.com.cn>
Cc: Zhiguang Liu <zhiguang.liu@intel.com>
Cc: Nickle Wang <nicklew@nvidia.com>
Cc: Igor Kulchytskyy <igork@ami.com>
Abner Chang (3):
Features/IpmiFeaturePkg: Add IPMI functions
IpmiFeaturePkg/IpmiCommandLib: Add IPMI functions
IpmiFeaturePkg: Add reference of IpmiBaseLib
.../IpmiFeaturePkg/IpmiFeaturePkg.dec | 5 ++
.../Include/Library/IpmiCommandLib.h | 62 +++++++++++++
.../IpmiCommandLib/IpmiCommandLibNetFnApp.c | 88 +++++++++++++++++++
.../IpmiCommandLibNetFnTransport.c | 43 +++++++++
4 files changed, 198 insertions(+)
--
2.37.1.windows.1
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [edk2-devel] [edk2-platforms][PATCH V2] IPMI changes for Redfish
2023-01-05 17:41 ` [edk2-devel] " Isaac Oram
@ 2023-01-06 2:27 ` Chang, Abner
2023-01-11 23:14 ` Isaac Oram
0 siblings, 1 reply; 9+ messages in thread
From: Chang, Abner @ 2023-01-06 2:27 UTC (permalink / raw)
To: Oram, Isaac W, devel@edk2.groups.io
Cc: Desimone, Nathaniel L, Kinney, Michael D, Gao, Liming,
Liu, Zhiguang, Nickle Wang, Igor Kulchytskyy
[AMD Official Use Only - General]
Hi Isaac,
I am not quite understand, this patch set should be independent of edk2. What do you mean the edk2 changes were pushed first? Or IpmiFeaturePkg is good now?
Abner
> -----Original Message-----
> From: Oram, Isaac W <isaac.w.oram@intel.com>
> Sent: Friday, January 6, 2023 1:42 AM
> To: devel@edk2.groups.io; Oram, Isaac W <isaac.w.oram@intel.com>; Chang,
> Abner <Abner.Chang@amd.com>
> Cc: Desimone, Nathaniel L <nathaniel.l.desimone@intel.com>; Kinney,
> Michael D <michael.d.kinney@intel.com>; Gao, Liming
> <gaoliming@byosoft.com.cn>; Liu, Zhiguang <zhiguang.liu@intel.com>;
> Nickle Wang <nicklew@nvidia.com>; Igor Kulchytskyy <igork@ami.com>
> Subject: RE: [edk2-devel] [edk2-platforms][PATCH V2] IPMI changes for
> Redfish
>
> Caution: This message originated from an External Source. Use proper
> caution when opening attachments, clicking links, or responding.
>
>
> Series pushed as: 28f3ce4a6a251de327b8d19c3316a654887f4f13..
> f5da8af6befbfc655fd3e4cb899eda158dd9ede5
>
> My apologies, I was sloppy and didn't ensure the edk2 changes were pushed
> first, so IpmiFeaturePkg build is currently broken pending
> https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fedk
> 2.groups.io%2Fg%2Fdevel%2Fmessage%2F97789being&data=05%7C01%7Ca
> bner.chang%40amd.com%7C6301c092067c4f19a1b208daef441af4%7C3dd896
> 1fe4884e608e11a82d994e183d%7C0%7C0%7C638085373047816357%7CUnkn
> own%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik
> 1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=tBhHMIQhVL8AI3bof
> YIPHcTIzobpQ7lgZgwFJa0z0Gc%3D&reserved=0 being pushed.
>
> Regards,
> Isaac
>
>
> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Isaac
> Oram
> Sent: Thursday, January 5, 2023 9:05 AM
> To: abner.chang@amd.com; devel@edk2.groups.io
> Cc: Desimone, Nathaniel L <nathaniel.l.desimone@intel.com>; Kinney,
> Michael D <michael.d.kinney@intel.com>; Gao, Liming
> <gaoliming@byosoft.com.cn>; Liu, Zhiguang <zhiguang.liu@intel.com>;
> Nickle Wang <nicklew@nvidia.com>; Igor Kulchytskyy <igork@ami.com>
> Subject: Re: [edk2-devel] [edk2-platforms][PATCH V2] IPMI changes for
> Redfish
>
> Series Reviewed-by: Isaac Oram <isaac.w.oram@intel.com>
>
> -----Original Message-----
> From: abner.chang@amd.com <abner.chang@amd.com>
> Sent: Thursday, January 5, 2023 8:01 AM
> To: devel@edk2.groups.io
> Cc: Oram, Isaac W <isaac.w.oram@intel.com>; Desimone, Nathaniel L
> <nathaniel.l.desimone@intel.com>; Kinney, Michael D
> <michael.d.kinney@intel.com>; Gao, Liming <gaoliming@byosoft.com.cn>;
> Liu, Zhiguang <zhiguang.liu@intel.com>; Nickle Wang <nicklew@nvidia.com>;
> Igor Kulchytskyy <igork@ami.com>
> Subject: [edk2-platforms][PATCH V2] IPMI changes for Redfish
>
> From: Abner Chang <abner.chang@amd.com>
>
> In V2: Addressed the comments from Isaac.
>
> BZ# 4214
> This patch adds IPMI functions for building up SMBIOS 42 record for the USB
> NIC host interface exposed by BMC.
> The corresponding updates on edk2 is in the separate pacth.
>
> This is the part I of upstream, the follow up patche sets are:
> - RedfishPlatformCredentialLib contributed by NVidia.
> - Relocate IpmiCommandLib.h from edk2-platforms
> to edk2/MdePkg. A NULL instance of IpmiCommandLib is created
> and located under MdePkg. With above, RedfishPkg doesn't have the
> dependence with edk2-platforms. The implementation of IpmiCommandLib
> stays in edk2-platforms without relocation, which can be pulled in
> to platform DSC as needed.
> - PlatformHostInterfaceBmcUsbNic would be upstream to edk2-staging
> temporarily because some requirements are necessray to be spec out
> in the Redfish section in UEFI spec.
>
> Signed-off-by: Abner Chang <abner.chang@amd.com>
> Cc: Isaac Oram <isaac.w.oram@intel.com>
> Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> Cc: Zhiguang Liu <zhiguang.liu@intel.com>
> Cc: Nickle Wang <nicklew@nvidia.com>
> Cc: Igor Kulchytskyy <igork@ami.com>
>
> Abner Chang (3):
> Features/IpmiFeaturePkg: Add IPMI functions
> IpmiFeaturePkg/IpmiCommandLib: Add IPMI functions
> IpmiFeaturePkg: Add reference of IpmiBaseLib
>
> .../IpmiFeaturePkg/IpmiFeaturePkg.dec | 5 ++
> .../Include/Library/IpmiCommandLib.h | 62 +++++++++++++
> .../IpmiCommandLib/IpmiCommandLibNetFnApp.c | 88
> +++++++++++++++++++
> .../IpmiCommandLibNetFnTransport.c | 43 +++++++++
> 4 files changed, 198 insertions(+)
>
> --
> 2.37.1.windows.1
>
>
>
>
>
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [edk2-devel] [edk2-platforms][PATCH V2] IPMI changes for Redfish
2023-01-06 2:27 ` Chang, Abner
@ 2023-01-11 23:14 ` Isaac Oram
2023-01-12 8:33 ` Chang, Abner
0 siblings, 1 reply; 9+ messages in thread
From: Isaac Oram @ 2023-01-11 23:14 UTC (permalink / raw)
To: Chang, Abner, devel@edk2.groups.io
Cc: Desimone, Nathaniel L, Kinney, Michael D, Gao, Liming,
Liu, Zhiguang, Nickle Wang, Igor Kulchytskyy
I believe that this edk2-platforms series is dependent on the changes in https://edk2.groups.io/g/devel/message/98051 and they have not been merged yet.
I had those changes under review in the branch I used for testing this patch series for edk2-platforms so my testing missed this.
Regards,
Isaac
-----Original Message-----
From: Chang, Abner <Abner.Chang@amd.com>
Sent: Thursday, January 5, 2023 6:27 PM
To: Oram, Isaac W <isaac.w.oram@intel.com>; devel@edk2.groups.io
Cc: Desimone, Nathaniel L <nathaniel.l.desimone@intel.com>; Kinney, Michael D <michael.d.kinney@intel.com>; Gao, Liming <gaoliming@byosoft.com.cn>; Liu, Zhiguang <zhiguang.liu@intel.com>; Nickle Wang <nicklew@nvidia.com>; Igor Kulchytskyy <igork@ami.com>
Subject: RE: [edk2-devel] [edk2-platforms][PATCH V2] IPMI changes for Redfish
[AMD Official Use Only - General]
Hi Isaac,
I am not quite understand, this patch set should be independent of edk2. What do you mean the edk2 changes were pushed first? Or IpmiFeaturePkg is good now?
Abner
> -----Original Message-----
> From: Oram, Isaac W <isaac.w.oram@intel.com>
> Sent: Friday, January 6, 2023 1:42 AM
> To: devel@edk2.groups.io; Oram, Isaac W <isaac.w.oram@intel.com>;
> Chang, Abner <Abner.Chang@amd.com>
> Cc: Desimone, Nathaniel L <nathaniel.l.desimone@intel.com>; Kinney,
> Michael D <michael.d.kinney@intel.com>; Gao, Liming
> <gaoliming@byosoft.com.cn>; Liu, Zhiguang <zhiguang.liu@intel.com>;
> Nickle Wang <nicklew@nvidia.com>; Igor Kulchytskyy <igork@ami.com>
> Subject: RE: [edk2-devel] [edk2-platforms][PATCH V2] IPMI changes for
> Redfish
>
> Caution: This message originated from an External Source. Use proper
> caution when opening attachments, clicking links, or responding.
>
>
> Series pushed as: 28f3ce4a6a251de327b8d19c3316a654887f4f13..
> f5da8af6befbfc655fd3e4cb899eda158dd9ede5
>
> My apologies, I was sloppy and didn't ensure the edk2 changes were
> pushed first, so IpmiFeaturePkg build is currently broken pending
> https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fedk
> 2.groups.io%2Fg%2Fdevel%2Fmessage%2F97789being&data=05%7C01%7Ca
> bner.chang%40amd.com%7C6301c092067c4f19a1b208daef441af4%7C3dd896
> 1fe4884e608e11a82d994e183d%7C0%7C0%7C638085373047816357%7CUnkn
> own%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik
> 1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=tBhHMIQhVL8AI3bof
> YIPHcTIzobpQ7lgZgwFJa0z0Gc%3D&reserved=0 being pushed.
>
> Regards,
> Isaac
>
>
> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Isaac
> Oram
> Sent: Thursday, January 5, 2023 9:05 AM
> To: abner.chang@amd.com; devel@edk2.groups.io
> Cc: Desimone, Nathaniel L <nathaniel.l.desimone@intel.com>; Kinney,
> Michael D <michael.d.kinney@intel.com>; Gao, Liming
> <gaoliming@byosoft.com.cn>; Liu, Zhiguang <zhiguang.liu@intel.com>;
> Nickle Wang <nicklew@nvidia.com>; Igor Kulchytskyy <igork@ami.com>
> Subject: Re: [edk2-devel] [edk2-platforms][PATCH V2] IPMI changes for
> Redfish
>
> Series Reviewed-by: Isaac Oram <isaac.w.oram@intel.com>
>
> -----Original Message-----
> From: abner.chang@amd.com <abner.chang@amd.com>
> Sent: Thursday, January 5, 2023 8:01 AM
> To: devel@edk2.groups.io
> Cc: Oram, Isaac W <isaac.w.oram@intel.com>; Desimone, Nathaniel L
> <nathaniel.l.desimone@intel.com>; Kinney, Michael D
> <michael.d.kinney@intel.com>; Gao, Liming <gaoliming@byosoft.com.cn>;
> Liu, Zhiguang <zhiguang.liu@intel.com>; Nickle Wang
> <nicklew@nvidia.com>; Igor Kulchytskyy <igork@ami.com>
> Subject: [edk2-platforms][PATCH V2] IPMI changes for Redfish
>
> From: Abner Chang <abner.chang@amd.com>
>
> In V2: Addressed the comments from Isaac.
>
> BZ# 4214
> This patch adds IPMI functions for building up SMBIOS 42 record for
> the USB NIC host interface exposed by BMC.
> The corresponding updates on edk2 is in the separate pacth.
>
> This is the part I of upstream, the follow up patche sets are:
> - RedfishPlatformCredentialLib contributed by NVidia.
> - Relocate IpmiCommandLib.h from edk2-platforms
> to edk2/MdePkg. A NULL instance of IpmiCommandLib is created
> and located under MdePkg. With above, RedfishPkg doesn't have the
> dependence with edk2-platforms. The implementation of IpmiCommandLib
> stays in edk2-platforms without relocation, which can be pulled in
> to platform DSC as needed.
> - PlatformHostInterfaceBmcUsbNic would be upstream to edk2-staging
> temporarily because some requirements are necessray to be spec out
> in the Redfish section in UEFI spec.
>
> Signed-off-by: Abner Chang <abner.chang@amd.com>
> Cc: Isaac Oram <isaac.w.oram@intel.com>
> Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> Cc: Zhiguang Liu <zhiguang.liu@intel.com>
> Cc: Nickle Wang <nicklew@nvidia.com>
> Cc: Igor Kulchytskyy <igork@ami.com>
>
> Abner Chang (3):
> Features/IpmiFeaturePkg: Add IPMI functions
> IpmiFeaturePkg/IpmiCommandLib: Add IPMI functions
> IpmiFeaturePkg: Add reference of IpmiBaseLib
>
> .../IpmiFeaturePkg/IpmiFeaturePkg.dec | 5 ++
> .../Include/Library/IpmiCommandLib.h | 62 +++++++++++++
> .../IpmiCommandLib/IpmiCommandLibNetFnApp.c | 88
> +++++++++++++++++++
> .../IpmiCommandLibNetFnTransport.c | 43 +++++++++
> 4 files changed, 198 insertions(+)
>
> --
> 2.37.1.windows.1
>
>
>
>
>
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [edk2-devel] [edk2-platforms][PATCH V2] IPMI changes for Redfish
2023-01-11 23:14 ` Isaac Oram
@ 2023-01-12 8:33 ` Chang, Abner
0 siblings, 0 replies; 9+ messages in thread
From: Chang, Abner @ 2023-01-12 8:33 UTC (permalink / raw)
To: Oram, Isaac W, devel@edk2.groups.io
Cc: Desimone, Nathaniel L, Kinney, Michael D, Gao, Liming,
Liu, Zhiguang, Nickle Wang, Igor Kulchytskyy
[AMD Official Use Only - General]
OK, I see.
So Isaac, could you please help to check below series of patch?
https://edk2.groups.io/g/devel/message/97769?p=%2C%2C%2C20%2C0%2C0%2C0%3A%3ACreated%2C%2CAdd+NULL+instance+library%2C20%2C2%2C0%2C95915689
I will check with MdeMoudulePkg maintainers to see if they are ok with these IPMI patch sets once you give the reviewed-by to above one. We will need them to merge the code.
Thanks
Abner
> -----Original Message-----
> From: Oram, Isaac W <isaac.w.oram@intel.com>
> Sent: Thursday, January 12, 2023 7:15 AM
> To: Chang, Abner <Abner.Chang@amd.com>; devel@edk2.groups.io
> Cc: Desimone, Nathaniel L <nathaniel.l.desimone@intel.com>; Kinney,
> Michael D <michael.d.kinney@intel.com>; Gao, Liming
> <gaoliming@byosoft.com.cn>; Liu, Zhiguang <zhiguang.liu@intel.com>;
> Nickle Wang <nicklew@nvidia.com>; Igor Kulchytskyy <igork@ami.com>
> Subject: RE: [edk2-devel] [edk2-platforms][PATCH V2] IPMI changes for
> Redfish
>
> Caution: This message originated from an External Source. Use proper
> caution when opening attachments, clicking links, or responding.
>
>
> I believe that this edk2-platforms series is dependent on the changes in
> https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fedk
> 2.groups.io%2Fg%2Fdevel%2Fmessage%2F98051&data=05%7C01%7CAbner.
> Chang%40amd.com%7C1e8dfb9b78f245437e6f08daf4299d00%7C3dd8961fe4
> 884e608e11a82d994e183d%7C0%7C0%7C638090756807764009%7CUnknown
> %7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1ha
> WwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=XZQBaA%2FaxIWEbRSD
> DVpO7qznlraJEh4UjeHAV30qu1E%3D&reserved=0 and they have not been
> merged yet.
> I had those changes under review in the branch I used for testing this patch
> series for edk2-platforms so my testing missed this.
>
> Regards,
> Isaac
>
> -----Original Message-----
> From: Chang, Abner <Abner.Chang@amd.com>
> Sent: Thursday, January 5, 2023 6:27 PM
> To: Oram, Isaac W <isaac.w.oram@intel.com>; devel@edk2.groups.io
> Cc: Desimone, Nathaniel L <nathaniel.l.desimone@intel.com>; Kinney,
> Michael D <michael.d.kinney@intel.com>; Gao, Liming
> <gaoliming@byosoft.com.cn>; Liu, Zhiguang <zhiguang.liu@intel.com>;
> Nickle Wang <nicklew@nvidia.com>; Igor Kulchytskyy <igork@ami.com>
> Subject: RE: [edk2-devel] [edk2-platforms][PATCH V2] IPMI changes for
> Redfish
>
> [AMD Official Use Only - General]
>
> Hi Isaac,
> I am not quite understand, this patch set should be independent of edk2.
> What do you mean the edk2 changes were pushed first? Or IpmiFeaturePkg
> is good now?
>
> Abner
>
> > -----Original Message-----
> > From: Oram, Isaac W <isaac.w.oram@intel.com>
> > Sent: Friday, January 6, 2023 1:42 AM
> > To: devel@edk2.groups.io; Oram, Isaac W <isaac.w.oram@intel.com>;
> > Chang, Abner <Abner.Chang@amd.com>
> > Cc: Desimone, Nathaniel L <nathaniel.l.desimone@intel.com>; Kinney,
> > Michael D <michael.d.kinney@intel.com>; Gao, Liming
> > <gaoliming@byosoft.com.cn>; Liu, Zhiguang <zhiguang.liu@intel.com>;
> > Nickle Wang <nicklew@nvidia.com>; Igor Kulchytskyy <igork@ami.com>
> > Subject: RE: [edk2-devel] [edk2-platforms][PATCH V2] IPMI changes for
> > Redfish
> >
> > Caution: This message originated from an External Source. Use proper
> > caution when opening attachments, clicking links, or responding.
> >
> >
> > Series pushed as: 28f3ce4a6a251de327b8d19c3316a654887f4f13..
> > f5da8af6befbfc655fd3e4cb899eda158dd9ede5
> >
> > My apologies, I was sloppy and didn't ensure the edk2 changes were
> > pushed first, so IpmiFeaturePkg build is currently broken pending
> >
> https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fedk
> %
> >
> 2F&data=05%7C01%7CAbner.Chang%40amd.com%7C1e8dfb9b78f245437e6f
> 08daf429
> >
> 9d00%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C6380907568077
> 64009%7
> >
> CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJ
> BTiI6Ik1
> >
> haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=dqY%2FUy5q88%2B3
> GOiVpSkPSxHF
> > Wlqma7DQKrgQiStT3ng%3D&reserved=0
> >
> 2.groups.io%2Fg%2Fdevel%2Fmessage%2F97789being&data=05%7C01%7Ca
> >
> bner.chang%40amd.com%7C6301c092067c4f19a1b208daef441af4%7C3dd896
> >
> 1fe4884e608e11a82d994e183d%7C0%7C0%7C638085373047816357%7CUnkn
> >
> own%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik
> >
> 1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=tBhHMIQhVL8AI3bof
> > YIPHcTIzobpQ7lgZgwFJa0z0Gc%3D&reserved=0 being pushed.
> >
> > Regards,
> > Isaac
> >
> >
> > -----Original Message-----
> > From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Isaac
> > Oram
> > Sent: Thursday, January 5, 2023 9:05 AM
> > To: abner.chang@amd.com; devel@edk2.groups.io
> > Cc: Desimone, Nathaniel L <nathaniel.l.desimone@intel.com>; Kinney,
> > Michael D <michael.d.kinney@intel.com>; Gao, Liming
> > <gaoliming@byosoft.com.cn>; Liu, Zhiguang <zhiguang.liu@intel.com>;
> > Nickle Wang <nicklew@nvidia.com>; Igor Kulchytskyy <igork@ami.com>
> > Subject: Re: [edk2-devel] [edk2-platforms][PATCH V2] IPMI changes for
> > Redfish
> >
> > Series Reviewed-by: Isaac Oram <isaac.w.oram@intel.com>
> >
> > -----Original Message-----
> > From: abner.chang@amd.com <abner.chang@amd.com>
> > Sent: Thursday, January 5, 2023 8:01 AM
> > To: devel@edk2.groups.io
> > Cc: Oram, Isaac W <isaac.w.oram@intel.com>; Desimone, Nathaniel L
> > <nathaniel.l.desimone@intel.com>; Kinney, Michael D
> > <michael.d.kinney@intel.com>; Gao, Liming <gaoliming@byosoft.com.cn>;
> > Liu, Zhiguang <zhiguang.liu@intel.com>; Nickle Wang
> > <nicklew@nvidia.com>; Igor Kulchytskyy <igork@ami.com>
> > Subject: [edk2-platforms][PATCH V2] IPMI changes for Redfish
> >
> > From: Abner Chang <abner.chang@amd.com>
> >
> > In V2: Addressed the comments from Isaac.
> >
> > BZ# 4214
> > This patch adds IPMI functions for building up SMBIOS 42 record for
> > the USB NIC host interface exposed by BMC.
> > The corresponding updates on edk2 is in the separate pacth.
> >
> > This is the part I of upstream, the follow up patche sets are:
> > - RedfishPlatformCredentialLib contributed by NVidia.
> > - Relocate IpmiCommandLib.h from edk2-platforms
> > to edk2/MdePkg. A NULL instance of IpmiCommandLib is created
> > and located under MdePkg. With above, RedfishPkg doesn't have the
> > dependence with edk2-platforms. The implementation of
> IpmiCommandLib
> > stays in edk2-platforms without relocation, which can be pulled in
> > to platform DSC as needed.
> > - PlatformHostInterfaceBmcUsbNic would be upstream to edk2-staging
> > temporarily because some requirements are necessray to be spec out
> > in the Redfish section in UEFI spec.
> >
> > Signed-off-by: Abner Chang <abner.chang@amd.com>
> > Cc: Isaac Oram <isaac.w.oram@intel.com>
> > Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
> > Cc: Michael D Kinney <michael.d.kinney@intel.com>
> > Cc: Liming Gao <gaoliming@byosoft.com.cn>
> > Cc: Zhiguang Liu <zhiguang.liu@intel.com>
> > Cc: Nickle Wang <nicklew@nvidia.com>
> > Cc: Igor Kulchytskyy <igork@ami.com>
> >
> > Abner Chang (3):
> > Features/IpmiFeaturePkg: Add IPMI functions
> > IpmiFeaturePkg/IpmiCommandLib: Add IPMI functions
> > IpmiFeaturePkg: Add reference of IpmiBaseLib
> >
> > .../IpmiFeaturePkg/IpmiFeaturePkg.dec | 5 ++
> > .../Include/Library/IpmiCommandLib.h | 62 +++++++++++++
> > .../IpmiCommandLib/IpmiCommandLibNetFnApp.c | 88
> > +++++++++++++++++++
> > .../IpmiCommandLibNetFnTransport.c | 43 +++++++++
> > 4 files changed, 198 insertions(+)
> >
> > --
> > 2.37.1.windows.1
> >
> >
> >
> >
> >
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2023-01-12 8:33 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-01-05 16:00 [edk2-platforms][PATCH V2] IPMI changes for Redfish Chang, Abner
2023-01-05 16:00 ` [edk2-platforms][PATCH V2] Features/IpmiFeaturePkg: Add IPMI functions Chang, Abner
2023-01-05 16:00 ` [edk2-platforms][PATCH V2] IpmiFeaturePkg/IpmiCommandLib: " Chang, Abner
2023-01-05 16:01 ` [edk2-platforms][PATCH V2] IpmiFeaturePkg: Add reference of IpmiBaseLib Chang, Abner
2023-01-05 17:05 ` [edk2-platforms][PATCH V2] IPMI changes for Redfish Isaac Oram
[not found] ` <17377895696F6651.2132@groups.io>
2023-01-05 17:41 ` [edk2-devel] " Isaac Oram
2023-01-06 2:27 ` Chang, Abner
2023-01-11 23:14 ` Isaac Oram
2023-01-12 8:33 ` Chang, Abner
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox