* [PATCH edk2-platforms] Platform/RPi4: Add EFI_MP_SERVICES_PROTOCOL support
@ 2023-01-05 17:01 Ard Biesheuvel
2023-01-06 6:52 ` [edk2-devel] " Laszlo Ersek
2023-01-06 17:39 ` quic_rcran
0 siblings, 2 replies; 3+ messages in thread
From: Ard Biesheuvel @ 2023-01-05 17:01 UTC (permalink / raw)
To: devel; +Cc: quic_llindhol, rebecca, Ard Biesheuvel
Fix the ARM_MPCORE_INFO table and incorporate the DXE driver and test
app to the build so that EFI_MP_SERVICES_PROTOCOL can be used and tested
on Raspberry Pi 4. Note that the test app is not added to the image - it
can be taken from the build directory and executed from the UEFI shell.
Signed-off-by: Ard Biesheuvel <ardb@kernel.org>
---
Platform/RaspberryPi/RPi4/RPi4.dsc | 3 +++
Platform/RaspberryPi/RPi4/RPi4.fdf | 1 +
Platform/RaspberryPi/Library/PlatformLib/RaspberryPi.c | 8 ++++----
3 files changed, 8 insertions(+), 4 deletions(-)
diff --git a/Platform/RaspberryPi/RPi4/RPi4.dsc b/Platform/RaspberryPi/RPi4/RPi4.dsc
index 8ba0ca61851e..4b2b6d1e4b97 100644
--- a/Platform/RaspberryPi/RPi4/RPi4.dsc
+++ b/Platform/RaspberryPi/RPi4/RPi4.dsc
@@ -795,3 +795,6 @@ [Components.common]
gEfiShellPkgTokenSpaceGuid.PcdShellLibAutoInitialize|FALSE
}
!endif
+
+ ArmPkg/Drivers/ArmPsciMpServicesDxe/ArmPsciMpServicesDxe.inf
+ MdeModulePkg/Application/MpServicesTest/MpServicesTest.inf
diff --git a/Platform/RaspberryPi/RPi4/RPi4.fdf b/Platform/RaspberryPi/RPi4/RPi4.fdf
index 0c782d2f3553..816927761513 100644
--- a/Platform/RaspberryPi/RPi4/RPi4.fdf
+++ b/Platform/RaspberryPi/RPi4/RPi4.fdf
@@ -198,6 +198,7 @@ [FV.FvMain]
INF EmbeddedPkg/RealTimeClockRuntimeDxe/RealTimeClockRuntimeDxe.inf
INF EmbeddedPkg/MetronomeDxe/MetronomeDxe.inf
INF MdeModulePkg/Universal/HiiDatabaseDxe/HiiDatabaseDxe.inf
+ INF ArmPkg/Drivers/ArmPsciMpServicesDxe/ArmPsciMpServicesDxe.inf
#
# Multiple Console IO support
diff --git a/Platform/RaspberryPi/Library/PlatformLib/RaspberryPi.c b/Platform/RaspberryPi/Library/PlatformLib/RaspberryPi.c
index f032f3c79238..0b0943431889 100644
--- a/Platform/RaspberryPi/Library/PlatformLib/RaspberryPi.c
+++ b/Platform/RaspberryPi/Library/PlatformLib/RaspberryPi.c
@@ -51,10 +51,10 @@ ArmPlatformInitializeSystemMemory (
}
STATIC ARM_CORE_INFO mRpi3InfoTable[] = {
- { 0x0, 0x0, }, // Cluster 0, Core 0
- { 0x0, 0x1, }, // Cluster 0, Core 1
- { 0x0, 0x2, }, // Cluster 0, Core 2
- { 0x0, 0x3, }, // Cluster 0, Core 3
+ { 0x0, }, // Cluster 0, Core 0
+ { 0x1, }, // Cluster 0, Core 1
+ { 0x2, }, // Cluster 0, Core 2
+ { 0x3, }, // Cluster 0, Core 3
};
STATIC
--
2.39.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [edk2-devel] [PATCH edk2-platforms] Platform/RPi4: Add EFI_MP_SERVICES_PROTOCOL support
2023-01-05 17:01 [PATCH edk2-platforms] Platform/RPi4: Add EFI_MP_SERVICES_PROTOCOL support Ard Biesheuvel
@ 2023-01-06 6:52 ` Laszlo Ersek
2023-01-06 17:39 ` quic_rcran
1 sibling, 0 replies; 3+ messages in thread
From: Laszlo Ersek @ 2023-01-06 6:52 UTC (permalink / raw)
To: devel, ardb; +Cc: quic_llindhol, rebecca
On 1/5/23 18:01, Ard Biesheuvel wrote:
> Fix the ARM_MPCORE_INFO table and incorporate the DXE driver and test
> app to the build so that EFI_MP_SERVICES_PROTOCOL can be used and tested
> on Raspberry Pi 4. Note that the test app is not added to the image - it
> can be taken from the build directory and executed from the UEFI shell.
>
> Signed-off-by: Ard Biesheuvel <ardb@kernel.org>
> ---
> Platform/RaspberryPi/RPi4/RPi4.dsc | 3 +++
> Platform/RaspberryPi/RPi4/RPi4.fdf | 1 +
> Platform/RaspberryPi/Library/PlatformLib/RaspberryPi.c | 8 ++++----
> 3 files changed, 8 insertions(+), 4 deletions(-)
>
> diff --git a/Platform/RaspberryPi/RPi4/RPi4.dsc b/Platform/RaspberryPi/RPi4/RPi4.dsc
> index 8ba0ca61851e..4b2b6d1e4b97 100644
> --- a/Platform/RaspberryPi/RPi4/RPi4.dsc
> +++ b/Platform/RaspberryPi/RPi4/RPi4.dsc
> @@ -795,3 +795,6 @@ [Components.common]
> gEfiShellPkgTokenSpaceGuid.PcdShellLibAutoInitialize|FALSE
> }
> !endif
> +
> + ArmPkg/Drivers/ArmPsciMpServicesDxe/ArmPsciMpServicesDxe.inf
> + MdeModulePkg/Application/MpServicesTest/MpServicesTest.inf
> diff --git a/Platform/RaspberryPi/RPi4/RPi4.fdf b/Platform/RaspberryPi/RPi4/RPi4.fdf
> index 0c782d2f3553..816927761513 100644
> --- a/Platform/RaspberryPi/RPi4/RPi4.fdf
> +++ b/Platform/RaspberryPi/RPi4/RPi4.fdf
> @@ -198,6 +198,7 @@ [FV.FvMain]
> INF EmbeddedPkg/RealTimeClockRuntimeDxe/RealTimeClockRuntimeDxe.inf
> INF EmbeddedPkg/MetronomeDxe/MetronomeDxe.inf
> INF MdeModulePkg/Universal/HiiDatabaseDxe/HiiDatabaseDxe.inf
> + INF ArmPkg/Drivers/ArmPsciMpServicesDxe/ArmPsciMpServicesDxe.inf
>
> #
> # Multiple Console IO support
> diff --git a/Platform/RaspberryPi/Library/PlatformLib/RaspberryPi.c b/Platform/RaspberryPi/Library/PlatformLib/RaspberryPi.c
> index f032f3c79238..0b0943431889 100644
> --- a/Platform/RaspberryPi/Library/PlatformLib/RaspberryPi.c
> +++ b/Platform/RaspberryPi/Library/PlatformLib/RaspberryPi.c
> @@ -51,10 +51,10 @@ ArmPlatformInitializeSystemMemory (
> }
>
> STATIC ARM_CORE_INFO mRpi3InfoTable[] = {
> - { 0x0, 0x0, }, // Cluster 0, Core 0
> - { 0x0, 0x1, }, // Cluster 0, Core 1
> - { 0x0, 0x2, }, // Cluster 0, Core 2
> - { 0x0, 0x3, }, // Cluster 0, Core 3
> + { 0x0, }, // Cluster 0, Core 0
> + { 0x1, }, // Cluster 0, Core 1
> + { 0x2, }, // Cluster 0, Core 2
> + { 0x3, }, // Cluster 0, Core 3
> };
>
> STATIC
Acked-by: Laszlo Ersek <lersek@redhat.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH edk2-platforms] Platform/RPi4: Add EFI_MP_SERVICES_PROTOCOL support
2023-01-05 17:01 [PATCH edk2-platforms] Platform/RPi4: Add EFI_MP_SERVICES_PROTOCOL support Ard Biesheuvel
2023-01-06 6:52 ` [edk2-devel] " Laszlo Ersek
@ 2023-01-06 17:39 ` quic_rcran
1 sibling, 0 replies; 3+ messages in thread
From: quic_rcran @ 2023-01-06 17:39 UTC (permalink / raw)
To: Ard Biesheuvel, devel; +Cc: quic_llindhol
Reviewed-by: Rebecca Cran <rebecca@quicinc.com>
--
Rebecca Cran
On 1/5/23 10:01, Ard Biesheuvel wrote:
> Fix the ARM_MPCORE_INFO table and incorporate the DXE driver and test
> app to the build so that EFI_MP_SERVICES_PROTOCOL can be used and tested
> on Raspberry Pi 4. Note that the test app is not added to the image - it
> can be taken from the build directory and executed from the UEFI shell.
>
> Signed-off-by: Ard Biesheuvel <ardb@kernel.org>
> ---
> Platform/RaspberryPi/RPi4/RPi4.dsc | 3 +++
> Platform/RaspberryPi/RPi4/RPi4.fdf | 1 +
> Platform/RaspberryPi/Library/PlatformLib/RaspberryPi.c | 8 ++++----
> 3 files changed, 8 insertions(+), 4 deletions(-)
>
> diff --git a/Platform/RaspberryPi/RPi4/RPi4.dsc b/Platform/RaspberryPi/RPi4/RPi4.dsc
> index 8ba0ca61851e..4b2b6d1e4b97 100644
> --- a/Platform/RaspberryPi/RPi4/RPi4.dsc
> +++ b/Platform/RaspberryPi/RPi4/RPi4.dsc
> @@ -795,3 +795,6 @@ [Components.common]
> gEfiShellPkgTokenSpaceGuid.PcdShellLibAutoInitialize|FALSE
> }
> !endif
> +
> + ArmPkg/Drivers/ArmPsciMpServicesDxe/ArmPsciMpServicesDxe.inf
> + MdeModulePkg/Application/MpServicesTest/MpServicesTest.inf
> diff --git a/Platform/RaspberryPi/RPi4/RPi4.fdf b/Platform/RaspberryPi/RPi4/RPi4.fdf
> index 0c782d2f3553..816927761513 100644
> --- a/Platform/RaspberryPi/RPi4/RPi4.fdf
> +++ b/Platform/RaspberryPi/RPi4/RPi4.fdf
> @@ -198,6 +198,7 @@ [FV.FvMain]
> INF EmbeddedPkg/RealTimeClockRuntimeDxe/RealTimeClockRuntimeDxe.inf
> INF EmbeddedPkg/MetronomeDxe/MetronomeDxe.inf
> INF MdeModulePkg/Universal/HiiDatabaseDxe/HiiDatabaseDxe.inf
> + INF ArmPkg/Drivers/ArmPsciMpServicesDxe/ArmPsciMpServicesDxe.inf
>
> #
> # Multiple Console IO support
> diff --git a/Platform/RaspberryPi/Library/PlatformLib/RaspberryPi.c b/Platform/RaspberryPi/Library/PlatformLib/RaspberryPi.c
> index f032f3c79238..0b0943431889 100644
> --- a/Platform/RaspberryPi/Library/PlatformLib/RaspberryPi.c
> +++ b/Platform/RaspberryPi/Library/PlatformLib/RaspberryPi.c
> @@ -51,10 +51,10 @@ ArmPlatformInitializeSystemMemory (
> }
>
> STATIC ARM_CORE_INFO mRpi3InfoTable[] = {
> - { 0x0, 0x0, }, // Cluster 0, Core 0
> - { 0x0, 0x1, }, // Cluster 0, Core 1
> - { 0x0, 0x2, }, // Cluster 0, Core 2
> - { 0x0, 0x3, }, // Cluster 0, Core 3
> + { 0x0, }, // Cluster 0, Core 0
> + { 0x1, }, // Cluster 0, Core 1
> + { 0x2, }, // Cluster 0, Core 2
> + { 0x3, }, // Cluster 0, Core 3
> };
>
> STATIC
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-01-06 17:39 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-01-05 17:01 [PATCH edk2-platforms] Platform/RPi4: Add EFI_MP_SERVICES_PROTOCOL support Ard Biesheuvel
2023-01-06 6:52 ` [edk2-devel] " Laszlo Ersek
2023-01-06 17:39 ` quic_rcran
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox