From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mx.groups.io with SMTP id smtpd.web10.7988.1672985362963297274 for ; Thu, 05 Jan 2023 22:09:23 -0800 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: arm.com, ip: 217.140.110.172, mailfrom: sahil@arm.com) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 690A7113E; Thu, 5 Jan 2023 22:10:04 -0800 (PST) Received: from usa.arm.com (a077434.blr.arm.com [10.162.17.62]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id D9B973F71A; Thu, 5 Jan 2023 22:09:20 -0800 (PST) From: "sahil" To: devel@edk2.groups.io Cc: Ard Biesheuvel , Leif Lindholm , Sami Mujawar , Sahil Subject: [edk2-platforms][PATCH V1 1/1] Platform/ARM/N1Sdp: Modify IRQ ID of Debug UART and routing to IOFPGA UART1 Date: Fri, 6 Jan 2023 11:39:15 +0530 Message-Id: <20230106060915.3050046-1-sahil@arm.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable From: Himanshu Sharma In DBG2 table, IRQ ID was set as 0 for the UART. This overwrote the IPI0 trigger method to "level", which prevented SGI0 to be enabled again after a CPU offline/online cycle. This patch fixes the above issue by assigning a reserved IRQ ID for the Debug UART, other than 0 and also routing it to use IOFPGA UART1 by unsharing it from currently using serial terminal. Signed-off-by: Himanshu Sharma --- Platform/ARM/N1Sdp/N1SdpPlatform.dsc = | 8 ++++---- Platform/ARM/N1Sdp/ConfigurationManager/ConfigurationManagerDxe/Configurat= ionManager.c | 2 +- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/Platform/ARM/N1Sdp/N1SdpPlatform.dsc b/Platform/ARM/N1Sdp/N1Sd= pPlatform.dsc index d04b22d3ef51..676ab677257a 100644 --- a/Platform/ARM/N1Sdp/N1SdpPlatform.dsc +++ b/Platform/ARM/N1Sdp/N1SdpPlatform.dsc @@ -4,7 +4,7 @@ # This provides platform specific component descriptions and libraries tha= t=0D # conform to EFI/Framework standards.=0D #=0D -# Copyright (c) 2018 - 2021, ARM Limited. All rights reserved.
=0D +# Copyright (c) 2018 - 2023, ARM Limited. All rights reserved.
=0D #=0D # SPDX-License-Identifier: BSD-2-Clause-Patent=0D #=0D @@ -136,9 +136,9 @@ [PcdsFixedAtBuild.common] gArmPlatformTokenSpaceGuid.PL011UartInterrupt|95=0D =0D # PL011 Serial Debug UART (DBG2)=0D - gArmPlatformTokenSpaceGuid.PcdSerialDbgRegisterBase|gEfiMdeModulePkgToke= nSpaceGuid.PcdSerialRegisterBase=0D - gArmPlatformTokenSpaceGuid.PcdSerialDbgUartBaudRate|gEfiMdePkgTokenSpace= Guid.PcdUartDefaultBaudRate=0D - gArmPlatformTokenSpaceGuid.PcdSerialDbgUartClkInHz|50000000=0D + gArmPlatformTokenSpaceGuid.PcdSerialDbgRegisterBase|0x1C0A0000=0D + gArmPlatformTokenSpaceGuid.PcdSerialDbgUartBaudRate|115200=0D + gArmPlatformTokenSpaceGuid.PcdSerialDbgUartClkInHz|24000000=0D =0D # SBSA Watchdog=0D gArmTokenSpaceGuid.PcdGenericWatchdogEl2IntrNum|93=0D diff --git a/Platform/ARM/N1Sdp/ConfigurationManager/ConfigurationManagerDx= e/ConfigurationManager.c b/Platform/ARM/N1Sdp/ConfigurationManager/Configur= ationManagerDxe/ConfigurationManager.c index b11c0425fe25..44046a0026bb 100644 --- a/Platform/ARM/N1Sdp/ConfigurationManager/ConfigurationManagerDxe/Confi= gurationManager.c +++ b/Platform/ARM/N1Sdp/ConfigurationManager/ConfigurationManagerDxe/Confi= gurationManager.c @@ -320,7 +320,7 @@ EDKII_PLATFORM_REPOSITORY_INFO N1sdpRepositoryInfo =3D { // Debug Serial Port=0D {=0D FixedPcdGet64 (PcdSerialDbgRegisterBase), // BaseAddress= =0D - 0, // Interrupt -= unused=0D + 250, // Interrupt (= reserved)=0D FixedPcdGet64 (PcdSerialDbgUartBaudRate), // BaudRate=0D FixedPcdGet32 (PcdSerialDbgUartClkInHz), // Clock=0D EFI_ACPI_DBG2_PORT_SUBTYPE_SERIAL_ARM_PL011_UART // Port subtyp= e=0D --=20 2.25.1