From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.groups.io with SMTP id smtpd.web11.8205.1672987690704312016 for ; Thu, 05 Jan 2023 22:48:10 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=DgfF0C72; spf=pass (domain: redhat.com, ip: 170.10.133.124, mailfrom: kraxel@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1672987689; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=IrqaRHytfPIOiS8uChic2NC9QMEuZa9Q8SoXsJf5Fwc=; b=DgfF0C72LdWXYDMz8afnE1w8+I1JO4yYnbGTqerhPLi9URvC4YC5yxeJfhku+f+WCwVTID dOy6+2D/gqqIktvFuKvBnKwG7CU7lGsiUs95fkp6NthhleIQyYfU4ISNO2XhukeM9pIdZM sD5I0S0DS3sLqp3ZdEStfXmbsR682ig= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-588-knXtOXN1NR6bCb6HTKsIlw-1; Fri, 06 Jan 2023 01:48:03 -0500 X-MC-Unique: knXtOXN1NR6bCb6HTKsIlw-1 Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id C0DFB299E756; Fri, 6 Jan 2023 06:48:02 +0000 (UTC) Received: from sirius.home.kraxel.org (unknown [10.39.192.238]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 89ED9492B00; Fri, 6 Jan 2023 06:48:02 +0000 (UTC) Received: by sirius.home.kraxel.org (Postfix, from userid 1000) id 477BA1800081; Fri, 6 Jan 2023 07:48:01 +0100 (CET) Date: Fri, 6 Jan 2023 07:48:01 +0100 From: "Gerd Hoffmann" To: "Xu, Min M" Cc: "devel@edk2.groups.io" , Anthony Perard , Ard Biesheuvel , Brijesh Singh , "Aktas, Erdem" , James Bottomley , "Yao, Jiewen" , "Justen, Jordan L" , Julien Grall , Laszlo Ersek , Peter Grehan , Rebecca Cran , "Boeuf, Sebastien" , Tom Lendacky Subject: Re: [PATCH V1 1/1] OvmfPkg/IntelTdxX64: Raise DXEFV size to 13MB Message-ID: <20230106064801.wklkbaorb35wc2pj@sirius.home.kraxel.org> References: <20230105072105.144-1-min.m.xu@intel.com> <20230105113158.lq5r5zxuyrgapqjy@sirius.home.kraxel.org> MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 3.1 on 10.11.54.10 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Fri, Jan 06, 2023 at 12:49:21AM +0000, Xu, Min M wrote: > On January 5, 2023 7:32 PM, Gerd Hoffmann wrote: > > > > On Thu, Jan 05, 2023 at 03:21:05PM +0800, Min Xu wrote: > > > From: Min M Xu > > > > > > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4236 > > > > > > Similarly to the "cadence" mentioned in commit d272449 ("OvmfPkg: > > > raise DXEFV size to 11 MB", 2018-05-29), it's been ~1.75 years since > > > commit 5e75c4d ("OvmfPkg: raise DXEFV size to 12 MB", 2020-03-11), and > > > we've outgrown DXEFV again (with NOOPT builds). Increase the DXEFV > > > size of IntelTdxX64 to 13MB now. > > > > Not sure this makes sense given that you want split DXEFV into two smaller > > volumes for IntelTdx (patch series sent in december IIRC). > > > Thanks Gerd for the comments. > I think raising DXEFV size and split DXEFV into 2 FVs are for different purpose and they're not conflicted. > > The purpose of raising DXEFV size is to enlarge the FV so that more drivers can be hosted. > > The purpose of splitting DXEFV are: > 1) Reduce the attack surface in CC guest. > 2) Improve boot perf in CC guest. This also makes DXEFV smaller to make room for the new Firmware Volume. So you change DXEFV size twice in a row. I would avoid that and just pick reasonable sizes for both volumes in the split patch series instead. take care, Gerd