From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mx.groups.io with SMTP id smtpd.web11.13902.1673013850327382170 for ; Fri, 06 Jan 2023 06:04:10 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=CwW7QMEu; spf=pass (domain: redhat.com, ip: 170.10.129.124, mailfrom: kraxel@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1673013849; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=dTGj0s5N1j9pDV7GYgbepuD2qBJiONxNV0rSsII4z+E=; b=CwW7QMEu+Y80Mr5eTeHEcT8jXR0xD5gC1ulL7c8N1E6IK/fwH6LOgHvv4IfODWXc7E5SmD hO2KLEh6KuKUEtx3dCt+3yPCVAb0lMWLKrp1o2N6Orlyjk1ibKfVuaUsKpurMBt/hIBqOu JRrTMngd3MEXnC8hDmhG9vPugDpcU1g= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-55-tp9cu63eMg2aANr0ptT0yg-1; Fri, 06 Jan 2023 09:04:05 -0500 X-MC-Unique: tp9cu63eMg2aANr0ptT0yg-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id E16971C00422; Fri, 6 Jan 2023 14:04:04 +0000 (UTC) Received: from sirius.home.kraxel.org (unknown [10.39.192.238]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 9D59839D6D; Fri, 6 Jan 2023 14:04:04 +0000 (UTC) Received: by sirius.home.kraxel.org (Postfix, from userid 1000) id 2EBFD18009A7; Fri, 6 Jan 2023 15:04:03 +0100 (CET) From: "Gerd Hoffmann" To: devel@edk2.groups.io Cc: Ard Biesheuvel , =?UTF-8?q?L=C3=A1szl=C3=B3=20=C3=89rsek?= , Jordan Justen , Pawel Polawski , Oliver Steffen , Jiewen Yao , Gerd Hoffmann Subject: [PATCH 1/2] OvmfPkg/PlatformInitLib: update PlatformScanOrAdd64BitE820Ram documentation Date: Fri, 6 Jan 2023 15:04:02 +0100 Message-Id: <20230106140403.2889131-2-kraxel@redhat.com> In-Reply-To: <20230106140403.2889131-1-kraxel@redhat.com> References: <20230106140403.2889131-1-kraxel@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.5 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII"; x-default=true Documentation of PlatformScanOrAdd64BitE820Ram() ran out of sync with the implementation. Fix that. Signed-off-by: Gerd Hoffmann --- OvmfPkg/Library/PlatformInitLib/MemDetect.c | 16 ++++++++++------ 1 file changed, 10 insertions(+), 6 deletions(-) diff --git a/OvmfPkg/Library/PlatformInitLib/MemDetect.c b/OvmfPkg/Library/PlatformInitLib/MemDetect.c index 0c4956852689..1255d6300fdd 100644 --- a/OvmfPkg/Library/PlatformInitLib/MemDetect.c +++ b/OvmfPkg/Library/PlatformInitLib/MemDetect.c @@ -121,15 +121,19 @@ PlatformQemuUc32BaseInitialization ( Find the highest exclusive >=4GB RAM address, or produce memory resource descriptor HOBs for RAM entries that start at or above 4GB. - @param[out] MaxAddress If MaxAddress is NULL, then PlatformScanOrAdd64BitE820Ram() + @param[in] AddHighHob If True then PlatformScanOrAdd64BitE820Ram() produces memory resource descriptor HOBs for RAM entries that start at or above 4GB. + It also produces HOBs for reserved entries. - Otherwise, MaxAddress holds the highest exclusive - >=4GB RAM address on output. If QEMU's fw_cfg E820 - RAM map contains no RAM entry that starts outside of - the 32-bit address range, then MaxAddress is exactly - 4GB on output. + @param[out] LowMemory If Lowmemory is not NULL, then Lowmemory MaxAddress + holds the amout of emory below 4G on output. + + @param[out] MaxAddress If MaxAddress is not NULL, then MaxAddress holds + the highest exclusive >=4GB RAM address on output. + If QEMU's fw_cfg E820 RAM map contains no RAM entry + that starts outside of the 32-bit address range, + then MaxAddress is exactly 4GB on output. @retval EFI_SUCCESS The fw_cfg E820 RAM map was found and processed. -- 2.39.0